Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65187/?format=api
{ "id": 65187, "url": "http://patches.dpdk.org/api/patches/65187/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200128062357.9316-8-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200128062357.9316-8-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200128062357.9316-8-somnath.kotur@broadcom.com", "date": "2020-01-28T06:23:56", "name": "[7/8] net/bnxt: remove a redundant variable", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "54582ac614fdc31c1744e4d235c9d781a2242bc3", "submitter": { "id": 908, "url": "http://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200128062357.9316-8-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 8313, "url": "http://patches.dpdk.org/api/series/8313/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8313", "date": "2020-01-28T06:23:50", "name": "bnxt patch set", "version": 1, "mbox": "http://patches.dpdk.org/series/8313/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65187/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65187/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5D4F6A04B3;\n\tTue, 28 Jan 2020 07:26:28 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8CEAD1C11B;\n\tTue, 28 Jan 2020 07:25:33 +0100 (CET)", "from relay.smtp.broadcom.com (relay.smtp.broadcom.com\n [192.19.211.62]) by dpdk.org (Postfix) with ESMTP id 3FB311C06A\n for <dev@dpdk.org>; Tue, 28 Jan 2020 07:25:23 +0100 (CET)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n (dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id 8168F29050C;\n Mon, 27 Jan 2020 22:25:22 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 8168F29050C", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1580192722;\n bh=xaIO0fdXJkF6wS/TeAuljuAXNBm4yXJPFsDjpCRDIt8=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=TX6fWT8iikEf/8nmoI4rxlt2OrSO/ZTeKv42bUPqeDSomYYf1UgEAEiPXL8IYKQ5A\n PwQFMct7IzYJ/UnHsqHheYFtC/fIjmPYaIFpc8OrGVZ8FpnM8QZRHjJpPAx4sJ1WZw\n 7mQhWxkclki45LGps4K4vTVwkbxS+zGsSLvQUC8A=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Tue, 28 Jan 2020 11:53:56 +0530", "Message-Id": "<20200128062357.9316-8-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70", "In-Reply-To": "<20200128062357.9316-1-somnath.kotur@broadcom.com>", "References": "<20200128062357.9316-1-somnath.kotur@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 7/8] net/bnxt: remove a redundant variable", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nUse \"dev->data->dev_started\" state, instead of local \"dev_stopped\"\nto check whether port has been started or not.\n\nFixes: 316e412299fd (\"net/bnxt: fix crash when closing\")\n\nReviewed-by: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 1 -\n drivers/net/bnxt/bnxt_ethdev.c | 21 +++++++++------------\n 2 files changed, 9 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex 434ce28..1a5d542 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -648,7 +648,6 @@ struct bnxt {\n #define BNXT_OUTER_TPID_BD_SHFT\t16\n \tuint32_t\t\touter_tpid_bd;\n \tstruct bnxt_pf_info\tpf;\n-\tuint8_t\t\t\tdev_stopped;\n \tuint8_t\t\t\tvxlan_port_cnt;\n \tuint8_t\t\t\tgeneve_port_cnt;\n \tuint16_t\t\tvxlan_port;\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex b04685c..72e5441 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -872,9 +872,9 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)\n \t\tgoto error;\n \n \teth_dev->data->scattered_rx = bnxt_scattered_rx(eth_dev);\n+\teth_dev->data->dev_started = 1;\n \n \tbnxt_link_update(eth_dev, 1, ETH_LINK_UP);\n-\tbp->dev_stopped = 0;\n \n \tif (rx_offloads & DEV_RX_OFFLOAD_VLAN_FILTER)\n \t\tvlan_mask |= ETH_VLAN_FILTER_MASK;\n@@ -887,7 +887,6 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)\n \teth_dev->rx_pkt_burst = bnxt_receive_function(eth_dev);\n \teth_dev->tx_pkt_burst = bnxt_transmit_function(eth_dev);\n \n-\teth_dev->data->dev_started = 1;\n \tpthread_mutex_lock(&bp->def_cp_lock);\n \tbnxt_schedule_fw_health_check(bp);\n \tpthread_mutex_unlock(&bp->def_cp_lock);\n@@ -898,7 +897,7 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)\n \tbnxt_shutdown_nic(bp);\n \tbnxt_free_tx_mbufs(bp);\n \tbnxt_free_rx_mbufs(bp);\n-\tbp->dev_stopped = 1;\n+\teth_dev->data->dev_started = 0;\n \treturn rc;\n }\n \n@@ -973,7 +972,6 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)\n \tbp->mark_table = NULL;\n \n \tbp->flags &= ~BNXT_FLAG_RX_VECTOR_PKT_MODE;\n-\tbp->dev_stopped = 1;\n \tbp->rx_cosq_cnt = 0;\n }\n \n@@ -981,7 +979,7 @@ static void bnxt_dev_close_op(struct rte_eth_dev *eth_dev)\n {\n \tstruct bnxt *bp = eth_dev->data->dev_private;\n \n-\tif (bp->dev_stopped == 0)\n+\tif (eth_dev->data->dev_started)\n \t\tbnxt_dev_stop_op(eth_dev);\n \n \tbnxt_uninit_resources(bp, false);\n@@ -1174,7 +1172,7 @@ static int bnxt_promiscuous_enable_op(struct rte_eth_dev *eth_dev)\n \t\treturn rc;\n \n \t/* Filter settings will get applied when port is started */\n-\tif (bp->dev_stopped == 1)\n+\tif (!eth_dev->data->dev_started)\n \t\treturn 0;\n \n \tif (bp->vnic_info == NULL)\n@@ -1203,7 +1201,7 @@ static int bnxt_promiscuous_disable_op(struct rte_eth_dev *eth_dev)\n \t\treturn rc;\n \n \t/* Filter settings will get applied when port is started */\n-\tif (bp->dev_stopped == 1)\n+\tif (!eth_dev->data->dev_started)\n \t\treturn 0;\n \n \tif (bp->vnic_info == NULL)\n@@ -1232,7 +1230,7 @@ static int bnxt_allmulticast_enable_op(struct rte_eth_dev *eth_dev)\n \t\treturn rc;\n \n \t/* Filter settings will get applied when port is started */\n-\tif (bp->dev_stopped == 1)\n+\tif (!eth_dev->data->dev_started)\n \t\treturn 0;\n \n \tif (bp->vnic_info == NULL)\n@@ -1261,7 +1259,7 @@ static int bnxt_allmulticast_disable_op(struct rte_eth_dev *eth_dev)\n \t\treturn rc;\n \n \t/* Filter settings will get applied when port is started */\n-\tif (bp->dev_stopped == 1)\n+\tif (!eth_dev->data->dev_started)\n \t\treturn 0;\n \n \tif (bp->vnic_info == NULL)\n@@ -1985,7 +1983,7 @@ static int bnxt_free_one_vnic(struct bnxt *bp, uint16_t vnic_id)\n \t\treturn rc;\n \n \t/* Filter settings will get applied when port is started */\n-\tif (bp->dev_stopped == 1)\n+\tif (!dev->data->dev_started)\n \t\treturn 0;\n \n \tif (mask & ETH_VLAN_FILTER_MASK) {\n@@ -3887,7 +3885,7 @@ static void bnxt_dev_cleanup(struct bnxt *bp)\n {\n \tbnxt_set_hwrm_link_config(bp, false);\n \tbp->link_info.link_up = 0;\n-\tif (bp->dev_stopped == 0)\n+\tif (bp->eth_dev->data->dev_started)\n \t\tbnxt_dev_stop_op(bp->eth_dev);\n \n \tbnxt_uninit_resources(bp, true);\n@@ -4824,7 +4822,6 @@ static int bnxt_init_resources(struct bnxt *bp, bool reconfig_dev)\n \n \tbp = eth_dev->data->dev_private;\n \n-\tbp->dev_stopped = 1;\n \tbp->flags &= ~BNXT_FLAG_RX_VECTOR_PKT_MODE;\n \n \tif (bnxt_vf_pciid(pci_dev->id.device_id))\n", "prefixes": [ "7/8" ] }