Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65186/?format=api
{ "id": 65186, "url": "http://patches.dpdk.org/api/patches/65186/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200128062357.9316-7-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200128062357.9316-7-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200128062357.9316-7-somnath.kotur@broadcom.com", "date": "2020-01-28T06:23:55", "name": "[6/8] net/bnxt: remove unnecessary structure variable", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a51befb6fc4103f24e93850f09cc2b6eea2080ec", "submitter": { "id": 908, "url": "http://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200128062357.9316-7-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 8313, "url": "http://patches.dpdk.org/api/series/8313/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8313", "date": "2020-01-28T06:23:50", "name": "bnxt patch set", "version": 1, "mbox": "http://patches.dpdk.org/series/8313/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65186/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65186/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E53BAA04B3;\n\tTue, 28 Jan 2020 07:26:15 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1AB561C117;\n\tTue, 28 Jan 2020 07:25:32 +0100 (CET)", "from relay.smtp.broadcom.com (relay.smtp.broadcom.com\n [192.19.211.62]) by dpdk.org (Postfix) with ESMTP id E95C91BFD1\n for <dev@dpdk.org>; Tue, 28 Jan 2020 07:25:22 +0100 (CET)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n (dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id 3680B290508;\n Mon, 27 Jan 2020 22:25:22 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 3680B290508", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1580192722;\n bh=pGXIiqnNHmCKaX6swV7ViGmjaFczWQkNef0yncMpOu4=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=O3eB36kxCRjneSaZ6+SPQRTQsE1AA0guwMuU0wuhosxpoH8nmTC6mswcKVAtpjcmC\n GVJWZ0nqW2Op8/gXoSp7rsf5smDJu4TUcwdjhc+0+P62VPrMHeLKfmgi2mQKtuKy/N\n 6ly5XTC+fgNbu/H9Ag16XSiHgGRw9KkS8B9cSfMU=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Tue, 28 Jan 2020 11:53:55 +0530", "Message-Id": "<20200128062357.9316-7-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70", "In-Reply-To": "<20200128062357.9316-1-somnath.kotur@broadcom.com>", "References": "<20200128062357.9316-1-somnath.kotur@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 6/8] net/bnxt: remove unnecessary structure\n\tvariable", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nThis change could help in reducing the size of bnxt PMD private\ndata structure by converting a uint8_t variable to use bit map flag.\n\nFixes: 5cd0e2889c432 (\"net/bnxt: support NIC Partitioning\")\n\nReviewed-by: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 4 ++--\n drivers/net/bnxt/bnxt_hwrm.c | 4 ++--\n 2 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex 95f1f1a..434ce28 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -520,12 +520,13 @@ struct bnxt {\n #define BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED\tBIT(18)\n #define BNXT_FLAG_EXT_STATS_SUPPORTED\t\tBIT(19)\n #define BNXT_FLAG_NEW_RM\t\t\tBIT(20)\n+#define BNXT_FLAG_NPAR_PF\t\t\tBIT(21)\n #define BNXT_FLAG_FW_CAP_ONE_STEP_TX_TS\t\tBIT(22)\n #define BNXT_FLAG_ADV_FLOW_MGMT\t\t\tBIT(23)\n #define BNXT_FLAG_RX_VECTOR_PKT_MODE\t\tBIT(24)\n #define BNXT_PF(bp)\t\t(!((bp)->flags & BNXT_FLAG_VF))\n #define BNXT_VF(bp)\t\t((bp)->flags & BNXT_FLAG_VF)\n-#define BNXT_NPAR(bp)\t\t((bp)->port_partition_type)\n+#define BNXT_NPAR(bp)\t\t((bp)->flags & BNXT_FLAG_NPAR_PF)\n #define BNXT_MH(bp) ((bp)->flags & BNXT_FLAG_MULTI_HOST)\n #define BNXT_SINGLE_PF(bp) (BNXT_PF(bp) && !BNXT_NPAR(bp) && !BNXT_MH(bp))\n #define BNXT_USE_CHIMP_MB\t0 //For non-CFA commands, everything uses Chimp.\n@@ -647,7 +648,6 @@ struct bnxt {\n #define BNXT_OUTER_TPID_BD_SHFT\t16\n \tuint32_t\t\touter_tpid_bd;\n \tstruct bnxt_pf_info\tpf;\n-\tuint8_t\t\t\tport_partition_type;\n \tuint8_t\t\t\tdev_stopped;\n \tuint8_t\t\t\tvxlan_port_cnt;\n \tuint8_t\t\t\tgeneve_port_cnt;\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 460cc48..f325aff 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -2952,10 +2952,10 @@ int bnxt_hwrm_func_qcfg(struct bnxt *bp, uint16_t *mtu)\n \tcase HWRM_FUNC_QCFG_OUTPUT_PORT_PARTITION_TYPE_NPAR1_5:\n \tcase HWRM_FUNC_QCFG_OUTPUT_PORT_PARTITION_TYPE_NPAR2_0:\n \t\t/* FALLTHROUGH */\n-\t\tbp->port_partition_type = resp->port_partition_type;\n+\t\tbp->flags |= BNXT_FLAG_NPAR_PF;\n \t\tbreak;\n \tdefault:\n-\t\tbp->port_partition_type = 0;\n+\t\tbp->flags &= ~BNXT_FLAG_NPAR_PF;\n \t\tbreak;\n \t}\n \n", "prefixes": [ "6/8" ] }