Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65184/?format=api
http://patches.dpdk.org/api/patches/65184/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200128062357.9316-5-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200128062357.9316-5-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200128062357.9316-5-somnath.kotur@broadcom.com", "date": "2020-01-28T06:23:53", "name": "[4/8] net/bnxt: remove redundant if statement", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0cc1c34bcde9a295e10e69e362ea4800035386da", "submitter": { "id": 908, "url": "http://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200128062357.9316-5-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 8313, "url": "http://patches.dpdk.org/api/series/8313/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8313", "date": "2020-01-28T06:23:50", "name": "bnxt patch set", "version": 1, "mbox": "http://patches.dpdk.org/series/8313/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65184/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65184/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8FE0EA04B3;\n\tTue, 28 Jan 2020 07:25:56 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 69FBA1C0D8;\n\tTue, 28 Jan 2020 07:25:29 +0100 (CET)", "from relay.smtp.broadcom.com (relay.smtp.broadcom.com\n [192.19.211.62]) by dpdk.org (Postfix) with ESMTP id 54E8E1BFD1\n for <dev@dpdk.org>; Tue, 28 Jan 2020 07:25:22 +0100 (CET)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n (dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id 8B673290506;\n Mon, 27 Jan 2020 22:25:21 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 8B673290506", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1580192721;\n bh=PSpNTerWi5+zKXPoVnqPaolalqu+l7meELcXv2FhZAY=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=a9csinovZIQBMhQzJqaYBW/F1a7L9Vv3L0NRvy1z6cTRa+2hGku+bY7iRNlR0AWol\n 6oJ1WJracfiYKMcmBiRHL+lQ2nK38ttEc/WKW0mp3enA5ltlMVlijybD4uZrCWR8Fi\n pxIA/EfcDkbwbH3Iw7Z1RSno2laPYOKQlFV18i+4=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Tue, 28 Jan 2020 11:53:53 +0530", "Message-Id": "<20200128062357.9316-5-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70", "In-Reply-To": "<20200128062357.9316-1-somnath.kotur@broadcom.com>", "References": "<20200128062357.9316-1-somnath.kotur@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 4/8] net/bnxt: remove redundant if statement", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nSince \"eth_dev->data->dev_started\" has been assigned to 0 at the\nbeginning of bnxt_dev_stop_op() routine, the code inside the if()\ncondition is redundant. Remove it.\n\nAnyways \"eth_dev->data->dev_link.link_status\" will be set to 0 in\nbnxt_dev_set_link_down_op() later in the routine.\n\nFixes: 316e412299fd (\"net/bnxt: fix crash when closing\")\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 4 ----\n 1 file changed, 4 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex fc3f1a8..267a361 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -948,10 +948,6 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)\n \tbnxt_cancel_fw_health_check(bp);\n \n \tbp->flags &= ~BNXT_FLAG_INIT_DONE;\n-\tif (bp->eth_dev->data->dev_started) {\n-\t\t/* TBD: STOP HW queues DMA */\n-\t\teth_dev->data->dev_link.link_status = 0;\n-\t}\n \tbnxt_dev_set_link_down_op(eth_dev);\n \n \t/* Wait for link to be reset and the async notification to process.\n", "prefixes": [ "4/8" ] }{ "id": 65184, "url": "