Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 65182,
    "url": "http://patches.dpdk.org/api/patches/65182/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200128062357.9316-3-somnath.kotur@broadcom.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200128062357.9316-3-somnath.kotur@broadcom.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200128062357.9316-3-somnath.kotur@broadcom.com",
    "date": "2020-01-28T06:23:51",
    "name": "[2/8] net/bnxt: fix bumping of L2 filter reference count",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "d750654c3e336afbdc8c44f7bc808ac4871d6b38",
    "submitter": {
        "id": 908,
        "url": "http://patches.dpdk.org/api/people/908/?format=api",
        "name": "Somnath Kotur",
        "email": "somnath.kotur@broadcom.com"
    },
    "delegate": {
        "id": 1766,
        "url": "http://patches.dpdk.org/api/users/1766/?format=api",
        "username": "ajitkhaparde",
        "first_name": "Ajit",
        "last_name": "Khaparde",
        "email": "ajit.khaparde@broadcom.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200128062357.9316-3-somnath.kotur@broadcom.com/mbox/",
    "series": [
        {
            "id": 8313,
            "url": "http://patches.dpdk.org/api/series/8313/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8313",
            "date": "2020-01-28T06:23:50",
            "name": "bnxt patch set",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/8313/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/65182/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/65182/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C3C8DA04B3;\n\tTue, 28 Jan 2020 07:25:37 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B1A271C0C7;\n\tTue, 28 Jan 2020 07:25:26 +0100 (CET)",
            "from relay.smtp.broadcom.com (relay.smtp.broadcom.com\n [192.19.211.62]) by dpdk.org (Postfix) with ESMTP id AA5061C06A\n for <dev@dpdk.org>; Tue, 28 Jan 2020 07:25:21 +0100 (CET)",
            "from dhcp-10-123-153-55.dhcp.broadcom.net\n (dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id E9BF0290500;\n Mon, 27 Jan 2020 22:25:20 -0800 (PST)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com E9BF0290500",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1580192721;\n bh=i2Pg6T6ESlCpma+7iFvqT2y1wPPpwiX9kovHgd8SNRk=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=Ssyar+lIktUdSLN210obtb4Rv6bHHXPCkcBPg2RA9R13tasWt9nZLRsdXgolvLuDt\n 4COm8Bgk001d594tHC0Elk/8iBuDu7nS6sGJMrrAXeBJxMG62fC2IzACRgP//aYtgg\n wO3mlW6bq2h54hJyxIEVTH4mxlxzMbe7aNzYb+pw=",
        "From": "Somnath Kotur <somnath.kotur@broadcom.com>",
        "To": "dev@dpdk.org",
        "Cc": "ferruh.yigit@intel.com",
        "Date": "Tue, 28 Jan 2020 11:53:51 +0530",
        "Message-Id": "<20200128062357.9316-3-somnath.kotur@broadcom.com>",
        "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70",
        "In-Reply-To": "<20200128062357.9316-1-somnath.kotur@broadcom.com>",
        "References": "<20200128062357.9316-1-somnath.kotur@broadcom.com>",
        "Subject": "[dpdk-dev] [PATCH 2/8] net/bnxt: fix bumping of L2 filter reference\n\tcount",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Now that the L2 filter reference count is bumped up in all cases\nincluding bnxt_alloc_filter() which is issued in init, just move this\nref count bump inside the routine issuing the HWRM cmd so that it is\nbumped up only if the cmd is successful.\n\nFixes: f0f6b5e6cf94 (\"fix reusing L2 filter\")\n\nReviewed-by: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_filter.c | 3 +--\n drivers/net/bnxt/bnxt_flow.c   | 1 -\n drivers/net/bnxt/bnxt_hwrm.c   | 2 ++\n 3 files changed, 3 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/drivers/net/bnxt/bnxt_filter.c b/drivers/net/bnxt/bnxt_filter.c\nindex e218433..a1463a0 100644\n--- a/drivers/net/bnxt/bnxt_filter.c\n+++ b/drivers/net/bnxt/bnxt_filter.c\n@@ -39,8 +39,7 @@ struct bnxt_filter_info *bnxt_alloc_filter(struct bnxt *bp)\n \t\t\tHWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_ADDR_MASK;\n \tmemcpy(filter->l2_addr, bp->mac_addr, RTE_ETHER_ADDR_LEN);\n \tmemset(filter->l2_addr_mask, 0xff, RTE_ETHER_ADDR_LEN);\n-\t/* bump up the reference count of filter */\n-\tfilter->l2_ref_cnt++;\n+\n \treturn filter;\n }\n \ndiff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c\nindex 5564c53..4b3b597 100644\n--- a/drivers/net/bnxt/bnxt_flow.c\n+++ b/drivers/net/bnxt/bnxt_flow.c\n@@ -867,7 +867,6 @@\n \t\tbnxt_free_filter(bp, filter1);\n \t\treturn NULL;\n \t}\n-\tfilter1->l2_ref_cnt++;\n \treturn filter1;\n }\n \ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 3b01339..460cc48 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -488,6 +488,8 @@ int bnxt_hwrm_set_l2_filter(struct bnxt *bp,\n \tfilter->flow_id = rte_le_to_cpu_32(resp->flow_id);\n \tHWRM_UNLOCK();\n \n+\tfilter->l2_ref_cnt++;\n+\n \treturn rc;\n }\n \n",
    "prefixes": [
        "2/8"
    ]
}