Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65170/?format=api
{ "id": 65170, "url": "http://patches.dpdk.org/api/patches/65170/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200128053506.2173-3-pbhagavatula@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200128053506.2173-3-pbhagavatula@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200128053506.2173-3-pbhagavatula@marvell.com", "date": "2020-01-28T05:34:56", "name": "[v6,02/11] examples/l3fwd: split pipelines based on capability", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6177633d493065f39e3a6664e21c6c2b975ed70c", "submitter": { "id": 1183, "url": "http://patches.dpdk.org/api/people/1183/?format=api", "name": "Pavan Nikhilesh Bhagavatula", "email": "pbhagavatula@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200128053506.2173-3-pbhagavatula@marvell.com/mbox/", "series": [ { "id": 8312, "url": "http://patches.dpdk.org/api/series/8312/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8312", "date": "2020-01-28T05:34:54", "name": "example/l3fwd: introduce event device support", "version": 6, "mbox": "http://patches.dpdk.org/series/8312/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65170/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65170/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9EDAFA04B3;\n\tTue, 28 Jan 2020 06:35:32 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1D7091C035;\n\tTue, 28 Jan 2020 06:35:26 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 935601C014\n for <dev@dpdk.org>; Tue, 28 Jan 2020 06:35:24 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 00S5ZHYc020048; Mon, 27 Jan 2020 21:35:24 -0800", "from sc-exch03.marvell.com ([199.233.58.183])\n by mx0b-0016f401.pphosted.com with ESMTP id 2xrp2t2fum-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Mon, 27 Jan 2020 21:35:23 -0800", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com\n (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 27 Jan\n 2020 21:35:21 -0800", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n (10.93.176.83) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Mon, 27 Jan 2020 21:35:21 -0800", "from BG-LT7430.marvell.com (unknown [10.28.17.49])\n by maili.marvell.com (Postfix) with ESMTP id ABB8E3F703F;\n Mon, 27 Jan 2020 21:35:17 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=5TZ6ZPRYEkx2QFORxP9p7agPMDcfYHv55ga2O8GvZUU=;\n b=BT8MgpOhEafwl1ObGFlEsFe4yGIAGco6WsJC1F+U73+CyJoz9tb0KCzcxNVzPL4G3Ogg\n KmzJN/Nm5RvCP1FtoFfpEqq2qDYixxVso0n6uLlcYlBfCSS7jYHI3xzLnOjo4AKoyO/H\n xiAX4D6eM6S5ChIIw6daOFZkHmQQdH3kdlJngBNX0t2ewBlk/LE6uRDPTUlS2i4O+iDV\n vz2z1bi8kYBXKcuTzCavLofTXHcL9nQq7t4mAHowE2Q05ja3hXjqEl7Cnht7zToUzX7X\n AdH1YkxG9iloSXLALLJBvcn2p3l1xw+bmoBBM0uJTxc+o6cse5xS2BZrIeB7fHAYRpWR Yw==", "From": "<pbhagavatula@marvell.com>", "To": "<jerinj@marvell.com>, <konstantin.ananyev@intel.com>, Marko Kovacevic\n <marko.kovacevic@intel.com>, Ori Kam <orika@mellanox.com>, Bruce Richardson\n <bruce.richardson@intel.com>, Radu Nicolau <radu.nicolau@intel.com>, \"Akhil\n Goyal\" <akhil.goyal@nxp.com>, Tomasz Kantecki <tomasz.kantecki@intel.com>,\n Sunil Kumar Kori <skori@marvell.com>, Pavan Nikhilesh\n <pbhagavatula@marvell.com>", "CC": "<dev@dpdk.org>", "Date": "Tue, 28 Jan 2020 11:04:56 +0530", "Message-ID": "<20200128053506.2173-3-pbhagavatula@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200128053506.2173-1-pbhagavatula@marvell.com>", "References": "<20200124040542.2360--1-pbhagavatula@marvell.com>\n <20200128053506.2173-1-pbhagavatula@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572\n definitions=2020-01-27_08:2020-01-24,\n 2020-01-27 signatures=0", "Subject": "[dpdk-dev] [PATCH v6 02/11] examples/l3fwd: split pipelines based\n\ton capability", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Sunil Kumar Kori <skori@marvell.com>\n\nAdd infra to split eventdev framework based on event Tx adapter\ncapability.\nIf event Tx adapter has internal port capability then we use\n`rte_event_eth_tx_adapter_enqueue` to transmitting packets else\nwe use a SINGLE_LINK event queue to enqueue packets to a service\ncore which is responsible for transmitting packets.\n\nSigned-off-by: Sunil Kumar Kori <skori@marvell.com>\nAcked-by: Jerin Jacob <jerinj@marvell.com>\n---\n examples/l3fwd/Makefile | 1 +\n examples/l3fwd/l3fwd_event.c | 31 ++++++++++++++++++++++\n examples/l3fwd/l3fwd_event.h | 20 ++++++++++++++\n examples/l3fwd/l3fwd_event_generic.c | 14 ++++++++++\n examples/l3fwd/l3fwd_event_internal_port.c | 14 ++++++++++\n examples/l3fwd/meson.build | 3 ++-\n 6 files changed, 82 insertions(+), 1 deletion(-)\n create mode 100644 examples/l3fwd/l3fwd_event_generic.c\n create mode 100644 examples/l3fwd/l3fwd_event_internal_port.c", "diff": "diff --git a/examples/l3fwd/Makefile b/examples/l3fwd/Makefile\nindex c892b867b..59a110d12 100644\n--- a/examples/l3fwd/Makefile\n+++ b/examples/l3fwd/Makefile\n@@ -6,6 +6,7 @@ APP = l3fwd\n \n # all source are stored in SRCS-y\n SRCS-y := main.c l3fwd_lpm.c l3fwd_em.c l3fwd_event.c\n+SRCS-y += l3fwd_event_generic.c l3fwd_event_internal_port.c\n \n # Build using pkg-config variables if possible\n ifeq ($(shell pkg-config --exists libdpdk && echo 0),0)\ndiff --git a/examples/l3fwd/l3fwd_event.c b/examples/l3fwd/l3fwd_event.c\nindex 1040da4ea..62218f3ca 100644\n--- a/examples/l3fwd/l3fwd_event.c\n+++ b/examples/l3fwd/l3fwd_event.c\n@@ -30,6 +30,31 @@ l3fwd_get_eventdev_rsrc(void)\n \treturn NULL;\n }\n \n+static void\n+l3fwd_event_capability_setup(void)\n+{\n+\tstruct l3fwd_event_resources *evt_rsrc = l3fwd_get_eventdev_rsrc();\n+\tuint32_t caps = 0;\n+\tuint16_t i;\n+\tint ret;\n+\n+\tRTE_ETH_FOREACH_DEV(i) {\n+\t\tret = rte_event_eth_tx_adapter_caps_get(0, i, &caps);\n+\t\tif (ret)\n+\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t \"Invalid capability for Tx adptr port %d\\n\",\n+\t\t\t\t i);\n+\n+\t\tevt_rsrc->tx_mode_q |= !(caps &\n+\t\t\t\t RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT);\n+\t}\n+\n+\tif (evt_rsrc->tx_mode_q)\n+\t\tl3fwd_event_set_generic_ops(&evt_rsrc->ops);\n+\telse\n+\t\tl3fwd_event_set_internal_port_ops(&evt_rsrc->ops);\n+}\n+\n void\n l3fwd_event_resource_setup(void)\n {\n@@ -37,4 +62,10 @@ l3fwd_event_resource_setup(void)\n \n \tif (!evt_rsrc->enabled)\n \t\treturn;\n+\n+\tif (!rte_event_dev_count())\n+\t\trte_exit(EXIT_FAILURE, \"No Eventdev found\");\n+\n+\t/* Setup eventdev capability callbacks */\n+\tl3fwd_event_capability_setup();\n }\ndiff --git a/examples/l3fwd/l3fwd_event.h b/examples/l3fwd/l3fwd_event.h\nindex 4c23c4e1a..d25c8d222 100644\n--- a/examples/l3fwd/l3fwd_event.h\n+++ b/examples/l3fwd/l3fwd_event.h\n@@ -7,17 +7,37 @@\n \n #include <rte_common.h>\n #include <rte_eventdev.h>\n+#include <rte_event_eth_tx_adapter.h>\n #include <rte_spinlock.h>\n \n #include \"l3fwd.h\"\n \n+typedef uint32_t (*event_device_setup_cb)(void);\n+typedef void (*event_queue_setup_cb)(uint32_t event_queue_cfg);\n+typedef void (*event_port_setup_cb)(void);\n+typedef void (*adapter_setup_cb)(void);\n+typedef int (*event_loop_cb)(void *);\n+\n+struct l3fwd_event_setup_ops {\n+\tevent_device_setup_cb event_device_setup;\n+\tevent_queue_setup_cb event_queue_setup;\n+\tevent_port_setup_cb event_port_setup;\n+\tadapter_setup_cb adapter_setup;\n+\tevent_loop_cb lpm_event_loop;\n+\tevent_loop_cb em_event_loop;\n+};\n+\n struct l3fwd_event_resources {\n+\tstruct l3fwd_event_setup_ops ops;\n \tuint8_t sched_type;\n+\tuint8_t tx_mode_q;\n \tuint8_t enabled;\n \tuint8_t eth_rx_queues;\n };\n \n struct l3fwd_event_resources *l3fwd_get_eventdev_rsrc(void);\n void l3fwd_event_resource_setup(void);\n+void l3fwd_event_set_generic_ops(struct l3fwd_event_setup_ops *ops);\n+void l3fwd_event_set_internal_port_ops(struct l3fwd_event_setup_ops *ops);\n \n #endif /* __L3FWD_EVENTDEV_H__ */\ndiff --git a/examples/l3fwd/l3fwd_event_generic.c b/examples/l3fwd/l3fwd_event_generic.c\nnew file mode 100644\nindex 000000000..7fff850e5\n--- /dev/null\n+++ b/examples/l3fwd/l3fwd_event_generic.c\n@@ -0,0 +1,14 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(C) 2019 Marvell International Ltd.\n+ */\n+\n+#include <stdbool.h>\n+\n+#include \"l3fwd.h\"\n+#include \"l3fwd_event.h\"\n+\n+void\n+l3fwd_event_set_generic_ops(struct l3fwd_event_setup_ops *ops)\n+{\n+\tRTE_SET_USED(ops);\n+}\ndiff --git a/examples/l3fwd/l3fwd_event_internal_port.c b/examples/l3fwd/l3fwd_event_internal_port.c\nnew file mode 100644\nindex 000000000..085e9c825\n--- /dev/null\n+++ b/examples/l3fwd/l3fwd_event_internal_port.c\n@@ -0,0 +1,14 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(C) 2019 Marvell International Ltd.\n+ */\n+\n+#include <stdbool.h>\n+\n+#include \"l3fwd.h\"\n+#include \"l3fwd_event.h\"\n+\n+void\n+l3fwd_event_set_internal_port_ops(struct l3fwd_event_setup_ops *ops)\n+{\n+\tRTE_SET_USED(ops);\n+}\ndiff --git a/examples/l3fwd/meson.build b/examples/l3fwd/meson.build\nindex 864327c7b..ebed3b518 100644\n--- a/examples/l3fwd/meson.build\n+++ b/examples/l3fwd/meson.build\n@@ -8,5 +8,6 @@\n \n deps += ['hash', 'lpm', 'eventdev']\n sources = files(\n-\t'l3fwd_em.c', 'l3fwd_lpm.c', 'l3fwd_event.c', 'main.c'\n+\t'l3fwd_em.c', 'l3fwd_lpm.c', 'l3fwd_event.c',\n+\t'l3fwd_event_internal_port.c', 'l3fwd_event_generic.c', 'main.c'\n )\n", "prefixes": [ "v6", "02/11" ] }