Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65154/?format=api
{ "id": 65154, "url": "http://patches.dpdk.org/api/patches/65154/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200127154402.4008069-4-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200127154402.4008069-4-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200127154402.4008069-4-thomas@monjalon.net", "date": "2020-01-27T15:44:01", "name": "[v2,3/4] build: allow hiding dependencies from pkg-config", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9fb68bb5698802bc81eccfeb4e157374c4fb8d01", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200127154402.4008069-4-thomas@monjalon.net/mbox/", "series": [ { "id": 8307, "url": "http://patches.dpdk.org/api/series/8307/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8307", "date": "2020-01-27T15:43:58", "name": "add static ibverbs in meson", "version": 2, "mbox": "http://patches.dpdk.org/series/8307/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65154/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65154/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 25980A0531;\n\tMon, 27 Jan 2020 16:44:46 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 723781BFDC;\n\tMon, 27 Jan 2020 16:44:27 +0100 (CET)", "from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com\n [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 664681BFD7\n for <dev@dpdk.org>; Mon, 27 Jan 2020 16:44:25 +0100 (CET)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n by mailout.west.internal (Postfix) with ESMTP id 2144C514;\n Mon, 27 Jan 2020 10:44:24 -0500 (EST)", "from mailfrontend1 ([10.202.2.162])\n by compute1.internal (MEProxy); Mon, 27 Jan 2020 10:44:24 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 1A1643280063;\n Mon, 27 Jan 2020 10:44:23 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=mesmtp; bh=dcqF5qHPCL\n HC7Iy91t1SItYcXZTadmujr+mIlwjo2IM=; b=YTp7dkCLHXjuG4j+BDRvTh7xYY\n CU0KlfFwXj2t9XEo5JpLrWABhZI7hEX4rjjJvfflOdbS0euuEq71dyEHgXORzDt7\n 8lJ3aaImWrutMDfjI0I8tRoMvHPye4Nhu2yIhEruztSukbxRNeG1XwFOU8iPkPX3\n jJNTEo8SSxggM20Os=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm1; bh=dcqF5qHPCLHC7Iy91t1SItYcXZTadmujr+mIlwjo2IM=; b=Jzh71L/K\n 0WfrbWofKFlzVDv+k8Q1Z48d9ZN/HsNAtS35IxM8vWN5b0OpZUH2Qo+/sGGx20bu\n LAuNdh/vJ4do5LIReekGMpv+uWRZ0oPiRwsZ9UxTBRGSTOM5RoSHE2IShr8Ssv65\n gEIgr/0KygXZdHuJe5kc5u81wtWvVdGfiNB0UepH/0AlnMzp/zFsv88z7+aCPbes\n YzPzjkhy4jjaE2aF7tuTt1FZdmL/AM2K6NKjEkYuYrXlkbap56+gi4/q0FQwFM3f\n qWeEjoV0ZY1Un2ozNrkX50u3prOkMyFvL1OgGsgSlRxj6OiLA7a0WfZNJ2t4XobR\n /InrDIBxm7xQLg==" ], "X-ME-Sender": "<xms:VwUvXgqV2eLt9cuzYP623LCwufnKUnMKVR43Ck1O7_WNn7cqNko_cw>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedugedrfedvgdejkecutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs\n ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph\n epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgepvdenucfrrghr\n rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth", "X-ME-Proxy": "<xmx:VwUvXnE4MD_sOSHJR6eZYTGA7UTdvVYMrQJAS_nASNiqOPBGS3x-UA>\n <xmx:VwUvXqrRJxVk8RZ0K0C5lORp4tu69zfDjHrzjiTTzhXzwnKM1yVcaw>\n <xmx:VwUvXl1YQ5MFWOdexlQrCMh0_XxxNRfJkQ0QDotqolMGLYMfUtmY6g>\n <xmx:VwUvXvCh8DBCID6UfqPXKnUVDbIAXFoP_59No6EjN4zdoolGbnYCjQ>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, John McNamara <john.mcnamara@intel.com>,\n Marko Kovacevic <marko.kovacevic@intel.com>", "Date": "Mon, 27 Jan 2020 16:44:01 +0100", "Message-Id": "<20200127154402.4008069-4-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200127154402.4008069-1-thomas@monjalon.net>", "References": "<20200116071656.1663967-1-thomas@monjalon.net>\n <20200127154402.4008069-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 3/4] build: allow hiding dependencies from\n\tpkg-config", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If a dependency is required for a driver build,\nbut should not be exposed to the application (via pkg-config),\nit can be declared in the array hidden_deps.\n\nThe hidden_deps are used as internal dependencies,\nwhen building the shared library and the first stage of static library.\nThe final static library does not include the hidden_deps\nbecause this library object is used to generate the .pc file.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n doc/guides/contributing/coding_style.rst | 6 ++++++\n drivers/meson.build | 9 ++++++---\n 2 files changed, 12 insertions(+), 3 deletions(-)", "diff": "diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst\nindex 841ef6d5c8..c96457273f 100644\n--- a/doc/guides/contributing/coding_style.rst\n+++ b/doc/guides/contributing/coding_style.rst\n@@ -975,6 +975,12 @@ deps\n ext_deps\n \tAs above.\n \n+hidden_deps\n+\t**Default Value = []**.\n+\tUsed to specify external dependencies, same as ``ext_deps``, except\n+\tthe libraries won't be exposed as requirements of the static driver,\n+\tin the section ``Requires.private`` of the generated ``.pc`` file.\n+\n includes\n \t**Default Value = <driver directory>** Some drivers include a base\n \tdirectory for additional source files and headers, so we have this\ndiff --git a/drivers/meson.build b/drivers/meson.build\nindex 29708cc2bb..759263c309 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -56,6 +56,7 @@ foreach class:dpdk_driver_classes\n \t\t# too, so that it can be reflected in the pkgconfig output for\n \t\t# static builds.\n \t\text_deps = []\n+\t\thidden_deps = []\n \t\tpkgconfig_extra_libs = []\n \n \t\t# pull in driver directory which should assign to each of the above\n@@ -71,8 +72,9 @@ foreach class:dpdk_driver_classes\n \t\tendforeach\n \t\tif build\n \t\t\t# get dependency objs from strings\n-\t\t\tshared_deps = ext_deps\n-\t\t\tstatic_deps = ext_deps\n+\t\t\tshared_deps = ext_deps + hidden_deps\n+\t\t\tstatic_deps = ext_deps + hidden_deps\n+\t\t\tstatic_pub_deps = ext_deps\n \t\t\tforeach d:deps\n \t\t\t\tif not is_variable('shared_rte_' + d)\n \t\t\t\t\tbuild = false\n@@ -82,6 +84,7 @@ foreach class:dpdk_driver_classes\n \t\t\t\telse\n \t\t\t\t\tshared_deps += [get_variable('shared_rte_' + d)]\n \t\t\t\t\tstatic_deps += [get_variable('static_rte_' + d)]\n+\t\t\t\t\tstatic_pub_deps += [get_variable('static_rte_' + d)]\n \t\t\t\tendif\n \t\t\tendforeach\n \t\tendif\n@@ -144,7 +147,7 @@ foreach class:dpdk_driver_classes\n \t\t\t\tsources,\n \t\t\t\tobjects: objs,\n \t\t\t\tinclude_directories: includes,\n-\t\t\t\tdependencies: static_deps,\n+\t\t\t\tdependencies: static_pub_deps, # skip hidden_deps\n \t\t\t\tc_args: cflags,\n \t\t\t\tinstall: true)\n \n", "prefixes": [ "v2", "3/4" ] }