Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65046/?format=api
{ "id": 65046, "url": "http://patches.dpdk.org/api/patches/65046/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1579703770-30091-1-git-send-email-matan@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1579703770-30091-1-git-send-email-matan@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1579703770-30091-1-git-send-email-matan@mellanox.com", "date": "2020-01-22T14:36:10", "name": "net/mlx5: fix clang 3.4.2 compilation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1892c40e0c3155915d94fb829cf7fc6c8959adcb", "submitter": { "id": 796, "url": "http://patches.dpdk.org/api/people/796/?format=api", "name": "Matan Azrad", "email": "matan@mellanox.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1579703770-30091-1-git-send-email-matan@mellanox.com/mbox/", "series": [ { "id": 8261, "url": "http://patches.dpdk.org/api/series/8261/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8261", "date": "2020-01-22T14:36:10", "name": "net/mlx5: fix clang 3.4.2 compilation", "version": 1, "mbox": "http://patches.dpdk.org/series/8261/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65046/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/65046/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5E597A0530;\n\tWed, 22 Jan 2020 15:37:16 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1B0873576;\n\tWed, 22 Jan 2020 15:37:15 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id E14B82F4F\n for <dev@dpdk.org>; Wed, 22 Jan 2020 15:37:12 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n asafp@mellanox.com)\n with ESMTPS (AES256-SHA encrypted); 22 Jan 2020 16:37:12 +0200", "from pegasus07.mtr.labs.mlnx (pegasus07.mtr.labs.mlnx\n [10.210.16.112])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 00MEaCu2023415;\n Wed, 22 Jan 2020 16:36:12 +0200" ], "From": "Matan Azrad <matan@mellanox.com>", "To": "Viacheslav Ovsiienko <viacheslavo@mellanox.com>", "Cc": "dev@dpdk.org, stable@dpdk.org", "Date": "Wed, 22 Jan 2020 14:36:10 +0000", "Message-Id": "<1579703770-30091-1-git-send-email-matan@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "Subject": "[dpdk-dev] [PATCH] net/mlx5: fix clang 3.4.2 compilation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Compilation massage example:\n\"dpdk/drivers/net/mlx5/mlx5_flow_dv.c:1087:10: error: comparison of\nunsigned enum expression < 0 is always false\n[-Werror,-Wtautological-compare]\n if (reg < 0)\n ~~~ ^ ~\n\"\n\nenum modify_reg holds only non-negative integers and in some places in\nthe code it was used to be compared with negative value, hence\ncompilation was failed.\n\nChange all thus places to use integer instead of enum modify_reg.\n\nFixes: 3e8edd0ef848 (\"net/mlx5: update metadata register ID query\")\nFixes: 55deee1715f0 (\"net/mlx5: extend flow mark support\")\nCc: stable@dpdk.org\n\nSigned-off-by: Matan Azrad <matan@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow.c | 2 +-\n drivers/net/mlx5/mlx5_flow.h | 2 +-\n drivers/net/mlx5/mlx5_flow_dv.c | 12 ++++++------\n 3 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex 970123b..441ca10 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -341,7 +341,7 @@ struct mlx5_flow_tunnel_info {\n * The request register on success, a negative errno\n * value otherwise and rte_errno is set.\n */\n-enum modify_reg\n+int\n mlx5_flow_get_reg_id(struct rte_eth_dev *dev,\n \t\t enum mlx5_feature_name feature,\n \t\t uint32_t id,\ndiff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h\nindex 9832542..886d770 100644\n--- a/drivers/net/mlx5/mlx5_flow.h\n+++ b/drivers/net/mlx5/mlx5_flow.h\n@@ -762,7 +762,7 @@ uint64_t mlx5_flow_hashfields_adjust(struct mlx5_flow *dev_flow, int tunnel,\n \t\t\t\t uint64_t hash_fields);\n uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n \t\t\t\t uint32_t subpriority);\n-enum modify_reg mlx5_flow_get_reg_id(struct rte_eth_dev *dev,\n+int mlx5_flow_get_reg_id(struct rte_eth_dev *dev,\n \t\t\t\t enum mlx5_feature_name feature,\n \t\t\t\t uint32_t id,\n \t\t\t\t struct rte_flow_error *error);\ndiff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 5a1b426..0464fa8 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -1077,7 +1077,7 @@ struct field_modify_info modify_tcp[] = {\n \t\t{4, 0, 0}, /* dynamic instead of MLX5_MODI_META_REG_C_1. */\n \t\t{0, 0, 0},\n \t};\n-\tenum modify_reg reg;\n+\tint reg;\n \n \tif (!mask)\n \t\treturn rte_flow_error_set(error, EINVAL,\n@@ -1119,7 +1119,7 @@ struct field_modify_info modify_tcp[] = {\n \t\t\t const struct rte_flow_attr *attr,\n \t\t\t struct rte_flow_error *error)\n {\n-\tenum modify_reg reg =\n+\tint reg =\n \t\tmlx5_flow_get_reg_id(dev, attr->transfer ?\n \t\t\t\t\t MLX5_METADATA_FDB :\n \t\t\t\t\t attr->egress ?\n@@ -1167,7 +1167,7 @@ struct field_modify_info modify_tcp[] = {\n \tstruct field_modify_info reg_c_x[] = {\n \t\t[1] = {0, 0, 0},\n \t};\n-\tenum modify_reg reg = flow_dv_get_metadata_reg(dev, attr, error);\n+\tint reg = flow_dv_get_metadata_reg(dev, attr, error);\n \n \tif (reg < 0)\n \t\treturn reg;\n@@ -1370,7 +1370,7 @@ struct field_modify_info modify_tcp[] = {\n \tstruct rte_flow_item_meta nic_mask = {\n \t\t.data = UINT32_MAX\n \t};\n-\tenum modify_reg reg;\n+\tint reg;\n \tint ret;\n \n \tif (!spec)\n@@ -2036,7 +2036,7 @@ struct field_modify_info modify_tcp[] = {\n {\n \tconst struct rte_flow_action_set_meta *conf;\n \tuint32_t nic_mask = UINT32_MAX;\n-\tenum modify_reg reg;\n+\tint reg;\n \n \tif (!mlx5_flow_ext_mreg_supported(dev))\n \t\treturn rte_flow_error_set(error, ENOTSUP,\n@@ -6124,7 +6124,7 @@ struct field_modify_info modify_tcp[] = {\n \t\tmeta_m = &rte_flow_item_meta_mask;\n \tmeta_v = (const void *)item->spec;\n \tif (meta_v) {\n-\t\tenum modify_reg reg;\n+\t\tint reg;\n \t\tuint32_t value = meta_v->data;\n \t\tuint32_t mask = meta_m->data;\n \n", "prefixes": [] }