Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65045/?format=api
{ "id": 65045, "url": "http://patches.dpdk.org/api/patches/65045/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/6d40b36e3eb4dea2d044299bbc4de87dcc613bdb.1579703134.git.dekelp@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<6d40b36e3eb4dea2d044299bbc4de87dcc613bdb.1579703134.git.dekelp@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/6d40b36e3eb4dea2d044299bbc4de87dcc613bdb.1579703134.git.dekelp@mellanox.com", "date": "2020-01-22T14:27:22", "name": "[10/11] net/mlx5: update description of validation funcs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "992d38386ab09ce96b6d67f0be413656caca1737", "submitter": { "id": 1082, "url": "http://patches.dpdk.org/api/people/1082/?format=api", "name": "Dekel Peled", "email": "dekelp@mellanox.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/6d40b36e3eb4dea2d044299bbc4de87dcc613bdb.1579703134.git.dekelp@mellanox.com/mbox/", "series": [ { "id": 8260, "url": "http://patches.dpdk.org/api/series/8260/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8260", "date": "2020-01-22T14:27:13", "name": "net/mlx5: vlan actions validation fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/8260/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65045/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/65045/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 72F81A0530;\n\tWed, 22 Jan 2020 15:31:55 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 23BBA1BF87;\n\tWed, 22 Jan 2020 15:30:22 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 5D4BC4C81\n for <dev@dpdk.org>; Wed, 22 Jan 2020 15:30:08 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n dekelp@mellanox.com)\n with ESMTPS (AES256-SHA encrypted); 22 Jan 2020 16:30:06 +0200", "from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx\n [10.128.130.87])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 00METnL8010555;\n Wed, 22 Jan 2020 16:30:02 +0200" ], "From": "Dekel Peled <dekelp@mellanox.com>", "To": "matan@mellanox.com, viacheslavo@mellanox.com", "Cc": "rasland@mellanox.com, orika@mellanox.com, dev@dpdk.org", "Date": "Wed, 22 Jan 2020 16:27:22 +0200", "Message-Id": "\n <6d40b36e3eb4dea2d044299bbc4de87dcc613bdb.1579703134.git.dekelp@mellanox.com>", "X-Mailer": "git-send-email 1.7.1", "In-Reply-To": "<cover.1579703134.git.dekelp@mellanox.com>", "References": "<cover.1579703134.git.dekelp@mellanox.com>", "Subject": "[dpdk-dev] [PATCH 10/11] net/mlx5: update description of validation\n\tfuncs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Description of several functions is not accurate.\nThis patch updates the description, parameter names etc.\n\nSigned-off-by: Dekel Peled <dekelp@mellanox.com>\nAcked-by: Ori Kam <orika@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow_dv.c | 28 ++++++++++++----------------\n 1 file changed, 12 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 4b6a92c..059d03f 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -1662,14 +1662,10 @@ struct field_modify_info modify_tcp[] = {\n /**\n * Get VLAN default info from vlan match info.\n *\n- * @param[in] dev\n- * Pointer to the rte_eth_dev structure.\n- * @param[in] item\n+ * @param[in] items\n * the list of item specifications.\n * @param[out] vlan\n * pointer VLAN info to fill to.\n- * @param[out] error\n- * Pointer to error structure.\n *\n * @return\n * 0 on success, a negative errno value otherwise and rte_errno is set.\n@@ -1721,8 +1717,10 @@ struct field_modify_info modify_tcp[] = {\n *\n * @param[in] action_flags\n * Holds the actions detected until now.\n+ * @param[in] item_flags\n+ * The items found in this flow rule.\n * @param[in] action\n- * Pointer to the encap action.\n+ * Pointer to the action structure.\n * @param[in] attr\n * Pointer to flow attributes\n * @param[out] error\n@@ -1772,8 +1770,6 @@ struct field_modify_info modify_tcp[] = {\n * Holds the actions detected until now.\n * @param[in] actions\n * Pointer to the list of actions remaining in the flow rule.\n- * @param[in] attr\n- * Pointer to flow attributes\n * @param[out] error\n * Pointer to error structure.\n *\n@@ -1988,7 +1984,7 @@ struct field_modify_info modify_tcp[] = {\n * @param[in] dev\n * Pointer to the rte_eth_dev structure.\n * @param[in] action\n- * Pointer to the encap action.\n+ * Pointer to the action structure.\n * @param[in] action_flags\n * Holds the actions detected until now.\n * @param[in] attr\n@@ -2049,7 +2045,7 @@ struct field_modify_info modify_tcp[] = {\n * @param[in] dev\n * Pointer to the rte_eth_dev structure.\n * @param[in] action\n- * Pointer to the encap action.\n+ * Pointer to the action structure.\n * @param[in] action_flags\n * Holds the actions detected until now.\n * @param[in] attr\n@@ -2103,7 +2099,7 @@ struct field_modify_info modify_tcp[] = {\n * Validate count action.\n *\n * @param[in] dev\n- * device otr.\n+ * Pointer to rte_eth_dev structure.\n * @param[out] error\n * Pointer to error structure.\n *\n@@ -2135,7 +2131,7 @@ struct field_modify_info modify_tcp[] = {\n * @param[in] action_flags\n * Holds the actions detected until now.\n * @param[in] action\n- * Pointer to the encap action.\n+ * Pointer to the action structure.\n * @param[in] attr\n * Pointer to flow attributes\n * @param[out] error\n@@ -2995,12 +2991,12 @@ struct field_modify_info modify_tcp[] = {\n *\n * @param[in] dev\n * Pointer to rte_eth_dev structure.\n- * @param[in] vlan_tag\n- * the vlan tag to push to the Ethernet header.\n- * @param[in, out] dev_flow\n- * Pointer to the mlx5_flow.\n * @param[in] attr\n * Pointer to the flow attributes.\n+ * @param[in] vlan\n+ * Pointer to the vlan to push to the Ethernet header.\n+ * @param[in, out] dev_flow\n+ * Pointer to the mlx5_flow.\n * @param[out] error\n * Pointer to the error structure.\n *\n", "prefixes": [ "10/11" ] }