Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/65009/?format=api
{ "id": 65009, "url": "http://patches.dpdk.org/api/patches/65009/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200121114433.57543-3-huwei013@chinasoftinc.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200121114433.57543-3-huwei013@chinasoftinc.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200121114433.57543-3-huwei013@chinasoftinc.com", "date": "2020-01-21T11:44:32", "name": "[2/3] app/testpmd: fix the initial value when setting PFC", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "99f67e4274319fcfe34ae6bc486e22ba812d12c4", "submitter": { "id": 1537, "url": "http://patches.dpdk.org/api/people/1537/?format=api", "name": "Wei Hu (Xavier)", "email": "huwei013@chinasoftinc.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200121114433.57543-3-huwei013@chinasoftinc.com/mbox/", "series": [ { "id": 8241, "url": "http://patches.dpdk.org/api/series/8241/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8241", "date": "2020-01-21T11:44:30", "name": "app/testpmd: fixes for testpmd application", "version": 1, "mbox": "http://patches.dpdk.org/series/8241/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/65009/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/65009/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1915AA04DD;\n\tTue, 21 Jan 2020 12:45:17 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2B0EB1B203;\n\tTue, 21 Jan 2020 12:44:56 +0100 (CET)", "from incedge.chinasoftinc.com (unknown [114.113.233.8])\n by dpdk.org (Postfix) with ESMTP id 627F53977\n for <dev@dpdk.org>; Tue, 21 Jan 2020 12:44:51 +0100 (CET)", "from mail.chinasoftinc.com (inccas002.ito.icss [10.168.0.52]) by\n incedge.chinasoftinc.com with ESMTP id YHyirkPJ8IZGCkKD (version=TLSv1\n cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO) for <dev@dpdk.org>;\n Tue, 21 Jan 2020 19:44:43 +0800 (CST)", "from localhost.localdomain (114.119.4.74) by INCCAS002.ito.icss\n (10.168.0.60) with Microsoft SMTP Server id 14.3.439.0; Tue, 21 Jan 2020\n 19:44:40 +0800" ], "X-ASG-Debug-ID": "1579607080-0a3dd173f383950003-TfluYd", "X-Barracuda-Envelope-From": "huwei013@chinasoftinc.com", "X-Barracuda-RBL-Trusted-Forwarder": [ "10.168.0.52", "10.168.0.60" ], "X-ASG-Whitelist": "Client", "From": "\"Wei Hu (Xavier)\" <huwei013@chinasoftinc.com>", "To": "<dev@dpdk.org>", "Date": "Tue, 21 Jan 2020 19:44:32 +0800", "X-ASG-Orig-Subj": "[PATCH 2/3] app/testpmd: fix the initial value when setting\n PFC", "Message-ID": "<20200121114433.57543-3-huwei013@chinasoftinc.com>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20200121114433.57543-1-huwei013@chinasoftinc.com>", "References": "<20200121114433.57543-1-huwei013@chinasoftinc.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[114.119.4.74]", "X-Barracuda-Connect": "inccas002.ito.icss[10.168.0.52]", "X-Barracuda-Start-Time": "1579607081", "X-Barracuda-Encrypted": "ECDHE-RSA-AES256-SHA", "X-Barracuda-URL": "https://spam.chinasoftinc.com:443/cgi-mod/mark.cgi", "X-Virus-Scanned": "by bsmtpd at chinasoftinc.com", "X-Barracuda-Scan-Msg-Size": "2403", "Subject": "[dpdk-dev] [PATCH 2/3] app/testpmd: fix the initial value when\n\tsetting PFC", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: \"Wei Hu (Xavier)\" <xavier.huwei@huawei.com>\n\nCurrently, the initial values of the local structure variable named\nrx_tx_onoff_2_lfc_mode and rx_tx_onoff_2_pfc_mode are different in the\nsimilar part of these two following functions:\n\tcmd_link_flow_ctrl_set_parsed\n\tcmd_priority_flow_ctrl_set_parsed\n1) The code snippset in cmd_link_flow_ctrl_set_parsed function:\n\tstatic enum rte_eth_fc_mode rx_tx_onoff_2_lfc_mode[2][2] = {\n\t {RTE_FC_NONE, RTE_FC_TX_PAUSE}, {RTE_FC_RX_PAUSE, RTE_FC_FULL}\n\t};\n\n\tif (!cmd || cmd == &cmd_link_flow_control_set_rx)\n\t\trx_fc_en = (!strcmp(res->rx_lfc_mode, \"on\")) ? 1 : 0;\n\tif (!cmd || cmd == &cmd_link_flow_control_set_tx)\n\t\ttx_fc_en = (!strcmp(res->tx_lfc_mode, \"on\")) ? 1 : 0;\n\n\tfc_conf.mode = rx_tx_onoff_2_lfc_mode[rx_fc_en][tx_fc_en];\n\t<...>\n\tret = rte_eth_dev_flow_ctrl_set(res->port_id, &fc_conf);\n\t<...>\n2) The code snippset in cmd_priority_flow_ctrl_set_parsed function:\n\tstatic enum rte_eth_fc_mode rx_tx_onoff_2_pfc_mode[2][2] = {\n\t {RTE_FC_NONE, RTE_FC_RX_PAUSE}, {RTE_FC_TX_PAUSE, RTE_FC_FULL}\n\t};\n\n\trx_fc_enable = (!strncmp(res->rx_pfc_mode, \"on\",2)) ? 1 : 0;\n\ttx_fc_enable = (!strncmp(res->tx_pfc_mode, \"on\",2)) ? 1 : 0;\n\tpfc_conf.fc.mode =\n\t\t rx_tx_onoff_2_pfc_mode[rx_fc_enable][tx_fc_enable];\n\t<...>\n\tret = rte_eth_dev_priority_flow_ctrl_set(res->port_id, &pfc_conf);\n\t<...>\nThe initial value of rx_tx_onoff_2_pfc_mode is wrong, it should be the\nsame as rx_tx_onoff_2_lfc_mode.\n\nFixes: 9b53e542e9e1 (\"app/testpmd: add priority flow control\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>\nSigned-off-by: Xuan Li <lixuan47@hisilicon.com>\n---\n app/test-pmd/cmdline.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex dab22bc4d..a09cb87e1 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -7087,7 +7087,7 @@ cmd_priority_flow_ctrl_set_parsed(void *parsed_result,\n \t * the RTE_FC_RX_PAUSE, Respond to the pause frame at the Tx side.\n \t */\n \tstatic enum rte_eth_fc_mode rx_tx_onoff_2_pfc_mode[2][2] = {\n-\t\t\t{RTE_FC_NONE, RTE_FC_RX_PAUSE}, {RTE_FC_TX_PAUSE, RTE_FC_FULL}\n+\t\t{RTE_FC_NONE, RTE_FC_TX_PAUSE}, {RTE_FC_RX_PAUSE, RTE_FC_FULL}\n \t};\n \n \trx_fc_enable = (!strncmp(res->rx_pfc_mode, \"on\",2)) ? 1 : 0;\n", "prefixes": [ "2/3" ] }