Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 64962,
    "url": "http://patches.dpdk.org/api/patches/64962/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1579539790-3882-27-git-send-email-matan@mellanox.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1579539790-3882-27-git-send-email-matan@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1579539790-3882-27-git-send-email-matan@mellanox.com",
    "date": "2020-01-20T17:02:58",
    "name": "[v1,26/38] common/mlx5: add DevX command to modify RQT",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "b1ddb0aa6502cae4031d37adbb51b2111c5187ba",
    "submitter": {
        "id": 796,
        "url": "http://patches.dpdk.org/api/people/796/?format=api",
        "name": "Matan Azrad",
        "email": "matan@mellanox.com"
    },
    "delegate": {
        "id": 2642,
        "url": "http://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1579539790-3882-27-git-send-email-matan@mellanox.com/mbox/",
    "series": [
        {
            "id": 8223,
            "url": "http://patches.dpdk.org/api/series/8223/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8223",
            "date": "2020-01-20T17:02:37",
            "name": "Introduce mlx5 vDPA driver",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/8223/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/64962/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/64962/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4673BA0526;\n\tMon, 20 Jan 2020 18:07:48 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D58D61C069;\n\tMon, 20 Jan 2020 18:04:01 +0100 (CET)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id A172A1BFAB\n for <dev@dpdk.org>; Mon, 20 Jan 2020 18:03:14 +0100 (CET)",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n asafp@mellanox.com)\n with ESMTPS (AES256-SHA encrypted); 20 Jan 2020 19:03:13 +0200",
            "from pegasus07.mtr.labs.mlnx (pegasus07.mtr.labs.mlnx\n [10.210.16.112])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 00KH3BGj024424;\n Mon, 20 Jan 2020 19:03:13 +0200"
        ],
        "From": "Matan Azrad <matan@mellanox.com>",
        "To": "dev@dpdk.org",
        "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n Thomas Monjalon <thomas@monjalon.net>",
        "Date": "Mon, 20 Jan 2020 17:02:58 +0000",
        "Message-Id": "<1579539790-3882-27-git-send-email-matan@mellanox.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1579539790-3882-1-git-send-email-matan@mellanox.com>",
        "References": "<1579539790-3882-1-git-send-email-matan@mellanox.com>",
        "Subject": "[dpdk-dev] [PATCH v1 26/38] common/mlx5: add DevX command to modify\n\tRQT",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "RQ table can be changed to support different list of queues.\n\nAdd DevX command to modify DevX RQT object to point on new RQ list.\n\nSigned-off-by: Matan Azrad <matan@mellanox.com>\n---\n drivers/common/mlx5/mlx5_devx_cmds.c            | 47 +++++++++++++++++++++++++\n drivers/common/mlx5/mlx5_devx_cmds.h            |  2 ++\n drivers/common/mlx5/mlx5_prm.h                  | 21 +++++++++++\n drivers/common/mlx5/rte_common_mlx5_version.map |  1 +\n 4 files changed, 71 insertions(+)",
    "diff": "diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c\nindex 3b0d7bd..badd51e 100644\n--- a/drivers/common/mlx5/mlx5_devx_cmds.c\n+++ b/drivers/common/mlx5/mlx5_devx_cmds.c\n@@ -862,6 +862,53 @@ struct mlx5_devx_obj *\n }\n \n /**\n+ * Modify RQT using DevX API.\n+ *\n+ * @param[in] rqt\n+ *   Pointer to RQT DevX object structure.\n+ * @param [in] rqt_attr\n+ *   Pointer to RQT attributes structure.\n+ *\n+ * @return\n+ *   0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+int\n+mlx5_devx_cmd_modify_rqt(struct mlx5_devx_obj *rqt,\n+\t\t\t struct mlx5_devx_rqt_attr *rqt_attr)\n+{\n+\tuint32_t inlen = MLX5_ST_SZ_BYTES(modify_rqt_in) +\n+\t\t\t rqt_attr->rqt_actual_size * sizeof(uint32_t);\n+\tuint32_t out[MLX5_ST_SZ_DW(modify_rqt_out)] = {0};\n+\tuint32_t *in = rte_calloc(__func__, 1, inlen, 0);\n+\tvoid *rqt_ctx;\n+\tint i;\n+\tint ret;\n+\n+\tif (!in) {\n+\t\tDRV_LOG(ERR, \"Failed to allocate RQT modify IN data.\");\n+\t\trte_errno = ENOMEM;\n+\t\treturn -ENOMEM;\n+\t}\n+\tMLX5_SET(modify_rqt_in, in, opcode, MLX5_CMD_OP_MODIFY_RQT);\n+\tMLX5_SET(modify_rqt_in, in, rqtn, rqt->id);\n+\tMLX5_SET64(modify_rqt_in, in, modify_bitmask, 0x1);\n+\trqt_ctx = MLX5_ADDR_OF(modify_rqt_in, in, rqt_context);\n+\tMLX5_SET(rqtc, rqt_ctx, list_q_type, rqt_attr->rq_type);\n+\tMLX5_SET(rqtc, rqt_ctx, rqt_max_size, rqt_attr->rqt_max_size);\n+\tMLX5_SET(rqtc, rqt_ctx, rqt_actual_size, rqt_attr->rqt_actual_size);\n+\tfor (i = 0; i < rqt_attr->rqt_actual_size; i++)\n+\t\tMLX5_SET(rqtc, rqt_ctx, rq_num[i], rqt_attr->rq_list[i]);\n+\tret = mlx5_glue->devx_obj_modify(rqt->obj, in, inlen, out, sizeof(out));\n+\trte_free(in);\n+\tif (ret) {\n+\t\tDRV_LOG(ERR, \"Failed to modify RQT using DevX.\");\n+\t\trte_errno = errno;\n+\t\treturn -rte_errno;\n+\t}\n+\treturn ret;\n+}\n+\n+/**\n  * Create SQ using DevX API.\n  *\n  * @param[in] ctx\ndiff --git a/drivers/common/mlx5/mlx5_devx_cmds.h b/drivers/common/mlx5/mlx5_devx_cmds.h\nindex 065b02a..1f635bb 100644\n--- a/drivers/common/mlx5/mlx5_devx_cmds.h\n+++ b/drivers/common/mlx5/mlx5_devx_cmds.h\n@@ -315,5 +315,7 @@ int mlx5_devx_cmd_modify_virtq(struct mlx5_devx_obj *virtq_obj,\n \t\t\t       struct mlx5_devx_virtq_attr *attr);\n int mlx5_devx_cmd_query_virtq(struct mlx5_devx_obj *virtq_obj,\n \t\t\t      struct mlx5_devx_virtq_attr *attr);\n+int mlx5_devx_cmd_modify_rqt(struct mlx5_devx_obj *rqt,\n+\t\t\t     struct mlx5_devx_rqt_attr *rqt_attr);\n \n #endif /* RTE_PMD_MLX5_DEVX_CMDS_H_ */\ndiff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h\nindex f45383d..8984b8c 100644\n--- a/drivers/common/mlx5/mlx5_prm.h\n+++ b/drivers/common/mlx5/mlx5_prm.h\n@@ -738,6 +738,7 @@ enum {\n \tMLX5_CMD_OP_CREATE_TIS = 0x912,\n \tMLX5_CMD_OP_QUERY_TIS = 0x915,\n \tMLX5_CMD_OP_CREATE_RQT = 0x916,\n+\tMLX5_CMD_OP_MODIFY_RQT = 0x917,\n \tMLX5_CMD_OP_ALLOC_FLOW_COUNTER = 0x939,\n \tMLX5_CMD_OP_QUERY_FLOW_COUNTER = 0x93b,\n \tMLX5_CMD_OP_CREATE_GENERAL_OBJECT = 0xa00,\n@@ -1760,10 +1761,30 @@ struct mlx5_ifc_create_rqt_in_bits {\n \tu8 reserved_at_40[0xc0];\n \tstruct mlx5_ifc_rqtc_bits rqt_context;\n };\n+\n+struct mlx5_ifc_modify_rqt_in_bits {\n+\tu8 opcode[0x10];\n+\tu8 uid[0x10];\n+\tu8 reserved_at_20[0x10];\n+\tu8 op_mod[0x10];\n+\tu8 reserved_at_40[0x8];\n+\tu8 rqtn[0x18];\n+\tu8 reserved_at_60[0x20];\n+\tu8 modify_bitmask[0x40];\n+\tu8 reserved_at_c0[0x40];\n+\tstruct mlx5_ifc_rqtc_bits rqt_context;\n+};\n #ifdef PEDANTIC\n #pragma GCC diagnostic error \"-Wpedantic\"\n #endif\n \n+struct mlx5_ifc_modify_rqt_out_bits {\n+\tu8 status[0x8];\n+\tu8 reserved_at_8[0x18];\n+\tu8 syndrome[0x20];\n+\tu8 reserved_at_40[0x40];\n+};\n+\n enum {\n \tMLX5_SQC_STATE_RST  = 0x0,\n \tMLX5_SQC_STATE_RDY  = 0x1,\ndiff --git a/drivers/common/mlx5/rte_common_mlx5_version.map b/drivers/common/mlx5/rte_common_mlx5_version.map\nindex f3082ce..37a6902 100644\n--- a/drivers/common/mlx5/rte_common_mlx5_version.map\n+++ b/drivers/common/mlx5/rte_common_mlx5_version.map\n@@ -15,6 +15,7 @@ DPDK_20.02 {\n \tmlx5_devx_cmd_flow_dump;\n \tmlx5_devx_cmd_mkey_create;\n \tmlx5_devx_cmd_modify_rq;\n+\tmlx5_devx_cmd_modify_rqt;\n \tmlx5_devx_cmd_modify_sq;\n \tmlx5_devx_cmd_modify_virtq;\n \tmlx5_devx_cmd_qp_query_tis_td;\n",
    "prefixes": [
        "v1",
        "26/38"
    ]
}