Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 64936,
    "url": "http://patches.dpdk.org/api/patches/64936/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200121030657.39048-3-xiao.w.wang@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200121030657.39048-3-xiao.w.wang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200121030657.39048-3-xiao.w.wang@intel.com",
    "date": "2020-01-21T03:06:57",
    "name": "[2/2] l3fwd-power: fix interrupt disable",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "8dc851c39bb9d06a1bd89f29bffb96ac0d43f66e",
    "submitter": {
        "id": 281,
        "url": "http://patches.dpdk.org/api/people/281/?format=api",
        "name": "Xiao Wang",
        "email": "xiao.w.wang@intel.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200121030657.39048-3-xiao.w.wang@intel.com/mbox/",
    "series": [
        {
            "id": 8221,
            "url": "http://patches.dpdk.org/api/series/8221/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8221",
            "date": "2020-01-21T03:06:55",
            "name": "l3fwd-power fixes",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/8221/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/64936/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/64936/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E2E91A0527;\n\tMon, 20 Jan 2020 16:12:59 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7B9BE1BEA9;\n\tMon, 20 Jan 2020 16:12:45 +0100 (CET)",
            "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by dpdk.org (Postfix) with ESMTP id 958524C7A;\n Mon, 20 Jan 2020 16:12:41 +0100 (CET)",
            "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 20 Jan 2020 07:12:40 -0800",
            "from dpdk-xiao1.sh.intel.com ([10.67.110.150])\n by orsmga008.jf.intel.com with ESMTP; 20 Jan 2020 07:12:39 -0800"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.70,342,1574150400\"; d=\"scan'208\";a=\"219674115\"",
        "From": "Xiao Wang <xiao.w.wang@intel.com>",
        "To": "david.hunt@intel.com",
        "Cc": "dev@dpdk.org,\n\tXiao Wang <xiao.w.wang@intel.com>,\n\tstable@dpdk.org",
        "Date": "Mon, 20 Jan 2020 22:06:57 -0500",
        "Message-Id": "<20200121030657.39048-3-xiao.w.wang@intel.com>",
        "X-Mailer": "git-send-email 2.15.1",
        "In-Reply-To": "<20200121030657.39048-1-xiao.w.wang@intel.com>",
        "References": "<20200121030657.39048-1-xiao.w.wang@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 2/2] l3fwd-power: fix interrupt disable",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Since all related queues' interrupts are turned on before epoll, we need\nto turn off all the interrupts after wakeup. This patch fixes the issue\nof only turning off the interrupted queues.\n\nFixes: b736d64787fc (\"examples/l3fwd-power: disable Rx interrupt when waking up\")\nCc: stable@dpdk.org\n\nSigned-off-by: Xiao Wang <xiao.w.wang@intel.com>\n---\n examples/l3fwd-power/main.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)",
    "diff": "diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c\nindex ffcc7ecf4..e9b2cb5b3 100644\n--- a/examples/l3fwd-power/main.c\n+++ b/examples/l3fwd-power/main.c\n@@ -880,9 +880,6 @@ sleep_until_rx_interrupt(int num)\n \t\tport_id = ((uintptr_t)data) >> CHAR_BIT;\n \t\tqueue_id = ((uintptr_t)data) &\n \t\t\tRTE_LEN2MASK(CHAR_BIT, uint8_t);\n-\t\trte_spinlock_lock(&(locks[port_id]));\n-\t\trte_eth_dev_rx_intr_disable(port_id, queue_id);\n-\t\trte_spinlock_unlock(&(locks[port_id]));\n \t\tRTE_LOG(INFO, L3FWD_POWER,\n \t\t\t\"lcore %u is waked up from rx interrupt on\"\n \t\t\t\" port %d queue %d\\n\",\n@@ -892,7 +889,7 @@ sleep_until_rx_interrupt(int num)\n \treturn 0;\n }\n \n-static void turn_on_intr(struct lcore_conf *qconf)\n+static void turn_on_off_intr(struct lcore_conf *qconf, bool on)\n {\n \tint i;\n \tstruct lcore_rx_queue *rx_queue;\n@@ -905,7 +902,10 @@ static void turn_on_intr(struct lcore_conf *qconf)\n \t\tqueue_id = rx_queue->queue_id;\n \n \t\trte_spinlock_lock(&(locks[port_id]));\n-\t\trte_eth_dev_rx_intr_enable(port_id, queue_id);\n+\t\tif (on)\n+\t\t\trte_eth_dev_rx_intr_enable(port_id, queue_id);\n+\t\telse\n+\t\t\trte_eth_dev_rx_intr_disable(port_id, queue_id);\n \t\trte_spinlock_unlock(&(locks[port_id]));\n \t}\n }\n@@ -1340,9 +1340,10 @@ main_loop(__attribute__((unused)) void *dummy)\n \t\t\telse {\n \t\t\t\t/* suspend until rx interrupt triggers */\n \t\t\t\tif (intr_en) {\n-\t\t\t\t\tturn_on_intr(qconf);\n+\t\t\t\t\tturn_on_off_intr(qconf, 1);\n \t\t\t\t\tsleep_until_rx_interrupt(\n \t\t\t\t\t\tqconf->n_rx_queue);\n+\t\t\t\t\tturn_on_off_intr(qconf, 0);\n \t\t\t\t\t/**\n \t\t\t\t\t * start receiving packets immediately\n \t\t\t\t\t */\n",
    "prefixes": [
        "2/2"
    ]
}