Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 64905,
    "url": "http://patches.dpdk.org/api/patches/64905/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1579508878-17216-1-git-send-email-wangyunjian@huawei.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1579508878-17216-1-git-send-email-wangyunjian@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1579508878-17216-1-git-send-email-wangyunjian@huawei.com",
    "date": "2020-01-20T08:27:58",
    "name": "tap: fix memory leak when unregister intr handler",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "ce9bfac8169256e66814741506538de857a895fb",
    "submitter": {
        "id": 551,
        "url": "http://patches.dpdk.org/api/people/551/?format=api",
        "name": "Yunjian Wang",
        "email": "wangyunjian@huawei.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1579508878-17216-1-git-send-email-wangyunjian@huawei.com/mbox/",
    "series": [
        {
            "id": 8211,
            "url": "http://patches.dpdk.org/api/series/8211/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8211",
            "date": "2020-01-20T08:27:58",
            "name": "tap: fix memory leak when unregister intr handler",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/8211/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/64905/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/64905/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BB75AA0521;\n\tMon, 20 Jan 2020 09:28:13 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0944E2BF5;\n\tMon, 20 Jan 2020 09:28:13 +0100 (CET)",
            "from huawei.com (szxga07-in.huawei.com [45.249.212.35])\n by dpdk.org (Postfix) with ESMTP id E816A2BF1;\n Mon, 20 Jan 2020 09:28:10 +0100 (CET)",
            "from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58])\n by Forcepoint Email with ESMTP id 41FECFC915A8CC09A3ED;\n Mon, 20 Jan 2020 16:28:09 +0800 (CST)",
            "from localhost (10.133.209.164) by DGGEMS406-HUB.china.huawei.com\n (10.3.19.206) with Microsoft SMTP Server id 14.3.439.0; Mon, 20 Jan 2020\n 16:28:00 +0800"
        ],
        "From": "Yunjian Wang <wangyunjian@huawei.com>",
        "To": "<dev@dpdk.org>, <keith.wiles@intel.com>",
        "CC": "<xudingke@huawei.com>, Yunjian Wang <wangyunjian@huawei.com>,\n <stable@dpdk.org>",
        "Date": "Mon, 20 Jan 2020 16:27:58 +0800",
        "Message-ID": "<1579508878-17216-1-git-send-email-wangyunjian@huawei.com>",
        "X-Mailer": "git-send-email 1.9.5.msysgit.1",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.133.209.164]",
        "X-CFilter-Loop": "Reflected",
        "Subject": "[dpdk-dev] [PATCH] tap: fix memory leak when unregister intr handler",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The return check of function tap_lsc_intr_handle_set() is wrong, it should\nbe 0 or a positive number if success. So the intr_handle->intr_vec was not\nbeen freed when tap_lsc_intr_handle_set() returned a positive number.\n\nFixes: 4870a8cdd968 (\"net/tap: support Rx interrupt\")\nCc: stable@dpdk.org\n\nSigned-off-by: Yunjian Wang <wangyunjian@huawei.com>\n---\n drivers/net/tap/rte_eth_tap.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex a13d8d50d..079310fea 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -1591,8 +1591,10 @@ tap_intr_handle_set(struct rte_eth_dev *dev, int set)\n \tint err;\n \n \terr = tap_lsc_intr_handle_set(dev, set);\n-\tif (err)\n+\tif (err < 0) {\n+\t\ttap_rx_intr_vec_set(dev, 0);\n \t\treturn err;\n+\t}\n \terr = tap_rx_intr_vec_set(dev, set);\n \tif (err && set)\n \t\ttap_lsc_intr_handle_set(dev, 0);\n",
    "prefixes": []
}