Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 64882,
    "url": "http://patches.dpdk.org/api/patches/64882/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200119074004.213861-4-ruifeng.wang@arm.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200119074004.213861-4-ruifeng.wang@arm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200119074004.213861-4-ruifeng.wang@arm.com",
    "date": "2020-01-19T07:40:04",
    "name": "[v2,3/3] crypto/armv8: fix clang build",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "fdb5d5d487e36cac0f4021524f85c4eda20a9742",
    "submitter": {
        "id": 1198,
        "url": "http://patches.dpdk.org/api/people/1198/?format=api",
        "name": "Ruifeng Wang",
        "email": "ruifeng.wang@arm.com"
    },
    "delegate": {
        "id": 6690,
        "url": "http://patches.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200119074004.213861-4-ruifeng.wang@arm.com/mbox/",
    "series": [
        {
            "id": 8205,
            "url": "http://patches.dpdk.org/api/series/8205/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8205",
            "date": "2020-01-19T07:40:01",
            "name": "armv8 crypto PMD update",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/8205/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/64882/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/64882/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 49A46A04DD;\n\tSun, 19 Jan 2020 08:41:01 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2A5C82F4F;\n\tSun, 19 Jan 2020 08:40:50 +0100 (CET)",
            "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 73CF52C28;\n Sun, 19 Jan 2020 08:40:48 +0100 (CET)",
            "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 014131FB;\n Sat, 18 Jan 2020 23:40:48 -0800 (PST)",
            "from net-arm-thunderx2-02.shanghai.arm.com\n (net-arm-thunderx2-02.shanghai.arm.com [10.169.40.171])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 41A353F68E;\n Sat, 18 Jan 2020 23:44:18 -0800 (PST)"
        ],
        "From": "Ruifeng Wang <ruifeng.wang@arm.com>",
        "To": "akhil.goyal@nxp.com,\n\tgavin.hu@arm.com",
        "Cc": "dev@dpdk.org, jerinj@marvell.com, honnappa.nagarahalli@arm.com,\n nd@arm.com,\n Ruifeng Wang <ruifeng.wang@arm.com>, stable@dpdk.org",
        "Date": "Sun, 19 Jan 2020 15:40:04 +0800",
        "Message-Id": "<20200119074004.213861-4-ruifeng.wang@arm.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20200119074004.213861-1-ruifeng.wang@arm.com>",
        "References": "<20191210082814.1509-1-ruifeng.wang@arm.com>\n <20200119074004.213861-1-ruifeng.wang@arm.com>",
        "Subject": "[dpdk-dev] [PATCH v2 3/3] crypto/armv8: fix clang build",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "1. Clang requires braces around initialization of subobject.\n2. Clang complains implicit conversion of enumeration type.\n\nTrapped issue with Clang version 8.0 and CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO\nwas set.\nError messages:\nrte_armv8_pmd.c:144:2: error: suggest braces around initialization of\n subobject [-Werror,-Wmissing-braces]\n        NULL\n        ^~~~\n        {   }\n/usr/lib/llvm-8/lib/clang/8.0.0/include/stddef.h:105:16: note: expanded\n from macro 'NULL'\n               ^~~~~~~~~~\nrte_armv8_pmd.c:429:21: error: implicit conversion from enumeration\n type 'enum rte_crypto_cipher_operation' to different enumeration type\n      'enum armv8_crypto_cipher_operation' [-Werror,-Wenum-conversion]\n        cop = sess->cipher.direction;\n            ~ ~~~~~~~~~~~~~^~~~~~~~~\n\nFixes: 169ca3db550c (\"crypto/armv8: add PMD optimized for ARMv8 processors\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ruifeng Wang <ruifeng.wang@arm.com>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nReviewed-by: Gavin Hu <gavin.hu@arm.com>\n---\n drivers/crypto/armv8/rte_armv8_pmd.c | 15 ++++++++++++---\n 1 file changed, 12 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/drivers/crypto/armv8/rte_armv8_pmd.c b/drivers/crypto/armv8/rte_armv8_pmd.c\nindex fd8140896..d2b7ab5e0 100644\n--- a/drivers/crypto/armv8/rte_armv8_pmd.c\n+++ b/drivers/crypto/armv8/rte_armv8_pmd.c\n@@ -86,12 +86,12 @@ crypto_op_ca_encrypt = {\n \n static const crypto_func_tbl_t\n crypto_op_ca_decrypt = {\n-\tNULL\n+\t{ {NULL} }\n };\n \n static const crypto_func_tbl_t\n crypto_op_ac_encrypt = {\n-\tNULL\n+\t{ {NULL} }\n };\n \n static const crypto_func_tbl_t\n@@ -377,7 +377,16 @@ armv8_crypto_set_session_chained_parameters(struct armv8_crypto_session *sess,\n \t/* Select cipher key */\n \tsess->cipher.key.length = cipher_xform->cipher.key.length;\n \t/* Set cipher direction */\n-\tcop = sess->cipher.direction;\n+\tswitch (sess->cipher.direction) {\n+\tcase RTE_CRYPTO_CIPHER_OP_ENCRYPT:\n+\t\tcop = ARMV8_CRYPTO_CIPHER_OP_ENCRYPT;\n+\t\tbreak;\n+\tcase RTE_CRYPTO_CIPHER_OP_DECRYPT:\n+\t\tcop = ARMV8_CRYPTO_CIPHER_OP_DECRYPT;\n+\t\tbreak;\n+\tdefault:\n+\t\treturn -ENOTSUP;\n+\t}\n \t/* Set cipher algorithm */\n \tcalg = cipher_xform->cipher.algo;\n \n",
    "prefixes": [
        "v2",
        "3/3"
    ]
}