Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64871/?format=api
{ "id": 64871, "url": "http://patches.dpdk.org/api/patches/64871/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1579344553-11428-16-git-send-email-anoobj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1579344553-11428-16-git-send-email-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1579344553-11428-16-git-send-email-anoobj@marvell.com", "date": "2020-01-18T10:49:13", "name": "[v2,15/15] crypto/octeontx2: sync inline tag type cfg with Rx adapter configuration", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "5df18da81cb5a1f55f1ab8992f398714b02f87a9", "submitter": { "id": 1205, "url": "http://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1579344553-11428-16-git-send-email-anoobj@marvell.com/mbox/", "series": [ { "id": 8203, "url": "http://patches.dpdk.org/api/series/8203/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8203", "date": "2020-01-18T10:48:58", "name": "add OCTEONTX2 inline IPsec support", "version": 2, "mbox": "http://patches.dpdk.org/series/8203/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64871/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/64871/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 77899A051C;\n\tSat, 18 Jan 2020 11:51:53 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5920B1BF9D;\n\tSat, 18 Jan 2020 11:51:23 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 8C7031BF7B\n for <dev@dpdk.org>; Sat, 18 Jan 2020 11:51:16 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 00IAjQOg009563; Sat, 18 Jan 2020 02:51:15 -0800", "from sc-exch04.marvell.com ([199.233.58.184])\n by mx0a-0016f401.pphosted.com with ESMTP id 2xm08v01rf-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Sat, 18 Jan 2020 02:51:15 -0800", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH04.marvell.com\n (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 18 Jan\n 2020 02:51:14 -0800", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n (10.93.176.83) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Sat, 18 Jan 2020 02:51:14 -0800", "from ajoseph83.caveonetworks.com (unknown [10.29.45.60])\n by maili.marvell.com (Postfix) with ESMTP id 1A4143F703F;\n Sat, 18 Jan 2020 02:51:09 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=Hkz+f31n5KZ/VJ+96Nlmk+QiTj7Hloaot4UZPv4j2mw=;\n b=Mw1gCazxoy4JOgJmh3dPUmLKimskyexSXQsihdxB8BEynYRnrvscBB0hlu5qze8eX4X9\n Px2z4oELksWIPrSszRaY5idzZVNLTs1f7IMpMMKJcZzUjfDQt59TaF8tyzFSVxruVqqG\n EFolG39Ym6Ex1y4B4IZfllA7NDQMqeLAjdV346+7ufLutoRYgIxr18fnLr8DPa2xKP08\n zW9Pt9f3xYNXilp1QBx/0kg0KpVRdGlY+D3FsPcPiem0lsmruNHo/p6D5VQxoEdHI+Pw\n 5SlDYNbKaOWE0ldBDnw30K/WBm4nMj2Ov7SrCRqsN9CKUH2sBpU2BX6Wrxeqj5mCpAIu Ug==", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Akhil Goyal <akhil.goyal@nxp.com>, Declan Doherty\n <declan.doherty@intel.com>, Thomas Monjalon <thomas@monjalon.net>", "CC": "Vamsi Attunuru <vattunuru@marvell.com>, Jerin Jacob <jerinj@marvell.com>,\n Narayana Prasad <pathreya@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>,\n \"Pavan Nikhilesh\" <pbhagavatula@marvell.com>, Ankur Dwivedi\n <adwivedi@marvell.com>, Anoob Joseph <anoobj@marvell.com>,\n Archana Muniganti <marchana@marvell.com>,\n Tejasree Kondoj <ktejasree@marvell.com>, Lukasz\n Bartosik <lbartosik@marvell.com>, <dev@dpdk.org>", "Date": "Sat, 18 Jan 2020 16:19:13 +0530", "Message-ID": "<1579344553-11428-16-git-send-email-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1579344553-11428-1-git-send-email-anoobj@marvell.com>", "References": "<1575806094-28391-1-git-send-email-anoobj@marvell.com>\n <1579344553-11428-1-git-send-email-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572\n definitions=2020-01-18_02:2020-01-16,\n 2020-01-18 signatures=0", "Subject": "[dpdk-dev] [PATCH v2 15/15] crypto/octeontx2: sync inline tag type\n\tcfg with Rx adapter configuration", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Vamsi Attunuru <vattunuru@marvell.com>\n\nTag type configuration for the inline processed packets is set during\nethdev configuration, it might conflict with tag type configuration\ndone during Rx adapter configuration which would be setup later.\n\nThis conflict is fixed as part of flow rule creation by updating\ntag type config of inline same as Rx adapter configured tag type.\n\nSigned-off-by: Ankur Dwivedi <adwivedi@marvell.com>\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\nSigned-off-by: Archana Muniganti <marchana@marvell.com>\nSigned-off-by: Tejasree Kondoj <ktejasree@marvell.com>\nSigned-off-by: Vamsi Attunuru <vattunuru@marvell.com>\n---\n drivers/common/octeontx2/otx2_common.h | 2 ++\n drivers/crypto/octeontx2/otx2_cryptodev.c | 2 ++\n drivers/crypto/octeontx2/otx2_security.c | 28 ++++++++++++++++++++++++++++\n drivers/crypto/octeontx2/otx2_security.h | 2 ++\n drivers/net/octeontx2/otx2_flow.c | 26 ++++++++++++++++++++++++++\n 5 files changed, 60 insertions(+)", "diff": "diff --git a/drivers/common/octeontx2/otx2_common.h b/drivers/common/octeontx2/otx2_common.h\nindex 88b4b63..01d3a35 100644\n--- a/drivers/common/octeontx2/otx2_common.h\n+++ b/drivers/common/octeontx2/otx2_common.h\n@@ -81,12 +81,14 @@ typedef int (*otx2_sec_eth_ctx_create_t)(struct rte_eth_dev *eth_dev);\n typedef void (*otx2_sec_eth_ctx_destroy_t)(struct rte_eth_dev *eth_dev);\n typedef int (*otx2_sec_eth_init_t)(struct rte_eth_dev *eth_dev);\n typedef void (*otx2_sec_eth_fini_t)(struct rte_eth_dev *eth_dev);\n+typedef int (*otx2_sec_eth_update_tag_type_t)(struct rte_eth_dev *eth_dev);\n \n struct otx2_sec_eth_crypto_idev_ops {\n \totx2_sec_eth_ctx_create_t ctx_create;\n \totx2_sec_eth_ctx_destroy_t ctx_destroy;\n \totx2_sec_eth_init_t init;\n \totx2_sec_eth_fini_t fini;\n+\totx2_sec_eth_update_tag_type_t update_tag_type;\n };\n \n extern struct otx2_sec_eth_crypto_idev_ops otx2_sec_idev_ops;\ndiff --git a/drivers/crypto/octeontx2/otx2_cryptodev.c b/drivers/crypto/octeontx2/otx2_cryptodev.c\nindex 34feb82..b944a51 100644\n--- a/drivers/crypto/octeontx2/otx2_cryptodev.c\n+++ b/drivers/crypto/octeontx2/otx2_cryptodev.c\n@@ -160,4 +160,6 @@ RTE_INIT(otx2_cpt_init_log)\n \totx2_sec_idev_ops.ctx_destroy = otx2_sec_eth_ctx_destroy;\n \totx2_sec_idev_ops.init = otx2_sec_eth_init;\n \totx2_sec_idev_ops.fini = otx2_sec_eth_fini;\n+\totx2_sec_idev_ops.update_tag_type = otx2_sec_eth_update_tag_type;\n+\n }\ndiff --git a/drivers/crypto/octeontx2/otx2_security.c b/drivers/crypto/octeontx2/otx2_security.c\nindex 9a08849..37b9e54 100644\n--- a/drivers/crypto/octeontx2/otx2_security.c\n+++ b/drivers/crypto/octeontx2/otx2_security.c\n@@ -710,6 +710,34 @@ sec_eth_ipsec_cfg(struct rte_eth_dev *eth_dev, uint8_t tt)\n }\n \n int\n+otx2_sec_eth_update_tag_type(struct rte_eth_dev *eth_dev)\n+{\n+\tstruct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev);\n+\tstruct otx2_mbox *mbox = dev->mbox;\n+\tstruct nix_aq_enq_rsp *rsp;\n+\tstruct nix_aq_enq_req *aq;\n+\tint ret;\n+\n+\taq = otx2_mbox_alloc_msg_nix_aq_enq(mbox);\n+\taq->qidx = 0; /* Read RQ:0 context */\n+\taq->ctype = NIX_AQ_CTYPE_RQ;\n+\taq->op = NIX_AQ_INSTOP_READ;\n+\n+\tret = otx2_mbox_process_msg(mbox, (void *)&rsp);\n+\tif (ret < 0) {\n+\t\totx2_err(\"Could not read RQ context\");\n+\t\treturn ret;\n+\t}\n+\n+\t/* Update tag type */\n+\tret = sec_eth_ipsec_cfg(eth_dev, rsp->rq.sso_tt);\n+\tif (ret < 0)\n+\t\totx2_err(\"Could not update sec eth tag type\");\n+\n+\treturn ret;\n+}\n+\n+int\n otx2_sec_eth_init(struct rte_eth_dev *eth_dev)\n {\n \tconst size_t sa_width = sizeof(struct otx2_ipsec_fp_in_sa);\ndiff --git a/drivers/crypto/octeontx2/otx2_security.h b/drivers/crypto/octeontx2/otx2_security.h\nindex fe7c883..3615273 100644\n--- a/drivers/crypto/octeontx2/otx2_security.h\n+++ b/drivers/crypto/octeontx2/otx2_security.h\n@@ -146,6 +146,8 @@ int otx2_sec_eth_ctx_create(struct rte_eth_dev *eth_dev);\n \n void otx2_sec_eth_ctx_destroy(struct rte_eth_dev *eth_dev);\n \n+int otx2_sec_eth_update_tag_type(struct rte_eth_dev *eth_dev);\n+\n int otx2_sec_eth_init(struct rte_eth_dev *eth_dev);\n \n void otx2_sec_eth_fini(struct rte_eth_dev *eth_dev);\ndiff --git a/drivers/net/octeontx2/otx2_flow.c b/drivers/net/octeontx2/otx2_flow.c\nindex f1fb9f9..dea5337 100644\n--- a/drivers/net/octeontx2/otx2_flow.c\n+++ b/drivers/net/octeontx2/otx2_flow.c\n@@ -299,6 +299,22 @@ flow_free_rss_action(struct rte_eth_dev *eth_dev,\n \treturn 0;\n }\n \n+static int\n+flow_update_sec_tt(struct rte_eth_dev *eth_dev,\n+\t\t const struct rte_flow_action actions[])\n+{\n+\tint rc = 0;\n+\n+\tfor (; actions->type != RTE_FLOW_ACTION_TYPE_END; actions++) {\n+\t\tif (actions->type == RTE_FLOW_ACTION_TYPE_SECURITY) {\n+\t\t\tif (otx2_sec_idev_ops.update_tag_type != NULL)\n+\t\t\t\trc = otx2_sec_idev_ops.update_tag_type(eth_dev);\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+\n+\treturn rc;\n+}\n \n static int\n flow_parse_meta_items(__rte_unused struct otx2_parse_state *pst)\n@@ -491,6 +507,16 @@ otx2_flow_create(struct rte_eth_dev *dev,\n \t\tgoto err_exit;\n \t}\n \n+\tif (hw->rx_offloads & DEV_RX_OFFLOAD_SECURITY) {\n+\t\trc = flow_update_sec_tt(dev, actions);\n+\t\tif (rc != 0) {\n+\t\t\trte_flow_error_set(error, EIO,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\t NULL,\n+\t\t\t\t\t \"Failed to update tt with sec act\");\n+\t\t\tgoto err_exit;\n+\t\t}\n+\t}\n \n \tlist = &hw->npc_flow.flow_list[flow->priority];\n \t/* List in ascending order of mcam entries */\n", "prefixes": [ "v2", "15/15" ] }