Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64866/?format=api
{ "id": 64866, "url": "http://patches.dpdk.org/api/patches/64866/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1579344553-11428-11-git-send-email-anoobj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1579344553-11428-11-git-send-email-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1579344553-11428-11-git-send-email-anoobj@marvell.com", "date": "2020-01-18T10:49:08", "name": "[v2,10/15] crypto/octeontx2: add lookup mem changes to hold sa indices", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "b1c72e6667aa4d474a1910a3176c9b7c6e9450c2", "submitter": { "id": 1205, "url": "http://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1579344553-11428-11-git-send-email-anoobj@marvell.com/mbox/", "series": [ { "id": 8203, "url": "http://patches.dpdk.org/api/series/8203/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8203", "date": "2020-01-18T10:48:58", "name": "add OCTEONTX2 inline IPsec support", "version": 2, "mbox": "http://patches.dpdk.org/series/8203/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64866/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/64866/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E9A4FA051C;\n\tSat, 18 Jan 2020 11:51:05 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CAF79316B;\n\tSat, 18 Jan 2020 11:50:44 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 34ADA2F4F\n for <dev@dpdk.org>; Sat, 18 Jan 2020 11:50:43 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 00IAmMHu018888; Sat, 18 Jan 2020 02:50:42 -0800", "from sc-exch03.marvell.com ([199.233.58.183])\n by mx0b-0016f401.pphosted.com with ESMTP id 2xk0sn6ehg-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Sat, 18 Jan 2020 02:50:42 -0800", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com\n (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 18 Jan\n 2020 02:50:40 -0800", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n (10.93.176.83) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Sat, 18 Jan 2020 02:50:40 -0800", "from ajoseph83.caveonetworks.com (unknown [10.29.45.60])\n by maili.marvell.com (Postfix) with ESMTP id E16773F703F;\n Sat, 18 Jan 2020 02:50:35 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=s3Lh/g7s4atdmse9hg57sTjv28rh9cUHCFSZUhT121w=;\n b=VXFLPUiilu0CZNzDxFBZiepCfISbPoKIOmUW4ycBg1D8mgl+ifPsvmRP+6H0RWGutRrQ\n 9EsmLMGdgz6AP4nk5HUol1UpN8kE/EqUzf4GdPyt1yl+1APkHorY133PbTSJiC8YP2HN\n HngZ5pAWN9H7Jn6bWdnX+VdTeb2BOsI+dU7RxOcHSItYXdQcrxWvkD/X/epfLTAzE+Gv\n j/QUYuZaJ+0fHX5ajYMmeNxBMeGa/JNUOJ8GrvQaXO8ia9GNzZ7fNvVqAN8DRkot7PGP\n Q/GFbvyqZBBPT3J1lBfOPIMema0h5M6mTh/HmoJa2BlIIgaNFaR93IUaZ5QsO50cMFVZ 0w==", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Akhil Goyal <akhil.goyal@nxp.com>, Declan Doherty\n <declan.doherty@intel.com>, Thomas Monjalon <thomas@monjalon.net>", "CC": "Archana Muniganti <marchana@marvell.com>,\n Jerin Jacob <jerinj@marvell.com>,\n Narayana Prasad <pathreya@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>,\n \"Pavan Nikhilesh\" <pbhagavatula@marvell.com>, Ankur Dwivedi\n <adwivedi@marvell.com>, Anoob Joseph <anoobj@marvell.com>, Tejasree Kondoj\n <ktejasree@marvell.com>, Vamsi Attunuru <vattunuru@marvell.com>, Lukasz\n Bartosik <lbartosik@marvell.com>, <dev@dpdk.org>", "Date": "Sat, 18 Jan 2020 16:19:08 +0530", "Message-ID": "<1579344553-11428-11-git-send-email-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1579344553-11428-1-git-send-email-anoobj@marvell.com>", "References": "<1575806094-28391-1-git-send-email-anoobj@marvell.com>\n <1579344553-11428-1-git-send-email-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572\n definitions=2020-01-18_02:2020-01-16,\n 2020-01-18 signatures=0", "Subject": "[dpdk-dev] [PATCH v2 10/15] crypto/octeontx2: add lookup mem\n\tchanges to hold sa indices", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Archana Muniganti <marchana@marvell.com>\n\nlookup_mem provides fast accessing of data path fields.\nStoring sa indices in lookup_mem which are required in\ninline rx data path.\n\nSigned-off-by: Ankur Dwivedi <adwivedi@marvell.com>\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\nSigned-off-by: Archana Muniganti <marchana@marvell.com>\nSigned-off-by: Tejasree Kondoj <ktejasree@marvell.com>\nSigned-off-by: Vamsi Attunuru <vattunuru@marvell.com>\n---\n drivers/common/octeontx2/otx2_common.h | 4 +++\n drivers/crypto/octeontx2/otx2_security.c | 59 ++++++++++++++++++++++++++++++++\n drivers/net/octeontx2/otx2_lookup.c | 11 ++++--\n 3 files changed, 72 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/common/octeontx2/otx2_common.h b/drivers/common/octeontx2/otx2_common.h\nindex fbe7335..88b4b63 100644\n--- a/drivers/common/octeontx2/otx2_common.h\n+++ b/drivers/common/octeontx2/otx2_common.h\n@@ -170,4 +170,8 @@ extern int otx2_logtype_dpi;\n #include \"otx2_io_generic.h\"\n #endif\n \n+/* Fastpath lookup */\n+#define OTX2_NIX_FASTPATH_LOOKUP_MEM\t\"otx2_nix_fastpath_lookup_mem\"\n+#define OTX2_NIX_SA_TBL_START\t\t(4096*4 + 69632*2)\n+\n #endif /* _OTX2_COMMON_H_ */\ndiff --git a/drivers/crypto/octeontx2/otx2_security.c b/drivers/crypto/octeontx2/otx2_security.c\nindex 5606851..ab488a0 100644\n--- a/drivers/crypto/octeontx2/otx2_security.c\n+++ b/drivers/crypto/octeontx2/otx2_security.c\n@@ -10,6 +10,7 @@\n #include <rte_security.h>\n #include <rte_security_driver.h>\n \n+#include \"otx2_common.h\"\n #include \"otx2_cryptodev_qp.h\"\n #include \"otx2_ethdev.h\"\n #include \"otx2_ipsec_fp.h\"\n@@ -96,6 +97,59 @@ static const struct rte_security_capability otx2_sec_eth_capabilities[] = {\n \t}\n };\n \n+static void\n+lookup_mem_sa_tbl_clear(struct rte_eth_dev *eth_dev)\n+{\n+\tstatic const char name[] = OTX2_NIX_FASTPATH_LOOKUP_MEM;\n+\tuint16_t port = eth_dev->data->port_id;\n+\tconst struct rte_memzone *mz;\n+\tuint64_t **sa_tbl;\n+\tuint8_t *mem;\n+\n+\tmz = rte_memzone_lookup(name);\n+\tif (mz == NULL)\n+\t\treturn;\n+\n+\tmem = mz->addr;\n+\n+\tsa_tbl = (uint64_t **)RTE_PTR_ADD(mem, OTX2_NIX_SA_TBL_START);\n+\tif (sa_tbl[port] == NULL)\n+\t\treturn;\n+\n+\trte_free(sa_tbl[port]);\n+\tsa_tbl[port] = NULL;\n+}\n+\n+static int\n+lookup_mem_sa_index_update(struct rte_eth_dev *eth_dev, int spi, void *sa)\n+{\n+\tstatic const char name[] = OTX2_NIX_FASTPATH_LOOKUP_MEM;\n+\tstruct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev);\n+\tuint16_t port = eth_dev->data->port_id;\n+\tconst struct rte_memzone *mz;\n+\tuint64_t **sa_tbl;\n+\tuint8_t *mem;\n+\n+\tmz = rte_memzone_lookup(name);\n+\tif (mz == NULL) {\n+\t\totx2_err(\"Could not find fastpath lookup table\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tmem = mz->addr;\n+\n+\tsa_tbl = (uint64_t **)RTE_PTR_ADD(mem, OTX2_NIX_SA_TBL_START);\n+\n+\tif (sa_tbl[port] == NULL) {\n+\t\tsa_tbl[port] = rte_malloc(NULL, dev->ipsec_in_max_spi *\n+\t\t\t\t\t sizeof(uint64_t), 0);\n+\t}\n+\n+\tsa_tbl[port][spi] = (uint64_t)sa;\n+\n+\treturn 0;\n+}\n+\n static int\n otx2_sec_eth_tx_cpt_qp_get(uint16_t port_id, struct otx2_cpt_qp **qp)\n {\n@@ -343,6 +397,9 @@ sec_eth_ipsec_in_sess_create(struct rte_eth_dev *eth_dev,\n \n \tsa->userdata = priv->userdata;\n \n+\tif (lookup_mem_sa_index_update(eth_dev, ipsec->spi, sa))\n+\t\treturn -EINVAL;\n+\n \treturn ipsec_fp_sa_ctl_set(ipsec, crypto_xform, ctl);\n }\n \n@@ -626,6 +683,8 @@ otx2_sec_eth_fini(struct rte_eth_dev *eth_dev)\n \t !(dev->rx_offloads & DEV_RX_OFFLOAD_SECURITY))\n \t\treturn;\n \n+\tlookup_mem_sa_tbl_clear(eth_dev);\n+\n \tin_sa_mz_name_get(name, RTE_MEMZONE_NAMESIZE, port);\n \trte_memzone_free(rte_memzone_lookup(name));\n }\ndiff --git a/drivers/net/octeontx2/otx2_lookup.c b/drivers/net/octeontx2/otx2_lookup.c\nindex bcf2ff4..d1cf3c3 100644\n--- a/drivers/net/octeontx2/otx2_lookup.c\n+++ b/drivers/net/octeontx2/otx2_lookup.c\n@@ -5,6 +5,7 @@\n #include <rte_common.h>\n #include <rte_memzone.h>\n \n+#include \"otx2_common.h\"\n #include \"otx2_ethdev.h\"\n \n /* NIX_RX_PARSE_S's ERRCODE + ERRLEV (12 bits) */\n@@ -12,7 +13,9 @@\n #define ERR_ARRAY_SZ\t\t\t((BIT(ERRCODE_ERRLEN_WIDTH)) *\\\n \t\t\t\t\tsizeof(uint32_t))\n \n-#define LOOKUP_ARRAY_SZ\t\t\t(PTYPE_ARRAY_SZ + ERR_ARRAY_SZ)\n+#define SA_TBL_SZ\t\t\t(RTE_MAX_ETHPORTS * sizeof(uint64_t))\n+#define LOOKUP_ARRAY_SZ\t\t\t(PTYPE_ARRAY_SZ + ERR_ARRAY_SZ +\\\n+\t\t\t\t\tSA_TBL_SZ)\n \n const uint32_t *\n otx2_nix_supported_ptypes_get(struct rte_eth_dev *eth_dev)\n@@ -314,10 +317,14 @@ nix_create_rx_ol_flags_array(void *mem)\n void *\n otx2_nix_fastpath_lookup_mem_get(void)\n {\n-\tconst char name[] = \"otx2_nix_fastpath_lookup_mem\";\n+\tconst char name[] = OTX2_NIX_FASTPATH_LOOKUP_MEM;\n \tconst struct rte_memzone *mz;\n \tvoid *mem;\n \n+\t/* SA_TBL starts after PTYPE_ARRAY & ERR_ARRAY */\n+\tRTE_BUILD_BUG_ON(OTX2_NIX_SA_TBL_START != (PTYPE_ARRAY_SZ +\n+\t\t\t\t\t\t ERR_ARRAY_SZ));\n+\n \tmz = rte_memzone_lookup(name);\n \tif (mz != NULL)\n \t\treturn mz->addr;\n", "prefixes": [ "v2", "10/15" ] }