Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64863/?format=api
{ "id": 64863, "url": "http://patches.dpdk.org/api/patches/64863/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1579344553-11428-8-git-send-email-anoobj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1579344553-11428-8-git-send-email-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1579344553-11428-8-git-send-email-anoobj@marvell.com", "date": "2020-01-18T10:49:05", "name": "[v2,07/15] crypto/octeontx2: enable CPT to share QP with ethdev", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "51e7738b8134b47a34804d6de5a1890cad4cf337", "submitter": { "id": 1205, "url": "http://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1579344553-11428-8-git-send-email-anoobj@marvell.com/mbox/", "series": [ { "id": 8203, "url": "http://patches.dpdk.org/api/series/8203/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8203", "date": "2020-01-18T10:48:58", "name": "add OCTEONTX2 inline IPsec support", "version": 2, "mbox": "http://patches.dpdk.org/series/8203/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64863/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/64863/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 41A88A051C;\n\tSat, 18 Jan 2020 11:50:36 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BE8F02C5E;\n\tSat, 18 Jan 2020 11:50:26 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 265F12C5E\n for <dev@dpdk.org>; Sat, 18 Jan 2020 11:50:25 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n 00IAkutt017647; Sat, 18 Jan 2020 02:50:24 -0800", "from sc-exch01.marvell.com ([199.233.58.181])\n by mx0b-0016f401.pphosted.com with ESMTP id 2xk0sn6egk-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Sat, 18 Jan 2020 02:50:24 -0800", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 18 Jan\n 2020 02:50:22 -0800", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n (10.93.176.83) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Sat, 18 Jan 2020 02:50:22 -0800", "from ajoseph83.caveonetworks.com (unknown [10.29.45.60])\n by maili.marvell.com (Postfix) with ESMTP id DC7253F7048;\n Sat, 18 Jan 2020 02:50:17 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=t5C4uavmUSFIi0SyCoMXuQi5S82GRkglpVh0MoDhjAs=;\n b=AzcmB+gBhXtFdrr9hZIX3zQbUrOZD7Z5UA4cAIcrzPNqrAgqmt20mehIBLXAEqsbBNKl\n LEgutTRN89n5sEhImZnxn1qEtOJG+Pg5NkJL1Fn7iYugwBmBhnuKhdlgis0Mxg2ixijt\n 6hhorljrlBo0Zi4U6uQFKmOHImgdT3AbU8EaqCqQH3N9be4zSFYCItOPC4QeNPzAuFIE\n mL1EkqO9cCyiTlwnle91CXvvIpAfDOoZxAphH9ZGDdchuKJj7hjM0fQu26HMTxThOnk6\n udi9QzZgNEHvVWWFTlZUHUs8jTQosBAeZ8Nr+oubdWH1i5jmSpo1I96KyTSJjYgpa6QU cg==", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Akhil Goyal <akhil.goyal@nxp.com>, Declan Doherty\n <declan.doherty@intel.com>, Thomas Monjalon <thomas@monjalon.net>", "CC": "Anoob Joseph <anoobj@marvell.com>, Jerin Jacob <jerinj@marvell.com>,\n Narayana Prasad <pathreya@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>,\n \"Pavan Nikhilesh\" <pbhagavatula@marvell.com>, Ankur Dwivedi\n <adwivedi@marvell.com>, Archana Muniganti <marchana@marvell.com>, Tejasree\n Kondoj <ktejasree@marvell.com>, Vamsi Attunuru <vattunuru@marvell.com>,\n \"Lukasz Bartosik\" <lbartosik@marvell.com>, <dev@dpdk.org>", "Date": "Sat, 18 Jan 2020 16:19:05 +0530", "Message-ID": "<1579344553-11428-8-git-send-email-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1579344553-11428-1-git-send-email-anoobj@marvell.com>", "References": "<1575806094-28391-1-git-send-email-anoobj@marvell.com>\n <1579344553-11428-1-git-send-email-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572\n definitions=2020-01-18_02:2020-01-16,\n 2020-01-18 signatures=0", "Subject": "[dpdk-dev] [PATCH v2 07/15] crypto/octeontx2: enable CPT to share\n\tQP with ethdev", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Adding the infrastructure to save one opaque pointer in idev and\nimplement the consumer-producer in the PMDs which uses it accordingly.\n\nSigned-off-by: Ankur Dwivedi <adwivedi@marvell.com>\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\nSigned-off-by: Archana Muniganti <marchana@marvell.com>\nSigned-off-by: Tejasree Kondoj <ktejasree@marvell.com>\nSigned-off-by: Vamsi Attunuru <vattunuru@marvell.com>\n---\n .../crypto/octeontx2/otx2_cryptodev_hw_access.h | 22 +----\n drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 18 ++++\n drivers/crypto/octeontx2/otx2_cryptodev_qp.h | 35 ++++++++\n drivers/crypto/octeontx2/otx2_security.c | 98 ++++++++++++++++++++++\n drivers/crypto/octeontx2/otx2_security.h | 20 +++++\n 5 files changed, 172 insertions(+), 21 deletions(-)\n create mode 100644 drivers/crypto/octeontx2/otx2_cryptodev_qp.h", "diff": "diff --git a/drivers/crypto/octeontx2/otx2_cryptodev_hw_access.h b/drivers/crypto/octeontx2/otx2_cryptodev_hw_access.h\nindex 6f78aa4..43db6a6 100644\n--- a/drivers/crypto/octeontx2/otx2_cryptodev_hw_access.h\n+++ b/drivers/crypto/octeontx2/otx2_cryptodev_hw_access.h\n@@ -15,6 +15,7 @@\n #include \"cpt_mcode_defines.h\"\n \n #include \"otx2_dev.h\"\n+#include \"otx2_cryptodev_qp.h\"\n \n /* CPT instruction queue length */\n #define OTX2_CPT_IQ_LEN\t\t\t8200\n@@ -135,27 +136,6 @@ enum cpt_9x_comp_e {\n \tCPT_9X_COMP_E_LAST_ENTRY = 0x06\n };\n \n-struct otx2_cpt_qp {\n-\tuint32_t id;\n-\t/**< Queue pair id */\n-\tuintptr_t base;\n-\t/**< Base address where BAR is mapped */\n-\tvoid *lmtline;\n-\t/**< Address of LMTLINE */\n-\trte_iova_t lf_nq_reg;\n-\t/**< LF enqueue register address */\n-\tstruct pending_queue pend_q;\n-\t/**< Pending queue */\n-\tstruct rte_mempool *sess_mp;\n-\t/**< Session mempool */\n-\tstruct rte_mempool *sess_mp_priv;\n-\t/**< Session private data mempool */\n-\tstruct cpt_qp_meta_info meta_info;\n-\t/**< Metabuf info required to support operations on the queue pair */\n-\trte_iova_t iq_dma_addr;\n-\t/**< Instruction queue address */\n-};\n-\n void otx2_cpt_err_intr_unregister(const struct rte_cryptodev *dev);\n \n int otx2_cpt_err_intr_register(const struct rte_cryptodev *dev);\ndiff --git a/drivers/crypto/octeontx2/otx2_cryptodev_ops.c b/drivers/crypto/octeontx2/otx2_cryptodev_ops.c\nindex b45cb82..d275478 100644\n--- a/drivers/crypto/octeontx2/otx2_cryptodev_ops.c\n+++ b/drivers/crypto/octeontx2/otx2_cryptodev_ops.c\n@@ -13,6 +13,7 @@\n #include \"otx2_cryptodev_hw_access.h\"\n #include \"otx2_cryptodev_mbox.h\"\n #include \"otx2_cryptodev_ops.h\"\n+#include \"otx2_security.h\"\n #include \"otx2_mbox.h\"\n \n #include \"cpt_hw_types.h\"\n@@ -148,6 +149,11 @@ otx2_cpt_qp_inline_cfg(const struct rte_cryptodev *dev, struct otx2_cpt_qp *qp)\n \tif (ret)\n \t\treturn ret;\n \n+\t/* Publish inline Tx QP to eth dev security */\n+\tret = otx2_sec_tx_cpt_qp_add(port_id, qp);\n+\tif (ret)\n+\t\treturn ret;\n+\n \treturn 0;\n }\n \n@@ -242,6 +248,12 @@ otx2_cpt_qp_create(const struct rte_cryptodev *dev, uint16_t qp_id,\n \n \tqp->lf_nq_reg = qp->base + OTX2_CPT_LF_NQ(0);\n \n+\tret = otx2_sec_tx_cpt_qp_remove(qp);\n+\tif (ret && (ret != -ENOENT)) {\n+\t\tCPT_LOG_ERR(\"Could not delete inline configuration\");\n+\t\tgoto mempool_destroy;\n+\t}\n+\n \totx2_cpt_iq_disable(qp);\n \n \tret = otx2_cpt_qp_inline_cfg(dev, qp);\n@@ -275,6 +287,12 @@ otx2_cpt_qp_destroy(const struct rte_cryptodev *dev, struct otx2_cpt_qp *qp)\n \tchar name[RTE_MEMZONE_NAMESIZE];\n \tint ret;\n \n+\tret = otx2_sec_tx_cpt_qp_remove(qp);\n+\tif (ret && (ret != -ENOENT)) {\n+\t\tCPT_LOG_ERR(\"Could not delete inline configuration\");\n+\t\treturn ret;\n+\t}\n+\n \totx2_cpt_iq_disable(qp);\n \n \totx2_cpt_metabuf_mempool_destroy(qp);\ndiff --git a/drivers/crypto/octeontx2/otx2_cryptodev_qp.h b/drivers/crypto/octeontx2/otx2_cryptodev_qp.h\nnew file mode 100644\nindex 0000000..9d48da4\n--- /dev/null\n+++ b/drivers/crypto/octeontx2/otx2_cryptodev_qp.h\n@@ -0,0 +1,35 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright (C) 2020 Marvell International Ltd.\n+ */\n+\n+#ifndef _OTX2_CRYPTODEV_QP_H_\n+#define _OTX2_CRYPTODEV_QP_H_\n+\n+#include <rte_common.h>\n+#include <rte_mempool.h>\n+#include <rte_spinlock.h>\n+\n+#include \"cpt_common.h\"\n+\n+struct otx2_cpt_qp {\n+\tuint32_t id;\n+\t/**< Queue pair id */\n+\tuintptr_t base;\n+\t/**< Base address where BAR is mapped */\n+\tvoid *lmtline;\n+\t/**< Address of LMTLINE */\n+\trte_iova_t lf_nq_reg;\n+\t/**< LF enqueue register address */\n+\tstruct pending_queue pend_q;\n+\t/**< Pending queue */\n+\tstruct rte_mempool *sess_mp;\n+\t/**< Session mempool */\n+\tstruct rte_mempool *sess_mp_priv;\n+\t/**< Session private data mempool */\n+\tstruct cpt_qp_meta_info meta_info;\n+\t/**< Metabuf info required to support operations on the queue pair */\n+\trte_iova_t iq_dma_addr;\n+\t/**< Instruction queue address */\n+};\n+\n+#endif /* _OTX2_CRYPTODEV_QP_H_ */\ndiff --git a/drivers/crypto/octeontx2/otx2_security.c b/drivers/crypto/octeontx2/otx2_security.c\nindex b8c8f91..0534154 100644\n--- a/drivers/crypto/octeontx2/otx2_security.c\n+++ b/drivers/crypto/octeontx2/otx2_security.c\n@@ -10,6 +10,7 @@\n #include <rte_security.h>\n #include <rte_security_driver.h>\n \n+#include \"otx2_cryptodev_qp.h\"\n #include \"otx2_ethdev.h\"\n #include \"otx2_ipsec_fp.h\"\n #include \"otx2_security.h\"\n@@ -29,6 +30,8 @@ struct sec_eth_tag_const {\n \t};\n };\n \n+static struct otx2_sec_eth_cfg sec_cfg[OTX2_MAX_INLINE_PORTS];\n+\n static struct rte_cryptodev_capabilities otx2_sec_eth_crypto_caps[] = {\n \t{\t/* AES GCM */\n \t\t.op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,\n@@ -116,16 +119,41 @@ static struct rte_security_ops otx2_sec_eth_ops = {\n \t.capabilities_get\t= otx2_sec_eth_capabilities_get\n };\n \n+static int\n+otx2_sec_eth_cfg_init(int port_id)\n+{\n+\tstruct otx2_sec_eth_cfg *cfg;\n+\tint i;\n+\n+\tcfg = &sec_cfg[port_id];\n+\tcfg->tx_cpt_idx = 0;\n+\trte_spinlock_init(&cfg->tx_cpt_lock);\n+\n+\tfor (i = 0; i < OTX2_MAX_CPT_QP_PER_PORT; i++) {\n+\t\tcfg->tx_cpt[i].qp = NULL;\n+\t\trte_atomic16_set(&cfg->tx_cpt[i].ref_cnt, 0);\n+\t}\n+\n+\treturn 0;\n+}\n+\n int\n otx2_sec_eth_ctx_create(struct rte_eth_dev *eth_dev)\n {\n \tstruct rte_security_ctx *ctx;\n+\tint ret;\n \n \tctx = rte_malloc(\"otx2_sec_eth_ctx\",\n \t\t\t sizeof(struct rte_security_ctx), 0);\n \tif (ctx == NULL)\n \t\treturn -ENOMEM;\n \n+\tret = otx2_sec_eth_cfg_init(eth_dev->data->port_id);\n+\tif (ret) {\n+\t\trte_free(ctx);\n+\t\treturn ret;\n+\t}\n+\n \t/* Populate ctx */\n \n \tctx->device = eth_dev;\n@@ -239,3 +267,73 @@ otx2_sec_eth_fini(struct rte_eth_dev *eth_dev)\n \tin_sa_mz_name_get(name, RTE_MEMZONE_NAMESIZE, port);\n \trte_memzone_free(rte_memzone_lookup(name));\n }\n+\n+int\n+otx2_sec_tx_cpt_qp_add(uint16_t port_id, struct otx2_cpt_qp *qp)\n+{\n+\tstruct otx2_sec_eth_cfg *cfg;\n+\tint i, ret;\n+\n+\tif (qp == NULL || port_id > OTX2_MAX_INLINE_PORTS)\n+\t\treturn -EINVAL;\n+\n+\tcfg = &sec_cfg[port_id];\n+\n+\t/* Find a free slot to save CPT LF */\n+\n+\trte_spinlock_lock(&cfg->tx_cpt_lock);\n+\n+\tfor (i = 0; i < OTX2_MAX_CPT_QP_PER_PORT; i++) {\n+\t\tif (cfg->tx_cpt[i].qp == NULL) {\n+\t\t\tcfg->tx_cpt[i].qp = qp;\n+\t\t\tret = 0;\n+\t\t\tgoto unlock;\n+\t\t}\n+\t}\n+\n+\tret = -EINVAL;\n+\n+unlock:\n+\trte_spinlock_unlock(&cfg->tx_cpt_lock);\n+\treturn ret;\n+}\n+\n+int\n+otx2_sec_tx_cpt_qp_remove(struct otx2_cpt_qp *qp)\n+{\n+\tstruct otx2_sec_eth_cfg *cfg;\n+\tuint16_t port_id;\n+\tint i, ret;\n+\n+\tif (qp == NULL)\n+\t\treturn -EINVAL;\n+\n+\tfor (port_id = 0; port_id < OTX2_MAX_INLINE_PORTS; port_id++) {\n+\t\tcfg = &sec_cfg[port_id];\n+\n+\t\trte_spinlock_lock(&cfg->tx_cpt_lock);\n+\n+\t\tfor (i = 0; i < OTX2_MAX_CPT_QP_PER_PORT; i++) {\n+\t\t\tif (cfg->tx_cpt[i].qp != qp)\n+\t\t\t\tcontinue;\n+\n+\t\t\t/* Don't free if the QP is in use by any sec session */\n+\t\t\tif (rte_atomic16_read(&cfg->tx_cpt[i].ref_cnt)) {\n+\t\t\t\tret = -EBUSY;\n+\t\t\t} else {\n+\t\t\t\tcfg->tx_cpt[i].qp = NULL;\n+\t\t\t\tret = 0;\n+\t\t\t}\n+\n+\t\t\tgoto unlock;\n+\t\t}\n+\n+\t\trte_spinlock_unlock(&cfg->tx_cpt_lock);\n+\t}\n+\n+\treturn -ENOENT;\n+\n+unlock:\n+\trte_spinlock_unlock(&cfg->tx_cpt_lock);\n+\treturn ret;\n+}\ndiff --git a/drivers/crypto/octeontx2/otx2_security.h b/drivers/crypto/octeontx2/otx2_security.h\nindex a442f5c..6086efa 100644\n--- a/drivers/crypto/octeontx2/otx2_security.h\n+++ b/drivers/crypto/octeontx2/otx2_security.h\n@@ -5,10 +5,27 @@\n #ifndef __OTX2_SECURITY_H__\n #define __OTX2_SECURITY_H__\n \n+#include <rte_atomic.h>\n #include <rte_ethdev.h>\n+#include <rte_spinlock.h>\n \n #include \"otx2_ipsec_fp.h\"\n \n+#define OTX2_MAX_CPT_QP_PER_PORT 64\n+#define OTX2_MAX_INLINE_PORTS 64\n+\n+struct otx2_cpt_qp;\n+\n+struct otx2_sec_eth_cfg {\n+\tstruct {\n+\t\tstruct otx2_cpt_qp *qp;\n+\t\trte_atomic16_t ref_cnt;\n+\t} tx_cpt[OTX2_MAX_CPT_QP_PER_PORT];\n+\n+\tuint16_t tx_cpt_idx;\n+\trte_spinlock_t tx_cpt_lock;\n+};\n+\n /*\n * Security session for inline IPsec protocol offload. This is private data of\n * inline capable PMD.\n@@ -33,4 +50,7 @@ int otx2_sec_eth_init(struct rte_eth_dev *eth_dev);\n \n void otx2_sec_eth_fini(struct rte_eth_dev *eth_dev);\n \n+int otx2_sec_tx_cpt_qp_add(uint16_t port_id, struct otx2_cpt_qp *qp);\n+\n+int otx2_sec_tx_cpt_qp_remove(struct otx2_cpt_qp *qp);\n #endif /* __OTX2_SECURITY_H__ */\n", "prefixes": [ "v2", "07/15" ] }