Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64805/?format=api
{ "id": 64805, "url": "http://patches.dpdk.org/api/patches/64805/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200116130455.30193-10-kalesh-anakkur.purayil@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200116130455.30193-10-kalesh-anakkur.purayil@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200116130455.30193-10-kalesh-anakkur.purayil@broadcom.com", "date": "2020-01-16T13:04:54", "name": "[V4,09/10] net/bnxt: release port upon close", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6190b4d9d3c84b596f30209fe731199f86b6be3d", "submitter": { "id": 1479, "url": "http://patches.dpdk.org/api/people/1479/?format=api", "name": "Kalesh A P", "email": "kalesh-anakkur.purayil@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200116130455.30193-10-kalesh-anakkur.purayil@broadcom.com/mbox/", "series": [ { "id": 8172, "url": "http://patches.dpdk.org/api/series/8172/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8172", "date": "2020-01-16T13:04:45", "name": "bnxt patchset with bug fixes", "version": 4, "mbox": "http://patches.dpdk.org/series/8172/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64805/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/64805/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3DC8CA0352;\n\tThu, 16 Jan 2020 13:49:09 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1A8AF1D511;\n\tThu, 16 Jan 2020 13:48:04 +0100 (CET)", "from relay.smtp.broadcom.com (relay.smtp.broadcom.com\n [192.19.211.62]) by dpdk.org (Postfix) with ESMTP id C0CA31D17E\n for <dev@dpdk.org>; Thu, 16 Jan 2020 13:47:49 +0100 (CET)", "from dhcp-10-123-153-22.dhcp.broadcom.net\n (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id 4AB6A28F56B;\n Thu, 16 Jan 2020 04:47:49 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 4AB6A28F56B", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1579178869;\n bh=0EFeSHNPeJP9+XP+KNBUFs/ZZFklk45/IQ/rJdWAYpo=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=i+XsbrHR/vhmnZ450Q2rpxgZRP3OwC23eFbd1RglsH0NXYTjSGP9z+jZndE1elxKA\n qGRbji+f2qn0I6SM3nMC7S2W9EE2XsW5drUSMbe9ZbwXg3Xa1rRR1CDELTr4kpYQqt\n /QrL+AjwPihWH2TzTMzwRy2HPgs6eeW0v+dUZpxk=", "From": "Kalesh A P <kalesh-anakkur.purayil@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tajit.khaparde@broadcom.com", "Date": "Thu, 16 Jan 2020 18:34:54 +0530", "Message-Id": "<20200116130455.30193-10-kalesh-anakkur.purayil@broadcom.com>", "X-Mailer": "git-send-email 2.10.1", "In-Reply-To": "<20200116130455.30193-1-kalesh-anakkur.purayil@broadcom.com>", "References": "<20200116130455.30193-1-kalesh-anakkur.purayil@broadcom.com>", "Subject": "[dpdk-dev] [PATCH V4 09/10] net/bnxt: release port upon close", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Somnath Kotur <somnath.kotur@broadcom.com>\n\nSet RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources\nfor the port can be freed by rte_eth_dev_close().\n\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 53 ++++++++++++++++++------------------------\n 1 file changed, 22 insertions(+), 31 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex ba3f0a7..2ef1169 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -986,16 +986,22 @@ static void bnxt_dev_close_op(struct rte_eth_dev *eth_dev)\n \tif (bp->dev_stopped == 0)\n \t\tbnxt_dev_stop_op(eth_dev);\n \n-\tif (eth_dev->data->mac_addrs != NULL) {\n-\t\trte_free(eth_dev->data->mac_addrs);\n-\t\teth_dev->data->mac_addrs = NULL;\n-\t}\n-\tif (bp->grp_info != NULL) {\n-\t\trte_free(bp->grp_info);\n-\t\tbp->grp_info = NULL;\n-\t}\n+\tbnxt_uninit_resources(bp, false);\n \n-\tbnxt_dev_uninit(eth_dev);\n+\teth_dev->dev_ops = NULL;\n+\teth_dev->rx_pkt_burst = NULL;\n+\teth_dev->tx_pkt_burst = NULL;\n+\n+\trte_memzone_free((const struct rte_memzone *)bp->tx_mem_zone);\n+\tbp->tx_mem_zone = NULL;\n+\trte_memzone_free((const struct rte_memzone *)bp->rx_mem_zone);\n+\tbp->rx_mem_zone = NULL;\n+\n+\trte_free(bp->pf.vf_info);\n+\tbp->pf.vf_info = NULL;\n+\n+\trte_free(bp->grp_info);\n+\tbp->grp_info = NULL;\n }\n \n static void bnxt_mac_addr_remove_op(struct rte_eth_dev *eth_dev,\n@@ -4856,6 +4862,11 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n \tif (rc)\n \t\tgoto error_free;\n \n+\t/* Pass the information to the rte_eth_dev_close() that it should also\n+\t * release the private port resources.\n+\t */\n+\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n+\n \tPMD_DRV_LOG(INFO,\n \t\t DRV_MODULE_NAME \"found at mem %\" PRIX64 \", node addr %pM\\n\",\n \t\t pci_dev->mem_resource[0].phys_addr,\n@@ -4904,35 +4915,15 @@ bnxt_uninit_resources(struct bnxt *bp, bool reconfig_dev)\n static int\n bnxt_dev_uninit(struct rte_eth_dev *eth_dev)\n {\n-\tstruct bnxt *bp = eth_dev->data->dev_private;\n-\tint rc;\n-\n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn -EPERM;\n \n \tPMD_DRV_LOG(DEBUG, \"Calling Device uninit\\n\");\n \n-\trc = bnxt_uninit_resources(bp, false);\n-\n-\tif (bp->tx_mem_zone) {\n-\t\trte_memzone_free((const struct rte_memzone *)bp->tx_mem_zone);\n-\t\tbp->tx_mem_zone = NULL;\n-\t}\n-\n-\tif (bp->rx_mem_zone) {\n-\t\trte_memzone_free((const struct rte_memzone *)bp->rx_mem_zone);\n-\t\tbp->rx_mem_zone = NULL;\n-\t}\n-\n-\tif (bp->dev_stopped == 0)\n+\tif (eth_dev->state != RTE_ETH_DEV_UNUSED)\n \t\tbnxt_dev_close_op(eth_dev);\n-\tif (bp->pf.vf_info)\n-\t\trte_free(bp->pf.vf_info);\n-\teth_dev->dev_ops = NULL;\n-\teth_dev->rx_pkt_burst = NULL;\n-\teth_dev->tx_pkt_burst = NULL;\n \n-\treturn rc;\n+\treturn 0;\n }\n \n static int bnxt_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n", "prefixes": [ "V4", "09/10" ] }