Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64802/?format=api
http://patches.dpdk.org/api/patches/64802/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200116130455.30193-8-kalesh-anakkur.purayil@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200116130455.30193-8-kalesh-anakkur.purayil@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200116130455.30193-8-kalesh-anakkur.purayil@broadcom.com", "date": "2020-01-16T13:04:52", "name": "[V4,07/10] net/bnxt: fix a memory leak in port stop", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "552918590a68b3c8dc82df5f41e54349dfd200b5", "submitter": { "id": 1479, "url": "http://patches.dpdk.org/api/people/1479/?format=api", "name": "Kalesh A P", "email": "kalesh-anakkur.purayil@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200116130455.30193-8-kalesh-anakkur.purayil@broadcom.com/mbox/", "series": [ { "id": 8172, "url": "http://patches.dpdk.org/api/series/8172/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8172", "date": "2020-01-16T13:04:45", "name": "bnxt patchset with bug fixes", "version": 4, "mbox": "http://patches.dpdk.org/series/8172/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64802/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/64802/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 822E8A0352;\n\tThu, 16 Jan 2020 13:48:42 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D13D31D455;\n\tThu, 16 Jan 2020 13:47:59 +0100 (CET)", "from relay.smtp.broadcom.com (relay.smtp.broadcom.com\n [192.19.211.62]) by dpdk.org (Postfix) with ESMTP id 1614B1D40F\n for <dev@dpdk.org>; Thu, 16 Jan 2020 13:47:49 +0100 (CET)", "from dhcp-10-123-153-22.dhcp.broadcom.net\n (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id 8A13228F541;\n Thu, 16 Jan 2020 04:47:48 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 8A13228F541", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1579178868;\n bh=5amfrjVPyPulkOjlPIzQ0A1B1kXZZxngKeu15yxnJfI=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=p7OF9I6fDkVx/qCjCFYUUVYTjsQTm4zIbqKqr3TCiKgjVQ3R5ayuMM3bp5A/K7wxg\n oQrof0OLmQ/UNcR1I4ozTLKbTMdHAxOZnnxnakb4u79UqE5FreuXs81tfJWRHEy7vy\n WOiMbGWEWbi3dl2lmMhsg+GZs6wOdX+e5DIO7Qcs=", "From": "Kalesh A P <kalesh-anakkur.purayil@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tajit.khaparde@broadcom.com", "Date": "Thu, 16 Jan 2020 18:34:52 +0530", "Message-Id": "<20200116130455.30193-8-kalesh-anakkur.purayil@broadcom.com>", "X-Mailer": "git-send-email 2.10.1", "In-Reply-To": "<20200116130455.30193-1-kalesh-anakkur.purayil@broadcom.com>", "References": "<20200116130455.30193-1-kalesh-anakkur.purayil@broadcom.com>", "Subject": "[dpdk-dev] [PATCH V4 07/10] net/bnxt: fix a memory leak in port stop", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nThe memory for mark table is allocated during port start.\nBut the allocated memory is freed only during port close\nor driver unload which in turn causes a memory leakage\non each port start/stop.\n\nFixed it by moving the memory free to port stop.\n\nFixes: a968a9f5456d (\"net/bnxt: add support for flow mark action\")\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 436ecbb..2661418 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -970,7 +970,10 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)\n \tbnxt_int_handler(eth_dev);\n \tbnxt_shutdown_nic(bp);\n \tbnxt_hwrm_if_change(bp, 0);\n-\tmemset(bp->mark_table, 0, BNXT_MARK_TABLE_SZ);\n+\n+\trte_free(bp->mark_table);\n+\tbp->mark_table = NULL;\n+\n \tbp->flags &= ~BNXT_FLAG_RX_VECTOR_PKT_MODE;\n \tbp->dev_stopped = 1;\n \tbp->rx_cosq_cnt = 0;\n@@ -992,9 +995,6 @@ static void bnxt_dev_close_op(struct rte_eth_dev *eth_dev)\n \t\tbp->grp_info = NULL;\n \t}\n \n-\trte_free(bp->mark_table);\n-\tbp->mark_table = NULL;\n-\n \tbnxt_dev_uninit(eth_dev);\n }\n \n", "prefixes": [ "V4", "07/10" ] }{ "id": 64802, "url": "