Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64672/?format=api
{ "id": 64672, "url": "http://patches.dpdk.org/api/patches/64672/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1579012036-326214-2-git-send-email-vladimir.medvedkin@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1579012036-326214-2-git-send-email-vladimir.medvedkin@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1579012036-326214-2-git-send-email-vladimir.medvedkin@intel.com", "date": "2020-01-14T14:27:12", "name": "[v4,1/5] ipsec: move ipsec sad name length into .h", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "00e23eab7d7027e6ca915d10a0b28faaf845c783", "submitter": { "id": 1216, "url": "http://patches.dpdk.org/api/people/1216/?format=api", "name": "Vladimir Medvedkin", "email": "vladimir.medvedkin@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1579012036-326214-2-git-send-email-vladimir.medvedkin@intel.com/mbox/", "series": [ { "id": 8120, "url": "http://patches.dpdk.org/api/series/8120/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8120", "date": "2020-01-14T14:27:11", "name": "integrate librte_ipsec SAD into ipsec-secgw", "version": 4, "mbox": "http://patches.dpdk.org/series/8120/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64672/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/64672/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ADAC7A04FF;\n\tTue, 14 Jan 2020 15:27:27 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 20E3C1C1C2;\n\tTue, 14 Jan 2020 15:27:24 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id E881B1C116\n for <dev@dpdk.org>; Tue, 14 Jan 2020 15:27:20 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 14 Jan 2020 06:27:20 -0800", "from silpixa00400072.ir.intel.com ([10.237.222.213])\n by fmsmga002.fm.intel.com with ESMTP; 14 Jan 2020 06:27:19 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,433,1571727600\"; d=\"scan'208\";a=\"256316505\"", "From": "Vladimir Medvedkin <vladimir.medvedkin@intel.com>", "To": "dev@dpdk.org", "Cc": "konstantin.ananyev@intel.com,\n\takhil.goyal@nxp.com", "Date": "Tue, 14 Jan 2020 14:27:12 +0000", "Message-Id": "<1579012036-326214-2-git-send-email-vladimir.medvedkin@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": [ "<1579012036-326214-1-git-send-email-vladimir.medvedkin@intel.com>", "<1578920122-228017-1-git-send-email-vladimir.medvedkin@intel.com>" ], "References": [ "<1579012036-326214-1-git-send-email-vladimir.medvedkin@intel.com>", "<1578920122-228017-1-git-send-email-vladimir.medvedkin@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v4 1/5] ipsec: move ipsec sad name length into .h", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Move IPSEC_SAD_NAMESIZE into public header\nand rename it to RTE_IPSEC_SAD_NAMESIZE\n\nSigned-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>\n---\n lib/librte_ipsec/ipsec_sad.c | 20 ++++++++++----------\n lib/librte_ipsec/rte_ipsec_sad.h | 2 ++\n 2 files changed, 12 insertions(+), 10 deletions(-)", "diff": "diff --git a/lib/librte_ipsec/ipsec_sad.c b/lib/librte_ipsec/ipsec_sad.c\nindex db2c44c..2c994ed 100644\n--- a/lib/librte_ipsec/ipsec_sad.c\n+++ b/lib/librte_ipsec/ipsec_sad.c\n@@ -20,7 +20,6 @@\n * indicate presence of entries with the same SPI in DIP and DIP+SIP tables.\n */\n \n-#define IPSEC_SAD_NAMESIZE\t64\n #define SAD_PREFIX\t\t\"SAD_\"\n /* \"SAD_<name>\" */\n #define SAD_FORMAT\t\tSAD_PREFIX \"%s\"\n@@ -34,7 +33,7 @@ struct hash_cnt {\n };\n \n struct rte_ipsec_sad {\n-\tchar name[IPSEC_SAD_NAMESIZE];\n+\tchar name[RTE_IPSEC_SAD_NAMESIZE];\n \tstruct rte_hash\t*hash[RTE_IPSEC_SAD_KEY_TYPE_MASK];\n \t/* Array to track number of more specific rules\n \t * (spi_dip or spi_dip_sip). Used only in add/delete\n@@ -231,7 +230,7 @@ struct rte_ipsec_sad *\n rte_ipsec_sad_create(const char *name, const struct rte_ipsec_sad_conf *conf)\n {\n \tchar hash_name[RTE_HASH_NAMESIZE];\n-\tchar sad_name[IPSEC_SAD_NAMESIZE];\n+\tchar sad_name[RTE_IPSEC_SAD_NAMESIZE];\n \tstruct rte_tailq_entry *te;\n \tstruct rte_ipsec_sad_list *sad_list;\n \tstruct rte_ipsec_sad *sad, *tmp_sad = NULL;\n@@ -249,8 +248,8 @@ rte_ipsec_sad_create(const char *name, const struct rte_ipsec_sad_conf *conf)\n \t\treturn NULL;\n \t}\n \n-\tret = snprintf(sad_name, IPSEC_SAD_NAMESIZE, SAD_FORMAT, name);\n-\tif (ret < 0 || ret >= IPSEC_SAD_NAMESIZE) {\n+\tret = snprintf(sad_name, RTE_IPSEC_SAD_NAMESIZE, SAD_FORMAT, name);\n+\tif (ret < 0 || ret >= RTE_IPSEC_SAD_NAMESIZE) {\n \t\trte_errno = ENAMETOOLONG;\n \t\treturn NULL;\n \t}\n@@ -326,7 +325,8 @@ rte_ipsec_sad_create(const char *name, const struct rte_ipsec_sad_conf *conf)\n \t/* guarantee there's no existing */\n \tTAILQ_FOREACH(te, sad_list, next) {\n \t\ttmp_sad = (struct rte_ipsec_sad *)te->data;\n-\t\tif (strncmp(sad_name, tmp_sad->name, IPSEC_SAD_NAMESIZE) == 0)\n+\t\tif (strncmp(sad_name, tmp_sad->name,\n+\t\t\t\tRTE_IPSEC_SAD_NAMESIZE) == 0)\n \t\t\tbreak;\n \t}\n \tif (te != NULL) {\n@@ -354,14 +354,14 @@ rte_ipsec_sad_create(const char *name, const struct rte_ipsec_sad_conf *conf)\n struct rte_ipsec_sad *\n rte_ipsec_sad_find_existing(const char *name)\n {\n-\tchar sad_name[IPSEC_SAD_NAMESIZE];\n+\tchar sad_name[RTE_IPSEC_SAD_NAMESIZE];\n \tstruct rte_ipsec_sad *sad = NULL;\n \tstruct rte_tailq_entry *te;\n \tstruct rte_ipsec_sad_list *sad_list;\n \tint ret;\n \n-\tret = snprintf(sad_name, IPSEC_SAD_NAMESIZE, SAD_FORMAT, name);\n-\tif (ret < 0 || ret >= IPSEC_SAD_NAMESIZE) {\n+\tret = snprintf(sad_name, RTE_IPSEC_SAD_NAMESIZE, SAD_FORMAT, name);\n+\tif (ret < 0 || ret >= RTE_IPSEC_SAD_NAMESIZE) {\n \t\trte_errno = ENAMETOOLONG;\n \t\treturn NULL;\n \t}\n@@ -372,7 +372,7 @@ rte_ipsec_sad_find_existing(const char *name)\n \trte_mcfg_tailq_read_lock();\n \tTAILQ_FOREACH(te, sad_list, next) {\n \t\tsad = (struct rte_ipsec_sad *) te->data;\n-\t\tif (strncmp(sad_name, sad->name, IPSEC_SAD_NAMESIZE) == 0)\n+\t\tif (strncmp(sad_name, sad->name, RTE_IPSEC_SAD_NAMESIZE) == 0)\n \t\t\tbreak;\n \t}\n \trte_mcfg_tailq_read_unlock();\ndiff --git a/lib/librte_ipsec/rte_ipsec_sad.h b/lib/librte_ipsec/rte_ipsec_sad.h\nindex 8386f73..dcc8224 100644\n--- a/lib/librte_ipsec/rte_ipsec_sad.h\n+++ b/lib/librte_ipsec/rte_ipsec_sad.h\n@@ -47,6 +47,8 @@ union rte_ipsec_sad_key {\n \tstruct rte_ipsec_sadv6_key\tv6;\n };\n \n+/** Max number of characters in SAD name. */\n+#define RTE_IPSEC_SAD_NAMESIZE\t\t64\n /** Flag to create SAD with ipv6 dip and sip addresses */\n #define RTE_IPSEC_SAD_FLAG_IPV6\t\t\t0x1\n /** Flag to support reader writer concurrency */\n", "prefixes": [ "v4", "1/5" ] }