Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64638/?format=api
{ "id": 64638, "url": "http://patches.dpdk.org/api/patches/64638/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200114112945.39375-2-reshma.pattan@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200114112945.39375-2-reshma.pattan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200114112945.39375-2-reshma.pattan@intel.com", "date": "2020-01-14T11:29:41", "name": "[1/5] net/ixgbe: remove ixgbe vector config flag", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "af9e006fba7a4e6e03f746fc7178942f11fd8e25", "submitter": { "id": 70, "url": "http://patches.dpdk.org/api/people/70/?format=api", "name": "Pattan, Reshma", "email": "reshma.pattan@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200114112945.39375-2-reshma.pattan@intel.com/mbox/", "series": [ { "id": 8112, "url": "http://patches.dpdk.org/api/series/8112/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8112", "date": "2020-01-14T11:29:40", "name": "net/ixgbe: improvements to ixgbe driver", "version": 1, "mbox": "http://patches.dpdk.org/series/8112/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64638/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/64638/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 199D1A04FD;\n\tTue, 14 Jan 2020 12:30:00 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1435D1C1EB;\n\tTue, 14 Jan 2020 12:29:56 +0100 (CET)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by dpdk.org (Postfix) with ESMTP id 592CB1C1E9\n for <dev@dpdk.org>; Tue, 14 Jan 2020 12:29:54 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 14 Jan 2020 03:29:54 -0800", "from silpixa00400214.ir.intel.com (HELO\n silpixa00400214.ger.corp.intel.com) ([10.237.222.119])\n by fmsmga001.fm.intel.com with ESMTP; 14 Jan 2020 03:29:53 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,432,1571727600\"; d=\"scan'208\";a=\"248238836\"", "From": "Reshma Pattan <reshma.pattan@intel.com>", "To": "dev@dpdk.org", "Cc": "Reshma Pattan <reshma.pattan@intel.com>", "Date": "Tue, 14 Jan 2020 11:29:41 +0000", "Message-Id": "<20200114112945.39375-2-reshma.pattan@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20200114112945.39375-1-reshma.pattan@intel.com>", "References": "<20200114112945.39375-1-reshma.pattan@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/5] net/ixgbe: remove ixgbe vector config flag", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "CONFIG_RTE_IXGBE_INC_VECTOR is enabled by default, so remove\nit and use architecture specific flags.\n\nSigned-off-by: Reshma Pattan <reshma.pattan@intel.com>\n---\n config/common_base | 1 -\n doc/guides/nics/ixgbe.rst | 1 -\n drivers/net/ixgbe/Makefile | 6 +++---\n drivers/net/ixgbe/ixgbe_rxtx.c | 17 ++++++++---------\n drivers/net/ixgbe/ixgbe_rxtx.h | 9 ++++-----\n drivers/net/ixgbe/meson.build | 1 -\n 6 files changed, 15 insertions(+), 20 deletions(-)", "diff": "diff --git a/config/common_base b/config/common_base\nindex 7dec7ed45..999582b0a 100644\n--- a/config/common_base\n+++ b/config/common_base\n@@ -295,7 +295,6 @@ CONFIG_RTE_LIBRTE_IXGBE_DEBUG_RX=n\n CONFIG_RTE_LIBRTE_IXGBE_DEBUG_TX=n\n CONFIG_RTE_LIBRTE_IXGBE_DEBUG_TX_FREE=n\n CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=n\n-CONFIG_RTE_IXGBE_INC_VECTOR=y\n CONFIG_RTE_LIBRTE_IXGBE_BYPASS=n\n \n #\ndiff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst\nindex 5c3a7e4f2..1f424b38a 100644\n--- a/doc/guides/nics/ixgbe.rst\n+++ b/doc/guides/nics/ixgbe.rst\n@@ -15,7 +15,6 @@ There is no change to PMD API. The RX/TX handler are the only two entries for vP\n They are transparently registered at runtime RX/TX execution if all condition checks pass.\n \n 1. To date, only an SSE version of IX GBE vPMD is available.\n- To ensure that vPMD is in the binary code, ensure that the option CONFIG_RTE_IXGBE_INC_VECTOR=y is in the configure file.\n \n Some constraints apply as pre-conditions for specific optimizations on bulk packet transfers.\n The following sections explain RX and TX constraints in the vPMD.\ndiff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile\nindex 85762e2f2..8b9d51f75 100644\n--- a/drivers/net/ixgbe/Makefile\n+++ b/drivers/net/ixgbe/Makefile\n@@ -89,9 +89,9 @@ SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_fdir.c\n SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_pf.c\n SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_flow.c\n ifeq ($(CONFIG_RTE_ARCH_ARM64),y)\n-SRCS-$(CONFIG_RTE_IXGBE_INC_VECTOR) += ixgbe_rxtx_vec_neon.c\n-else\n-SRCS-$(CONFIG_RTE_IXGBE_INC_VECTOR) += ixgbe_rxtx_vec_sse.c\n+SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_rxtx_vec_neon.c\n+else ifeq ($(CONFIG_RTE_ARCH_X86),y)\n+SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_rxtx_vec_sse.c\n endif\n ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_BYPASS),y)\n SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_bypass.c\ndiff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c\nindex fa572d184..06617a47a 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx.c\n@@ -87,7 +87,7 @@\n #define rte_ixgbe_prefetch(p) do {} while (0)\n #endif\n \n-#ifdef RTE_IXGBE_INC_VECTOR\n+#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)\n uint16_t ixgbe_xmit_fixed_burst_vec(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\t\t uint16_t nb_pkts);\n #endif\n@@ -344,7 +344,7 @@ ixgbe_xmit_pkts_simple(void *tx_queue, struct rte_mbuf **tx_pkts,\n \treturn nb_tx;\n }\n \n-#ifdef RTE_IXGBE_INC_VECTOR\n+#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)\n static uint16_t\n ixgbe_xmit_pkts_vec(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t uint16_t nb_pkts)\n@@ -2392,7 +2392,7 @@ ixgbe_set_tx_function(struct rte_eth_dev *dev, struct ixgbe_tx_queue *txq)\n \t\t\t(txq->tx_rs_thresh >= RTE_PMD_IXGBE_TX_MAX_BURST)) {\n \t\tPMD_INIT_LOG(DEBUG, \"Using simple tx code path\");\n \t\tdev->tx_pkt_prepare = NULL;\n-#ifdef RTE_IXGBE_INC_VECTOR\n+#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)\n \t\tif (txq->tx_rs_thresh <= RTE_IXGBE_TX_MAX_FREE_BUF_SZ &&\n \t\t\t\t(rte_eal_process_type() != RTE_PROC_PRIMARY ||\n \t\t\t\t\tixgbe_txq_vec_setup(txq) == 0)) {\n@@ -2687,7 +2687,7 @@ ixgbe_rx_queue_release_mbufs(struct ixgbe_rx_queue *rxq)\n {\n \tunsigned i;\n \n-#ifdef RTE_IXGBE_INC_VECTOR\n+#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)\n \t/* SSE Vector driver has a different way of releasing mbufs. */\n \tif (rxq->rx_using_sse) {\n \t\tixgbe_rx_queue_release_mbufs_vec(rxq);\n@@ -2825,7 +2825,7 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter *adapter, struct ixgbe_rx_queue *rxq)\n \trxq->pkt_first_seg = NULL;\n \trxq->pkt_last_seg = NULL;\n \n-#ifdef RTE_IXGBE_INC_VECTOR\n+#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)\n \trxq->rxrearm_start = 0;\n \trxq->rxrearm_nb = 0;\n #endif\n@@ -3139,7 +3139,7 @@ ixgbe_dev_rx_descriptor_status(void *rx_queue, uint16_t offset)\n \tif (unlikely(offset >= rxq->nb_rx_desc))\n \t\treturn -EINVAL;\n \n-#ifdef RTE_IXGBE_INC_VECTOR\n+#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)\n \tif (rxq->rx_using_sse)\n \t\tnb_hold = rxq->rxrearm_nb;\n \telse\n@@ -4638,8 +4638,7 @@ ixgbe_set_rx_function(struct rte_eth_dev *dev)\n \tif (ixgbe_rx_vec_dev_conf_condition_check(dev) ||\n \t !adapter->rx_bulk_alloc_allowed) {\n \t\tPMD_INIT_LOG(DEBUG, \"Port[%d] doesn't meet Vector Rx \"\n-\t\t\t\t \"preconditions or RTE_IXGBE_INC_VECTOR is \"\n-\t\t\t\t \"not enabled\",\n+\t\t\t\t \"preconditions\",\n \t\t\t dev->data->port_id);\n \n \t\tadapter->rx_vec_allowed = false;\n@@ -5809,7 +5808,7 @@ ixgbe_config_rss_filter(struct rte_eth_dev *dev,\n \treturn 0;\n }\n \n-/* Stubs needed for linkage when CONFIG_RTE_IXGBE_INC_VECTOR is set to 'n' */\n+/* Stubs needed for linkage for ppc arch */\n __rte_weak int\n ixgbe_rx_vec_dev_conf_condition_check(struct rte_eth_dev __rte_unused *dev)\n {\ndiff --git a/drivers/net/ixgbe/ixgbe_rxtx.h b/drivers/net/ixgbe/ixgbe_rxtx.h\nindex 505d344b9..5c9aa0f9d 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx.h\n+++ b/drivers/net/ixgbe/ixgbe_rxtx.h\n@@ -33,7 +33,7 @@\n \n #define RTE_IXGBE_DESCS_PER_LOOP 4\n \n-#ifdef RTE_IXGBE_INC_VECTOR\n+#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)\n #define RTE_IXGBE_RXQ_REARM_THRESH 32\n #define RTE_IXGBE_MAX_RX_BURST RTE_IXGBE_RXQ_REARM_THRESH\n #endif\n@@ -115,7 +115,7 @@ struct ixgbe_rx_queue {\n \tuint8_t using_ipsec;\n \t/**< indicates that IPsec RX feature is in use */\n #endif\n-#ifdef RTE_IXGBE_INC_VECTOR\n+#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)\n \tuint16_t rxrearm_nb; /**< number of remaining to be re-armed */\n \tuint16_t rxrearm_start; /**< the idx we start the re-arming from */\n #endif\n@@ -288,12 +288,11 @@ void ixgbe_rx_queue_release_mbufs_vec(struct ixgbe_rx_queue *rxq);\n extern const uint32_t ptype_table[IXGBE_PACKET_TYPE_MAX];\n extern const uint32_t ptype_table_tn[IXGBE_PACKET_TYPE_TN_MAX];\n \n-#ifdef RTE_IXGBE_INC_VECTOR\n-\n+#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)\n uint16_t ixgbe_xmit_fixed_burst_vec(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\t\t uint16_t nb_pkts);\n int ixgbe_txq_vec_setup(struct ixgbe_tx_queue *txq);\n-#endif /* RTE_IXGBE_INC_VECTOR */\n+#endif\n \n uint64_t ixgbe_get_tx_port_offloads(struct rte_eth_dev *dev);\n uint64_t ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev);\ndiff --git a/drivers/net/ixgbe/meson.build b/drivers/net/ixgbe/meson.build\nindex 1b0f6d1ef..6667af634 100644\n--- a/drivers/net/ixgbe/meson.build\n+++ b/drivers/net/ixgbe/meson.build\n@@ -25,7 +25,6 @@ sources = files(\n deps += ['hash', 'security']\n \n if arch_subdir == 'x86'\n-\tdpdk_conf.set('RTE_IXGBE_INC_VECTOR', 1)\n \tsources += files('ixgbe_rxtx_vec_sse.c')\n endif\n \n", "prefixes": [ "1/5" ] }