Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64607/?format=api
{ "id": 64607, "url": "http://patches.dpdk.org/api/patches/64607/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200114051435.46093-8-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200114051435.46093-8-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200114051435.46093-8-ajit.khaparde@broadcom.com", "date": "2020-01-14T05:14:32", "name": "[v3,07/10] net/bnxt: fix a memory leak in port stop", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "552918590a68b3c8dc82df5f41e54349dfd200b5", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200114051435.46093-8-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 8097, "url": "http://patches.dpdk.org/api/series/8097/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8097", "date": "2020-01-14T05:14:25", "name": "bnxt patchset with bug fixes", "version": 3, "mbox": "http://patches.dpdk.org/series/8097/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64607/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/64607/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 78A06A04FD;\n\tTue, 14 Jan 2020 06:17:20 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 279A91C2F8;\n\tTue, 14 Jan 2020 06:16:44 +0100 (CET)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id C379A1C2AD\n for <dev@dpdk.org>; Tue, 14 Jan 2020 06:16:33 +0100 (CET)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n [10.75.242.48])\n by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 348C530C55C;\n Mon, 13 Jan 2020 21:10:22 -0800 (PST)", "from localhost.localdomain (unknown [10.230.30.124])\n by mail-irv-17.broadcom.com (Postfix) with ESMTP id AB5E614008D;\n Mon, 13 Jan 2020 21:16:32 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 348C530C55C", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1578978622;\n bh=EGJ5s30g6MnYl2VCGaQfiiYRTFwIBHjsR227gM27G4k=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=vdQWKgh9lOlcxMqulnCiUxLKguLJqdcYH7mnISU54za/1pjaNG/nCmOV0tI12vbEU\n 0ki3Ib7FXgKeKqd5InYXX7cBbu4KfJmgF7Isum4o8wXZMyewwEoKVV8vFxpHzy640y\n E6FOXvrlATg0/5ayTSPfzPqGDD31t2yv/+Q0vHm8=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tKalesh AP <kalesh-anakkur.purayil@broadcom.com>", "Date": "Mon, 13 Jan 2020 21:14:32 -0800", "Message-Id": "<20200114051435.46093-8-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.0 (Apple Git-122.2)", "In-Reply-To": "<20200114051435.46093-1-ajit.khaparde@broadcom.com>", "References": "<20200113050118.28719-1-kalesh-anakkur.purayil@broadcom.com>\n <20200114051435.46093-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 07/10] net/bnxt: fix a memory leak in port stop", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nThe memory for mark table is allocated during port start.\nBut the allocated memory is freed only during port close\nor driver unload which in turn causes a memory leakage\non each port start/stop.\n\nFixed it by moving the memory free to port stop.\n\nFixes: a968a9f5456d (\"net/bnxt: add support for flow mark action\")\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 436ecbb84..26614186f 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -970,7 +970,10 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)\n \tbnxt_int_handler(eth_dev);\n \tbnxt_shutdown_nic(bp);\n \tbnxt_hwrm_if_change(bp, 0);\n-\tmemset(bp->mark_table, 0, BNXT_MARK_TABLE_SZ);\n+\n+\trte_free(bp->mark_table);\n+\tbp->mark_table = NULL;\n+\n \tbp->flags &= ~BNXT_FLAG_RX_VECTOR_PKT_MODE;\n \tbp->dev_stopped = 1;\n \tbp->rx_cosq_cnt = 0;\n@@ -992,9 +995,6 @@ static void bnxt_dev_close_op(struct rte_eth_dev *eth_dev)\n \t\tbp->grp_info = NULL;\n \t}\n \n-\trte_free(bp->mark_table);\n-\tbp->mark_table = NULL;\n-\n \tbnxt_dev_uninit(eth_dev);\n }\n \n", "prefixes": [ "v3", "07/10" ] }