Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64604/?format=api
http://patches.dpdk.org/api/patches/64604/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200114051435.46093-3-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200114051435.46093-3-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200114051435.46093-3-ajit.khaparde@broadcom.com", "date": "2020-01-14T05:14:27", "name": "[v3,02/10] net/bnxt: fix probe failure in FreeBSD", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "434083e377d742b4b61880d918365fd354e423f5", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200114051435.46093-3-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 8097, "url": "http://patches.dpdk.org/api/series/8097/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8097", "date": "2020-01-14T05:14:25", "name": "bnxt patchset with bug fixes", "version": 3, "mbox": "http://patches.dpdk.org/series/8097/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64604/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/64604/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2FDE8A04FD;\n\tTue, 14 Jan 2020 06:16:52 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B0CEA1C2DA;\n\tTue, 14 Jan 2020 06:16:38 +0100 (CET)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id CB9BD1C2AF\n for <dev@dpdk.org>; Tue, 14 Jan 2020 06:16:32 +0100 (CET)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n [10.75.242.48])\n by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 3395630C54A;\n Mon, 13 Jan 2020 21:10:21 -0800 (PST)", "from localhost.localdomain (unknown [10.230.30.124])\n by mail-irv-17.broadcom.com (Postfix) with ESMTP id 4C23214008E;\n Mon, 13 Jan 2020 21:16:31 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 3395630C54A", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1578978621;\n bh=P1Nd9yDJ7VpUCtFtvD8byX0SN1kmslrxXjA5PA8kNp4=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=d951pYAGl2RT/i3Sv2WbQgcR8kRZ+21GZ21F6dfSxrlpg6WgMGNLEA2nCNmTi925V\n z+xB59DbrHfcLAY3CA1ejh01zcTr/JPDmXnWOh8sYRi5z3x+vvgzz9YjY5C+NJl4ok\n +pAv80Qvo+i28bbNfjjJyMf5OBRqOcdLT0QlJ+IA=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>", "Date": "Mon, 13 Jan 2020 21:14:27 -0800", "Message-Id": "<20200114051435.46093-3-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.0 (Apple Git-122.2)", "In-Reply-To": "<20200114051435.46093-1-ajit.khaparde@broadcom.com>", "References": "<20200113050118.28719-1-kalesh-anakkur.purayil@broadcom.com>\n <20200114051435.46093-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 02/10] net/bnxt: fix probe failure in FreeBSD", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nIn FreeBSD environment, nic_uio driver does not support interrupts\nand rte_intr_callback_register() will fail to register interrupts\nwhich in turn causes bnxt driver probe failure.\n\nFixed driver to ignore interrupt callback failures in FreeBSD.\nAlso fixed to not use a dedicated completion ring for async events\nfrom FW and process these events on RXQ0 in FreeBSD.\n\nFixes: 6de4c538b393 (\"net/bnxt: fix error handling in port start\")\nFixes: 43f78b380f89 (\"net/bnxt: retry IRQ callback deregistration\")\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 8 ++++++++\n drivers/net/bnxt/bnxt_ethdev.c | 3 +++\n drivers/net/bnxt/bnxt_irq.c | 8 ++++++++\n 3 files changed, 19 insertions(+)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex 21ca059b8..3487b917e 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -117,6 +117,14 @@\n #define BNXT_NUM_ASYNC_CPR(bp) 1\n #endif\n \n+/* In FreeBSD OS, nic_uio driver does not support interrupts */\n+#ifdef RTE_EXEC_ENV_FREEBSD\n+#ifdef BNXT_NUM_ASYNC_CPR\n+#undef BNXT_NUM_ASYNC_CPR\n+#endif\n+#define BNXT_NUM_ASYNC_CPR(bp)\t0\n+#endif\n+\n #define BNXT_MISC_VEC_ID RTE_INTR_VEC_ZERO_OFFSET\n #define BNXT_RX_VEC_START RTE_INTR_VEC_RXTX_OFFSET\n \ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 7b5df9ac1..879ea580f 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -439,8 +439,11 @@ static int bnxt_init_chip(struct bnxt *bp)\n \n \t/* enable uio/vfio intr/eventfd mapping */\n \trc = rte_intr_enable(intr_handle);\n+#ifndef RTE_EXEC_ENV_FREEBSD\n+\t/* In FreeBSD OS, nic_uio driver does not support interrupts */\n \tif (rc)\n \t\tgoto err_free;\n+#endif\n \n \trc = bnxt_get_hwrm_link_config(bp, &new);\n \tif (rc) {\ndiff --git a/drivers/net/bnxt/bnxt_irq.c b/drivers/net/bnxt/bnxt_irq.c\nindex 846325ea9..40e1b0c98 100644\n--- a/drivers/net/bnxt/bnxt_irq.c\n+++ b/drivers/net/bnxt/bnxt_irq.c\n@@ -181,5 +181,13 @@ int bnxt_request_int(struct bnxt *bp)\n \t\t\tirq->requested = 1;\n \t}\n \n+#ifdef RTE_EXEC_ENV_FREEBSD\n+\t/**\n+\t * In FreeBSD OS, nic_uio does not support interrupts and\n+\t * interrupt register callback will fail.\n+\t */\n+\trc = 0;\n+#endif\n+\n \treturn rc;\n }\n", "prefixes": [ "v3", "02/10" ] }{ "id": 64604, "url": "