Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64567/?format=api
{ "id": 64567, "url": "http://patches.dpdk.org/api/patches/64567/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200113172518.37815-2-honnappa.nagarahalli@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200113172518.37815-2-honnappa.nagarahalli@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200113172518.37815-2-honnappa.nagarahalli@arm.com", "date": "2020-01-13T17:25:13", "name": "[v8,1/6] test/ring: use division for cycle count calculation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "497c6d635348396db0c7b83aabf5e78f033f43b7", "submitter": { "id": 1045, "url": "http://patches.dpdk.org/api/people/1045/?format=api", "name": "Honnappa Nagarahalli", "email": "honnappa.nagarahalli@arm.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200113172518.37815-2-honnappa.nagarahalli@arm.com/mbox/", "series": [ { "id": 8086, "url": "http://patches.dpdk.org/api/series/8086/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8086", "date": "2020-01-13T17:25:12", "name": "lib/ring: APIs to support custom element size", "version": 8, "mbox": "http://patches.dpdk.org/series/8086/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64567/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/64567/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 70F29A04F1;\n\tMon, 13 Jan 2020 18:25:45 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 01F4B1D170;\n\tMon, 13 Jan 2020 18:25:41 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 0ADE51D16E\n for <dev@dpdk.org>; Mon, 13 Jan 2020 18:25:40 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7C93411B3;\n Mon, 13 Jan 2020 09:25:39 -0800 (PST)", "from qc2400f-1.austin.arm.com (qc2400f-1.austin.arm.com\n [10.118.14.48])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6A2D73F534;\n Mon, 13 Jan 2020 09:25:39 -0800 (PST)" ], "From": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>", "To": "olivier.matz@6wind.com, sthemmin@microsoft.com, jerinj@marvell.com,\n bruce.richardson@intel.com, david.marchand@redhat.com,\n pbhagavatula@marvell.com, konstantin.ananyev@intel.com,\n honnappa.nagarahalli@arm.com", "Cc": "dev@dpdk.org, dharmik.thakkar@arm.com, ruifeng.wang@arm.com,\n gavin.hu@arm.com, nd@arm.com", "Date": "Mon, 13 Jan 2020 11:25:13 -0600", "Message-Id": "<20200113172518.37815-2-honnappa.nagarahalli@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200113172518.37815-1-honnappa.nagarahalli@arm.com>", "References": "<20190906190510.11146-1-honnappa.nagarahalli@arm.com>\n <20200113172518.37815-1-honnappa.nagarahalli@arm.com>", "Subject": "[dpdk-dev] [PATCH v8 1/6] test/ring: use division for cycle count\n\tcalculation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Use division instead of modulo operation to calculate more\naccurate cycle count.\n\nSigned-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nAcked-by: Olivier Matz <olivier.matz@6wind.com>\n---\n app/test/test_ring_perf.c | 22 ++++++++++++----------\n 1 file changed, 12 insertions(+), 10 deletions(-)", "diff": "diff --git a/app/test/test_ring_perf.c b/app/test/test_ring_perf.c\nindex 70ee46ffe..6c2aca483 100644\n--- a/app/test/test_ring_perf.c\n+++ b/app/test/test_ring_perf.c\n@@ -357,10 +357,10 @@ test_single_enqueue_dequeue(struct rte_ring *r)\n \t}\n \tconst uint64_t mc_end = rte_rdtsc();\n \n-\tprintf(\"SP/SC single enq/dequeue: %\"PRIu64\"\\n\",\n-\t\t\t(sc_end-sc_start) >> iter_shift);\n-\tprintf(\"MP/MC single enq/dequeue: %\"PRIu64\"\\n\",\n-\t\t\t(mc_end-mc_start) >> iter_shift);\n+\tprintf(\"SP/SC single enq/dequeue: %.2F\\n\",\n+\t\t\t((double)(sc_end-sc_start)) / iterations);\n+\tprintf(\"MP/MC single enq/dequeue: %.2F\\n\",\n+\t\t\t((double)(mc_end-mc_start)) / iterations);\n }\n \n /*\n@@ -395,13 +395,15 @@ test_burst_enqueue_dequeue(struct rte_ring *r)\n \t\t}\n \t\tconst uint64_t mc_end = rte_rdtsc();\n \n-\t\tuint64_t mc_avg = ((mc_end-mc_start) >> iter_shift) / bulk_sizes[sz];\n-\t\tuint64_t sc_avg = ((sc_end-sc_start) >> iter_shift) / bulk_sizes[sz];\n+\t\tdouble mc_avg = ((double)(mc_end-mc_start) / iterations) /\n+\t\t\t\t\tbulk_sizes[sz];\n+\t\tdouble sc_avg = ((double)(sc_end-sc_start) / iterations) /\n+\t\t\t\t\tbulk_sizes[sz];\n \n-\t\tprintf(\"SP/SC burst enq/dequeue (size: %u): %\"PRIu64\"\\n\", bulk_sizes[sz],\n-\t\t\t\tsc_avg);\n-\t\tprintf(\"MP/MC burst enq/dequeue (size: %u): %\"PRIu64\"\\n\", bulk_sizes[sz],\n-\t\t\t\tmc_avg);\n+\t\tprintf(\"SP/SC burst enq/dequeue (size: %u): %.2F\\n\",\n+\t\t\t\tbulk_sizes[sz], sc_avg);\n+\t\tprintf(\"MP/MC burst enq/dequeue (size: %u): %.2F\\n\",\n+\t\t\t\tbulk_sizes[sz], mc_avg);\n \t}\n }\n \n", "prefixes": [ "v8", "1/6" ] }