Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64540/?format=api
{ "id": 64540, "url": "http://patches.dpdk.org/api/patches/64540/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200113082221.80234-1-haiyue.wang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200113082221.80234-1-haiyue.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200113082221.80234-1-haiyue.wang@intel.com", "date": "2020-01-13T08:22:21", "name": "[v4] net/ice: use the copy API to do MAC assignment", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f7af537a7bb4ec42677f0250a74c291e7cc4f473", "submitter": { "id": 1044, "url": "http://patches.dpdk.org/api/people/1044/?format=api", "name": "Wang, Haiyue", "email": "haiyue.wang@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200113082221.80234-1-haiyue.wang@intel.com/mbox/", "series": [ { "id": 8076, "url": "http://patches.dpdk.org/api/series/8076/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8076", "date": "2020-01-13T08:22:21", "name": "[v4] net/ice: use the copy API to do MAC assignment", "version": 4, "mbox": "http://patches.dpdk.org/series/8076/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64540/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/64540/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 86BC9A04F0;\n\tMon, 13 Jan 2020 09:29:18 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 89A3D1BE81;\n\tMon, 13 Jan 2020 09:29:16 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id 919891D5E2;\n Mon, 13 Jan 2020 09:29:14 +0100 (CET)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 13 Jan 2020 00:29:13 -0800", "from npg-dpdk-haiyue-1.sh.intel.com ([10.67.119.213])\n by fmsmga006.fm.intel.com with ESMTP; 13 Jan 2020 00:29:12 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,428,1571727600\"; d=\"scan'208\";a=\"424243070\"", "From": "Haiyue Wang <haiyue.wang@intel.com>", "To": "dev@dpdk.org, stephen@networkplumber.org, qi.z.zhang@intel.com,\n qiming.yang@intel.com, xiaolong.ye@intel.com", "Cc": "Haiyue Wang <haiyue.wang@intel.com>,\n\tstable@dpdk.org", "Date": "Mon, 13 Jan 2020 16:22:21 +0800", "Message-Id": "<20200113082221.80234-1-haiyue.wang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200102071457.106137-1-haiyue.wang@intel.com>", "References": "<20200102071457.106137-1-haiyue.wang@intel.com>", "Subject": "[dpdk-dev] [PATCH v4] net/ice: use the copy API to do MAC assignment", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Use the API rte_ether_addr_copy to do MAC assignment, instead of\ncalling rte_memcpy function directly.\n\nFixes: 84dc7a95a2d3 (\"net/ice: enable flow director engine\")\nCc: stable@dpdk.org\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\nAcked-by: Qiming Yang <qiming.yang@intel.com>\n---\nv4: update the fix tags\n\nv3: Update the commit message\n\nv2: Update the commit title and message, use the rte_ether_addr_copy API\n instead of just changing the length definition to make code style clean.\n\n drivers/net/ice/ice_ethdev.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 88cd90660..6b344cb6e 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -875,7 +875,7 @@ ice_add_mac_filter(struct ice_vsi *vsi, struct rte_ether_addr *mac_addr)\n \t\tret = -ENOMEM;\n \t\tgoto DONE;\n \t}\n-\trte_memcpy(&f->mac_info.mac_addr, mac_addr, ETH_ADDR_LEN);\n+\trte_ether_addr_copy(mac_addr, &f->mac_info.mac_addr);\n \tTAILQ_INSERT_TAIL(&vsi->mac_list, f, next);\n \tvsi->mac_num++;\n \n@@ -1663,16 +1663,16 @@ ice_setup_vsi(struct ice_pf *pf, enum ice_vsi_type type)\n \n \tif (type == ICE_VSI_PF) {\n \t\t/* MAC configuration */\n-\t\trte_memcpy(pf->dev_addr.addr_bytes,\n-\t\t\t hw->port_info->mac.perm_addr,\n-\t\t\t ETH_ADDR_LEN);\n+\t\trte_ether_addr_copy((struct rte_ether_addr *)\n+\t\t\t\t\thw->port_info->mac.perm_addr,\n+\t\t\t\t &pf->dev_addr);\n \n-\t\trte_memcpy(&mac_addr, &pf->dev_addr, RTE_ETHER_ADDR_LEN);\n+\t\trte_ether_addr_copy(&pf->dev_addr, &mac_addr);\n \t\tret = ice_add_mac_filter(vsi, &mac_addr);\n \t\tif (ret != ICE_SUCCESS)\n \t\t\tPMD_INIT_LOG(ERR, \"Failed to add dflt MAC filter\");\n \n-\t\trte_memcpy(&mac_addr, &broadcast, RTE_ETHER_ADDR_LEN);\n+\t\trte_ether_addr_copy(&broadcast, &mac_addr);\n \t\tret = ice_add_mac_filter(vsi, &mac_addr);\n \t\tif (ret != ICE_SUCCESS)\n \t\t\tPMD_INIT_LOG(ERR, \"Failed to add MAC filter\");\n@@ -3270,7 +3270,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev,\n \t\tPMD_DRV_LOG(ERR, \"Failed to add mac filter\");\n \t\treturn -EIO;\n \t}\n-\tmemcpy(&pf->dev_addr, mac_addr, ETH_ADDR_LEN);\n+\trte_ether_addr_copy(mac_addr, &pf->dev_addr);\n \n \tflags = ICE_AQC_MAN_MAC_UPDATE_LAA_WOL;\n \tret = ice_aq_manage_mac_write(hw, mac_addr->addr_bytes, flags, NULL);\n", "prefixes": [ "v4" ] }