Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64539/?format=api
{ "id": 64539, "url": "http://patches.dpdk.org/api/patches/64539/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1578901231-16920-1-git-send-email-wangyunjian@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1578901231-16920-1-git-send-email-wangyunjian@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1578901231-16920-1-git-send-email-wangyunjian@huawei.com", "date": "2020-01-13T07:40:31", "name": "[v3] net/virtio-user: fix return value of tap offload sets not checked", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2d27f60b76249127f6ab1279241c4e58f8e7d935", "submitter": { "id": 551, "url": "http://patches.dpdk.org/api/people/551/?format=api", "name": "Yunjian Wang", "email": "wangyunjian@huawei.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1578901231-16920-1-git-send-email-wangyunjian@huawei.com/mbox/", "series": [ { "id": 8075, "url": "http://patches.dpdk.org/api/series/8075/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8075", "date": "2020-01-13T07:40:31", "name": "[v3] net/virtio-user: fix return value of tap offload sets not checked", "version": 3, "mbox": "http://patches.dpdk.org/series/8075/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64539/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/64539/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B4CE4A04F0;\n\tMon, 13 Jan 2020 08:40:45 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4018A1D58D;\n\tMon, 13 Jan 2020 08:40:45 +0100 (CET)", "from huawei.com (szxga04-in.huawei.com [45.249.212.190])\n by dpdk.org (Postfix) with ESMTP id 3E76A1D558;\n Mon, 13 Jan 2020 08:40:44 +0100 (CET)", "from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58])\n by Forcepoint Email with ESMTP id C50AE352E8D4F819F2C8;\n Mon, 13 Jan 2020 15:40:42 +0800 (CST)", "from localhost (10.133.209.164) by DGGEMS408-HUB.china.huawei.com\n (10.3.19.208) with Microsoft SMTP Server id 14.3.439.0; Mon, 13 Jan 2020\n 15:40:35 +0800" ], "From": "Yunjian Wang <wangyunjian@huawei.com>", "To": "<dev@dpdk.org>, <tiwei.bie@intel.com>, <maxime.coquelin@redhat.com>,\n <zhihong.wang@intel.com>", "CC": "<xudingke@huawei.com>, Yunjian Wang <wangyunjian@huawei.com>,\n <stable@dpdk.org>", "Date": "Mon, 13 Jan 2020 15:40:31 +0800", "Message-ID": "<1578901231-16920-1-git-send-email-wangyunjian@huawei.com>", "X-Mailer": "git-send-email 1.9.5.msysgit.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.133.209.164]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v3] net/virtio-user: fix return value of tap\n\toffload sets not checked", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The function vhost_kernel_tap_set_offload() could return errors,\nthe return value need to be checked. And there is no need to fail\nwhen error is -ENOTSUP.\n\nFixes: 1db4d2330bc8 (\"net/virtio-user: check negotiated features before set\")\nCc: stable@dpdk.org\n\nSigned-off-by: Yunjian Wang <wangyunjian@huawei.com>\n---\nv3:\n * Fix return value check incorrectly in v2\nv2:\n * No need to fail when error is -ENOTSUP.\n---\n drivers/net/virtio/virtio_user/vhost_kernel_tap.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user/vhost_kernel_tap.c b/drivers/net/virtio/virtio_user/vhost_kernel_tap.c\nindex 76bf75423..52f3ee529 100644\n--- a/drivers/net/virtio/virtio_user/vhost_kernel_tap.c\n+++ b/drivers/net/virtio/virtio_user/vhost_kernel_tap.c\n@@ -66,6 +66,7 @@ vhost_kernel_open_tap(char **p_ifname, int hdr_size, int req_mq,\n \tint sndbuf = INT_MAX;\n \tstruct ifreq ifr;\n \tint tapfd;\n+\tint ret;\n \n \t/* TODO:\n \t * 1. verify we can get/set vnet_hdr_len, tap_probe_vnet_hdr_len\n@@ -131,7 +132,9 @@ vhost_kernel_open_tap(char **p_ifname, int hdr_size, int req_mq,\n \t\tgoto error;\n \t}\n \n-\tvhost_kernel_tap_set_offload(tapfd, features);\n+\tret = vhost_kernel_tap_set_offload(tapfd, features);\n+\tif (ret < 0 && ret != -ENOTSUP)\n+\t\tgoto error;\n \n \tmemset(&ifr, 0, sizeof(ifr));\n \tifr.ifr_hwaddr.sa_family = ARPHRD_ETHER;\n", "prefixes": [ "v3" ] }