Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64474/?format=api
{ "id": 64474, "url": "http://patches.dpdk.org/api/patches/64474/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200113023949.26718-11-xiaolong.ye@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200113023949.26718-11-xiaolong.ye@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200113023949.26718-11-xiaolong.ye@intel.com", "date": "2020-01-13T02:39:22", "name": "[v4,10/36] net/i40e/base: improve AQ log granularity", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0b697a35714dc7296373d7c86f19064968fc6a96", "submitter": { "id": 1120, "url": "http://patches.dpdk.org/api/people/1120/?format=api", "name": "Xiaolong Ye", "email": "xiaolong.ye@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200113023949.26718-11-xiaolong.ye@intel.com/mbox/", "series": [ { "id": 8064, "url": "http://patches.dpdk.org/api/series/8064/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8064", "date": "2020-01-13T02:39:12", "name": "update for i40e base code", "version": 4, "mbox": "http://patches.dpdk.org/series/8064/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64474/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/64474/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 00005A04F0;\n\tMon, 13 Jan 2020 03:48:37 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 873181D5BC;\n\tMon, 13 Jan 2020 03:47:30 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by dpdk.org (Postfix) with ESMTP id D07011D581\n for <dev@dpdk.org>; Mon, 13 Jan 2020 03:47:14 +0100 (CET)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 12 Jan 2020 18:47:14 -0800", "from dpdk_yexl_af_xdp.sh.intel.com ([10.67.119.206])\n by FMSMGA003.fm.intel.com with ESMTP; 12 Jan 2020 18:47:13 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,427,1571727600\"; d=\"scan'208\";a=\"272916336\"", "From": "Xiaolong Ye <xiaolong.ye@intel.com>", "To": "Beilei Xing <beilei.xing@intel.com>,\n\tQi Zhang <qi.z.zhang@intel.com>", "Cc": "dev@dpdk.org, Xiaolong Ye <xiaolong.ye@intel.com>,\n Doug Dziggel <douglas.a.dziggel@intel.com>,\n Robert Konklewski <robertx.konklewski@intel.com>", "Date": "Mon, 13 Jan 2020 10:39:22 +0800", "Message-Id": "<20200113023949.26718-11-xiaolong.ye@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200113023949.26718-1-xiaolong.ye@intel.com>", "References": "<20191202074935.97629-1-xiaolong.ye@intel.com>\n <20200113023949.26718-1-xiaolong.ye@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 10/36] net/i40e/base: improve AQ log\n\tgranularity", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch makes it possible to log only AQ descriptors, without the\nentire AQ message buffers being dumped too. It should greatly reduce\nkernel log size in cases where a full AQ dump is not needed.\nSelection is made by setting flags in hw->debug_mask.\n\nAdditionally, some debug messages that preceded an AQ dump have been\nmoved to I40E_DEBUG_AQ_COMMAND class, which seems more appropriate.\n\nSigned-off-by: Doug Dziggel <douglas.a.dziggel@intel.com>\nSigned-off-by: Robert Konklewski <robertx.konklewski@intel.com>\nSigned-off-by: Xiaolong Ye <xiaolong.ye@intel.com>\n---\n drivers/net/i40e/base/i40e_adminq.c | 8 ++++----\n drivers/net/i40e/base/i40e_common.c | 19 ++++++++++++-------\n 2 files changed, 16 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/i40e/base/i40e_adminq.c b/drivers/net/i40e/base/i40e_adminq.c\nindex b8c6e30f5..52bea842f 100644\n--- a/drivers/net/i40e/base/i40e_adminq.c\n+++ b/drivers/net/i40e/base/i40e_adminq.c\n@@ -715,7 +715,7 @@ u16 i40e_clean_asq(struct i40e_hw *hw)\n \tdesc = I40E_ADMINQ_DESC(*asq, ntc);\n \tdetails = I40E_ADMINQ_DETAILS(*asq, ntc);\n \twhile (rd32(hw, hw->aq.asq.head) != ntc) {\n-\t\ti40e_debug(hw, I40E_DEBUG_AQ_MESSAGE,\n+\t\ti40e_debug(hw, I40E_DEBUG_AQ_COMMAND,\n \t\t\t \"ntc %d head %d.\\n\", ntc, rd32(hw, hw->aq.asq.head));\n \n \t\tif (details->callback) {\n@@ -887,7 +887,7 @@ enum i40e_status_code i40e_asq_send_command(struct i40e_hw *hw,\n \t}\n \n \t/* bump the tail */\n-\ti40e_debug(hw, I40E_DEBUG_AQ_MESSAGE, \"AQTX: desc and buffer:\\n\");\n+\ti40e_debug(hw, I40E_DEBUG_AQ_COMMAND, \"AQTX: desc and buffer:\\n\");\n \ti40e_debug_aq(hw, I40E_DEBUG_AQ_COMMAND, (void *)desc_on_ring,\n \t\t buff, buff_size);\n \t(hw->aq.asq.next_to_use)++;\n@@ -940,7 +940,7 @@ enum i40e_status_code i40e_asq_send_command(struct i40e_hw *hw,\n \t\thw->aq.asq_last_status = (enum i40e_admin_queue_err)retval;\n \t}\n \n-\ti40e_debug(hw, I40E_DEBUG_AQ_MESSAGE,\n+\ti40e_debug(hw, I40E_DEBUG_AQ_COMMAND,\n \t\t \"AQTX: desc and buffer writeback:\\n\");\n \ti40e_debug_aq(hw, I40E_DEBUG_AQ_COMMAND, (void *)desc, buff, buff_size);\n \n@@ -1069,7 +1069,7 @@ enum i40e_status_code i40e_clean_arq_element(struct i40e_hw *hw,\n \t\t\t hw->aq.arq.r.arq_bi[desc_idx].va,\n \t\t\t e->msg_len, I40E_DMA_TO_NONDMA);\n \n-\ti40e_debug(hw, I40E_DEBUG_AQ_MESSAGE, \"AQRX: desc and buffer:\\n\");\n+\ti40e_debug(hw, I40E_DEBUG_AQ_COMMAND, \"AQRX: desc and buffer:\\n\");\n \ti40e_debug_aq(hw, I40E_DEBUG_AQ_COMMAND, (void *)desc, e->msg_buf,\n \t\t hw->aq.arq_buf_size);\n \ndiff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c\nindex 73d0c29fd..4384a0795 100644\n--- a/drivers/net/i40e/base/i40e_common.c\n+++ b/drivers/net/i40e/base/i40e_common.c\n@@ -307,32 +307,37 @@ void i40e_debug_aq(struct i40e_hw *hw, enum i40e_debug_mask mask, void *desc,\n \t\t void *buffer, u16 buf_len)\n {\n \tstruct i40e_aq_desc *aq_desc = (struct i40e_aq_desc *)desc;\n+\tu32 effective_mask = hw->debug_mask & mask;\n \tu8 *buf = (u8 *)buffer;\n \tu16 len;\n-\tu16 i = 0;\n+\tu16 i;\n \n-\tif ((!(mask & hw->debug_mask)) || (desc == NULL))\n+\tif (!effective_mask || !desc)\n \t\treturn;\n \n \tlen = LE16_TO_CPU(aq_desc->datalen);\n \n-\ti40e_debug(hw, mask,\n+\ti40e_debug(hw, mask & I40E_DEBUG_AQ_DESCRIPTOR,\n \t\t \"AQ CMD: opcode 0x%04X, flags 0x%04X, datalen 0x%04X, retval 0x%04X\\n\",\n \t\t LE16_TO_CPU(aq_desc->opcode),\n \t\t LE16_TO_CPU(aq_desc->flags),\n \t\t LE16_TO_CPU(aq_desc->datalen),\n \t\t LE16_TO_CPU(aq_desc->retval));\n-\ti40e_debug(hw, mask, \"\\tcookie (h,l) 0x%08X 0x%08X\\n\",\n+\ti40e_debug(hw, mask & I40E_DEBUG_AQ_DESCRIPTOR,\n+\t\t \"\\tcookie (h,l) 0x%08X 0x%08X\\n\",\n \t\t LE32_TO_CPU(aq_desc->cookie_high),\n \t\t LE32_TO_CPU(aq_desc->cookie_low));\n-\ti40e_debug(hw, mask, \"\\tparam (0,1) 0x%08X 0x%08X\\n\",\n+\ti40e_debug(hw, mask & I40E_DEBUG_AQ_DESCRIPTOR,\n+\t\t \"\\tparam (0,1) 0x%08X 0x%08X\\n\",\n \t\t LE32_TO_CPU(aq_desc->params.internal.param0),\n \t\t LE32_TO_CPU(aq_desc->params.internal.param1));\n-\ti40e_debug(hw, mask, \"\\taddr (h,l) 0x%08X 0x%08X\\n\",\n+\ti40e_debug(hw, mask & I40E_DEBUG_AQ_DESCRIPTOR,\n+\t\t \"\\taddr (h,l) 0x%08X 0x%08X\\n\",\n \t\t LE32_TO_CPU(aq_desc->params.external.addr_high),\n \t\t LE32_TO_CPU(aq_desc->params.external.addr_low));\n \n-\tif ((buffer != NULL) && (aq_desc->datalen != 0)) {\n+\tif (buffer && (buf_len != 0) && (len != 0) &&\n+\t (effective_mask & I40E_DEBUG_AQ_DESC_BUFFER)) {\n \t\ti40e_debug(hw, mask, \"AQ CMD Buffer:\\n\");\n \t\tif (buf_len < len)\n \t\t\tlen = buf_len;\n", "prefixes": [ "v4", "10/36" ] }