Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64465/?format=api
{ "id": 64465, "url": "http://patches.dpdk.org/api/patches/64465/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200113023949.26718-2-xiaolong.ye@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200113023949.26718-2-xiaolong.ye@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200113023949.26718-2-xiaolong.ye@intel.com", "date": "2020-01-13T02:39:13", "name": "[v4,01/36] net/i40e/base: add support for feature flags", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3b0ee822eeb64140f3248a3b20109acc640bda9f", "submitter": { "id": 1120, "url": "http://patches.dpdk.org/api/people/1120/?format=api", "name": "Xiaolong Ye", "email": "xiaolong.ye@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200113023949.26718-2-xiaolong.ye@intel.com/mbox/", "series": [ { "id": 8064, "url": "http://patches.dpdk.org/api/series/8064/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8064", "date": "2020-01-13T02:39:12", "name": "update for i40e base code", "version": 4, "mbox": "http://patches.dpdk.org/series/8064/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64465/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/64465/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EDC0AA04F0;\n\tMon, 13 Jan 2020 03:47:13 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 78D9E1D583;\n\tMon, 13 Jan 2020 03:47:06 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by dpdk.org (Postfix) with ESMTP id 7E0941D574\n for <dev@dpdk.org>; Mon, 13 Jan 2020 03:47:03 +0100 (CET)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 12 Jan 2020 18:47:03 -0800", "from dpdk_yexl_af_xdp.sh.intel.com ([10.67.119.206])\n by FMSMGA003.fm.intel.com with ESMTP; 12 Jan 2020 18:47:02 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,427,1571727600\"; d=\"scan'208\";a=\"272916300\"", "From": "Xiaolong Ye <xiaolong.ye@intel.com>", "To": "Beilei Xing <beilei.xing@intel.com>,\n\tQi Zhang <qi.z.zhang@intel.com>", "Cc": "dev@dpdk.org, Xiaolong Ye <xiaolong.ye@intel.com>,\n Piotr Pietruszewski <piotr.pietruszewski@intel.com>,\n Galazka Krzysztof <krzysztof.galazka@intel.com>", "Date": "Mon, 13 Jan 2020 10:39:13 +0800", "Message-Id": "<20200113023949.26718-2-xiaolong.ye@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200113023949.26718-1-xiaolong.ye@intel.com>", "References": "<20191202074935.97629-1-xiaolong.ye@intel.com>\n <20200113023949.26718-1-xiaolong.ye@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 01/36] net/i40e/base: add support for feature\n\tflags", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Extend NVM Update API to support reporting of features\navailable for the tools.\n\nThis change is needed by NVM Update to determine if driver\nsupports changing NVM layout from structured to flat.\n\nSigned-off-by: Piotr Pietruszewski <piotr.pietruszewski@intel.com>\nSigned-off-by: Galazka Krzysztof <krzysztof.galazka@intel.com>\nSigned-off-by: Xiaolong Ye <xiaolong.ye@intel.com>\n---\n drivers/net/i40e/base/i40e_common.c | 11 ++++++++\n drivers/net/i40e/base/i40e_nvm.c | 42 ++++++++++++++++++++++++++---\n drivers/net/i40e/base/i40e_type.h | 22 +++++++++++++++\n 3 files changed, 72 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c\nindex 37911a99e..cee6de2a8 100644\n--- a/drivers/net/i40e/base/i40e_common.c\n+++ b/drivers/net/i40e/base/i40e_common.c\n@@ -1014,6 +1014,17 @@ enum i40e_status_code i40e_init_shared_code(struct i40e_hw *hw)\n \tif (hw->mac.type == I40E_MAC_X722)\n \t\thw->flags |= I40E_HW_FLAG_AQ_SRCTL_ACCESS_ENABLE |\n \t\t\t I40E_HW_FLAG_NVM_READ_REQUIRES_LOCK;\n+\t/* NVMUpdate features structure initialization */\n+\thw->nvmupd_features.major = I40E_NVMUPD_FEATURES_API_VER_MAJOR;\n+\thw->nvmupd_features.minor = I40E_NVMUPD_FEATURES_API_VER_MINOR;\n+\thw->nvmupd_features.size = sizeof(hw->nvmupd_features);\n+\ti40e_memset(hw->nvmupd_features.features, 0x0,\n+\t\t I40E_NVMUPD_FEATURES_API_FEATURES_ARRAY_LEN *\n+\t\t sizeof(*hw->nvmupd_features.features),\n+\t\t I40E_NONDMA_MEM);\n+\n+\t/* No features supported at the moment */\n+\thw->nvmupd_features.features[0] = 0;\n \n \tstatus = i40e_init_nvm(hw);\n \treturn status;\ndiff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40e_nvm.c\nindex 6c8ca8771..c8b401cdd 100644\n--- a/drivers/net/i40e/base/i40e_nvm.c\n+++ b/drivers/net/i40e/base/i40e_nvm.c\n@@ -797,6 +797,7 @@ STATIC const char *i40e_nvm_update_state_str[] = {\n \t\"I40E_NVMUPD_EXEC_AQ\",\n \t\"I40E_NVMUPD_GET_AQ_RESULT\",\n \t\"I40E_NVMUPD_GET_AQ_EVENT\",\n+\t\"I40E_NVMUPD_GET_FEATURES\",\n };\n \n /**\n@@ -859,6 +860,31 @@ enum i40e_status_code i40e_nvmupd_command(struct i40e_hw *hw,\n \t\treturn I40E_SUCCESS;\n \t}\n \n+\t/*\n+\t * A supported features request returns immediately\n+\t * rather than going into state machine\n+\t */\n+\tif (upd_cmd == I40E_NVMUPD_FEATURES) {\n+\t\tif (cmd->data_size < hw->nvmupd_features.size) {\n+\t\t\t*perrno = -EFAULT;\n+\t\t\treturn I40E_ERR_BUF_TOO_SHORT;\n+\t\t}\n+\n+\t\t/*\n+\t\t * If buffer is bigger than i40e_nvmupd_features structure,\n+\t\t * make sure the trailing bytes are set to 0x0.\n+\t\t */\n+\t\tif (cmd->data_size > hw->nvmupd_features.size)\n+\t\t\ti40e_memset(bytes + hw->nvmupd_features.size, 0x0,\n+\t\t\t\t cmd->data_size - hw->nvmupd_features.size,\n+\t\t\t\t I40E_NONDMA_MEM);\n+\n+\t\ti40e_memcpy(bytes, &hw->nvmupd_features,\n+\t\t\t hw->nvmupd_features.size, I40E_NONDMA_MEM);\n+\n+\t\treturn I40E_SUCCESS;\n+\t}\n+\n \t/* Clear status even it is not read and log */\n \tif (hw->nvmupd_state == I40E_NVMUPD_STATE_ERROR) {\n \t\ti40e_debug(hw, I40E_DEBUG_NVM,\n@@ -1325,10 +1351,20 @@ STATIC enum i40e_nvmupd_cmd i40e_nvmupd_validate_command(struct i40e_hw *hw,\n \t\t\tupd_cmd = I40E_NVMUPD_READ_SA;\n \t\t\tbreak;\n \t\tcase I40E_NVM_EXEC:\n-\t\t\tif (module == 0xf)\n-\t\t\t\tupd_cmd = I40E_NVMUPD_STATUS;\n-\t\t\telse if (module == 0)\n+\t\t\tswitch (module) {\n+\t\t\tcase I40E_NVM_EXEC_GET_AQ_RESULT:\n \t\t\t\tupd_cmd = I40E_NVMUPD_GET_AQ_RESULT;\n+\t\t\t\tbreak;\n+\t\t\tcase I40E_NVM_EXEC_FEATURES:\n+\t\t\t\tupd_cmd = I40E_NVMUPD_FEATURES;\n+\t\t\t\tbreak;\n+\t\t\tcase I40E_NVM_EXEC_STATUS:\n+\t\t\t\tupd_cmd = I40E_NVMUPD_STATUS;\n+\t\t\t\tbreak;\n+\t\t\tdefault:\n+\t\t\t\t*perrno = -EFAULT;\n+\t\t\t\treturn I40E_NVMUPD_INVALID;\n+\t\t\t}\n \t\t\tbreak;\n \t\tcase I40E_NVM_AQE:\n \t\t\tupd_cmd = I40E_NVMUPD_GET_AQ_EVENT;\ndiff --git a/drivers/net/i40e/base/i40e_type.h b/drivers/net/i40e/base/i40e_type.h\nindex 06863d772..fcdf0eb29 100644\n--- a/drivers/net/i40e/base/i40e_type.h\n+++ b/drivers/net/i40e/base/i40e_type.h\n@@ -478,6 +478,7 @@ enum i40e_nvmupd_cmd {\n \tI40E_NVMUPD_EXEC_AQ,\n \tI40E_NVMUPD_GET_AQ_RESULT,\n \tI40E_NVMUPD_GET_AQ_EVENT,\n+\tI40E_NVMUPD_FEATURES,\n };\n \n enum i40e_nvmupd_state {\n@@ -513,6 +514,10 @@ enum i40e_nvmupd_state {\n #define I40E_NVM_AQE\t\t\t\t0xe\n #define I40E_NVM_EXEC\t\t\t\t0xf\n \n+#define I40E_NVM_EXEC_GET_AQ_RESULT\t\t0x0\n+#define I40E_NVM_EXEC_FEATURES\t\t\t0xe\n+#define I40E_NVM_EXEC_STATUS\t\t\t0xf\n+\n #define I40E_NVM_ADAPT_SHIFT\t16\n #define I40E_NVM_ADAPT_MASK\t(0xffffULL << I40E_NVM_ADAPT_SHIFT)\n \n@@ -527,6 +532,20 @@ struct i40e_nvm_access {\n \tu8 data[1];\n };\n \n+/* NVMUpdate features API */\n+#define I40E_NVMUPD_FEATURES_API_VER_MAJOR\t\t0\n+#define I40E_NVMUPD_FEATURES_API_VER_MINOR\t\t14\n+#define I40E_NVMUPD_FEATURES_API_FEATURES_ARRAY_LEN\t12\n+\n+#define I40E_NVMUPD_FEATURE_FLAT_NVM_SUPPORT\t\tBIT(0)\n+\n+struct i40e_nvmupd_features {\n+\tu8 major;\n+\tu8 minor;\n+\tu16 size;\n+\tu8 features[I40E_NVMUPD_FEATURES_API_FEATURES_ARRAY_LEN];\n+};\n+\n /* (Q)SFP module access definitions */\n #define I40E_I2C_EEPROM_DEV_ADDR\t0xA0\n #define I40E_I2C_EEPROM_DEV_ADDR2\t0xA2\n@@ -730,6 +749,9 @@ struct i40e_hw {\n \tu16 first_tag;\n \tu16 second_tag;\n \n+\t/* NVMUpdate features */\n+\tstruct i40e_nvmupd_features nvmupd_features;\n+\n \t/* debug mask */\n \tu32 debug_mask;\n \tchar err_str[16];\n", "prefixes": [ "v4", "01/36" ] }