Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64377/?format=api
{ "id": 64377, "url": "http://patches.dpdk.org/api/patches/64377/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200109153112.501282-7-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200109153112.501282-7-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200109153112.501282-7-bruce.richardson@intel.com", "date": "2020-01-09T15:31:12", "name": "[v3,6/6] doc/api: reduce indentation in meson build file", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7efee425e1dbc859e6f9f203c6a8a1ff2dc7f98a", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200109153112.501282-7-bruce.richardson@intel.com/mbox/", "series": [ { "id": 8039, "url": "http://patches.dpdk.org/api/series/8039/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8039", "date": "2020-01-09T15:31:06", "name": "meson build improvements", "version": 3, "mbox": "http://patches.dpdk.org/series/8039/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64377/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/64377/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 07B1FA046B;\n\tThu, 9 Jan 2020 16:32:38 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0F62A1DED1;\n\tThu, 9 Jan 2020 16:31:52 +0100 (CET)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by dpdk.org (Postfix) with ESMTP id 2CE5A1DECE\n for <dev@dpdk.org>; Thu, 9 Jan 2020 16:31:50 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 09 Jan 2020 07:31:49 -0800", "from silpixa00399126.ir.intel.com (HELO\n silpixa00399126.ger.corp.intel.com) ([10.237.223.2])\n by orsmga008.jf.intel.com with ESMTP; 09 Jan 2020 07:31:48 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,414,1571727600\"; d=\"scan'208\";a=\"216333167\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "david.marchand@redhat.com,\n\tjohn.mcnamara@intel.com,\n\tbluca@debian.org", "Cc": "dev@dpdk.org, aconole@redhat.com, thomas@monjalon.net,\n Bruce Richardson <bruce.richardson@intel.com>", "Date": "Thu, 9 Jan 2020 15:31:12 +0000", "Message-Id": "<20200109153112.501282-7-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200109153112.501282-1-bruce.richardson@intel.com>", "References": "<20200109115631.500056-1-bruce.richardson@intel.com>\n <20200109153112.501282-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 6/6] doc/api: reduce indentation in meson\n\tbuild file", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When building the API docs, we can make the meson.build file easier to\nread, and allow more code per line, by using subdir_done() to quit early.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Aaron Conole <aconole@redhat.com>\n---\n doc/api/meson.build | 98 +++++++++++++++++++++++----------------------\n 1 file changed, 50 insertions(+), 48 deletions(-)", "diff": "diff --git a/doc/api/meson.build b/doc/api/meson.build\nindex 23a7dfc75..c72b880e1 100644\n--- a/doc/api/meson.build\n+++ b/doc/api/meson.build\n@@ -3,52 +3,54 @@\n \n doxygen = find_program('doxygen', required: get_option('enable_docs'))\n \n-if doxygen.found()\n-\t# due to the CSS customisation script, which needs to run on a file that\n-\t# is in a subdirectory that is created at build time and thus it cannot\n-\t# be an individual custom_target, we need to wrap the doxygen call in a\n-\t# script to run the CSS modification afterwards\n-\tgenerate_doxygen = find_program('generate_doxygen.sh')\n-\tgenerate_examples = find_program('generate_examples.sh')\n-\tgenerate_css = find_program('doxy-html-custom.sh')\n-\n-\tinputdir = join_paths(meson.source_root(), 'examples')\n-\thtmldir = join_paths('share', 'doc', 'dpdk')\n-\n-\t# due to the following bug: https://github.com/mesonbuild/meson/issues/4107\n-\t# if install is set to true it will override build_by_default and it will\n-\t# cause the target to always be built. If install were to be always set to\n-\t# false it would be impossible to install the docs.\n-\t# So use a configure option for now.\n-\texample = custom_target('examples.dox',\n-\t\tinput: inputdir,\n-\t\toutput: 'examples.dox',\n-\t\tcommand: [generate_examples, '@INPUT@', '@OUTPUT@'],\n-\t\tinstall: get_option('enable_docs'),\n-\t\tinstall_dir: htmldir,\n-\t\tbuild_by_default: get_option('enable_docs'))\n-\n-\tcdata = configuration_data()\n-\tcdata.set('VERSION', meson.project_version())\n-\tcdata.set('API_EXAMPLES', join_paths(meson.build_root(), 'doc', 'api', 'examples.dox'))\n-\tcdata.set('OUTPUT', join_paths(meson.build_root(), 'doc', 'api'))\n-\tcdata.set('HTML_OUTPUT', 'api')\n-\tcdata.set('TOPDIR', meson.source_root())\n-\tcdata.set('STRIP_FROM_PATH', meson.source_root())\n-\n-\tdoxy_conf = configure_file(input: 'doxy-api.conf.in',\n-\t\toutput: 'doxy-api.conf',\n-\t\tconfiguration: cdata)\n-\n-\tdoxy_build = custom_target('doxygen',\n-\t\tdepends: example,\n-\t\tinput: doxy_conf,\n-\t\toutput: 'api',\n-\t\tcommand: [generate_doxygen, '@INPUT@', '@OUTPUT@', generate_css],\n-\t\tinstall: get_option('enable_docs'),\n-\t\tinstall_dir: htmldir,\n-\t\tbuild_by_default: get_option('enable_docs'))\n-\n-\tdoc_targets += doxy_build\n-\tdoc_target_names += 'Doxygen_API'\n+if not doxygen.found()\n+ subdir_done()\n endif\n+\n+# due to the CSS customisation script, which needs to run on a file that\n+# is in a subdirectory that is created at build time and thus it cannot\n+# be an individual custom_target, we need to wrap the doxygen call in a\n+# script to run the CSS modification afterwards\n+generate_doxygen = find_program('generate_doxygen.sh')\n+generate_examples = find_program('generate_examples.sh')\n+generate_css = find_program('doxy-html-custom.sh')\n+\n+inputdir = join_paths(meson.source_root(), 'examples')\n+htmldir = join_paths('share', 'doc', 'dpdk')\n+\n+# due to the following bug: https://github.com/mesonbuild/meson/issues/4107\n+# if install is set to true it will override build_by_default and it will\n+# cause the target to always be built. If install were to be always set to\n+# false it would be impossible to install the docs.\n+# So use a configure option for now.\n+example = custom_target('examples.dox',\n+\tinput: inputdir,\n+\toutput: 'examples.dox',\n+\tcommand: [generate_examples, '@INPUT@', '@OUTPUT@'],\n+\tinstall: get_option('enable_docs'),\n+\tinstall_dir: htmldir,\n+\tbuild_by_default: get_option('enable_docs'))\n+\n+cdata = configuration_data()\n+cdata.set('VERSION', meson.project_version())\n+cdata.set('API_EXAMPLES', join_paths(meson.build_root(), 'doc', 'api', 'examples.dox'))\n+cdata.set('OUTPUT', join_paths(meson.build_root(), 'doc', 'api'))\n+cdata.set('HTML_OUTPUT', 'api')\n+cdata.set('TOPDIR', meson.source_root())\n+cdata.set('STRIP_FROM_PATH', meson.source_root())\n+\n+doxy_conf = configure_file(input: 'doxy-api.conf.in',\n+\toutput: 'doxy-api.conf',\n+\tconfiguration: cdata)\n+\n+doxy_build = custom_target('doxygen',\n+\tdepends: example,\n+\tinput: doxy_conf,\n+\toutput: 'api',\n+\tcommand: [generate_doxygen, '@INPUT@', '@OUTPUT@', generate_css],\n+\tinstall: get_option('enable_docs'),\n+\tinstall_dir: htmldir,\n+\tbuild_by_default: get_option('enable_docs'))\n+\n+doc_targets += doxy_build\n+doc_target_names += 'Doxygen_API'\n", "prefixes": [ "v3", "6/6" ] }