Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64323/?format=api
{ "id": 64323, "url": "http://patches.dpdk.org/api/patches/64323/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200109031559.63194-6-huwei013@chinasoftinc.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200109031559.63194-6-huwei013@chinasoftinc.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200109031559.63194-6-huwei013@chinasoftinc.com", "date": "2020-01-09T03:15:53", "name": "[05/11] net/hns3: add free thresh in Rx operation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1c0ca88ac42f3ae3e1fe95c95e258e8f290ea380", "submitter": { "id": 1537, "url": "http://patches.dpdk.org/api/people/1537/?format=api", "name": "Wei Hu (Xavier)", "email": "huwei013@chinasoftinc.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200109031559.63194-6-huwei013@chinasoftinc.com/mbox/", "series": [ { "id": 8023, "url": "http://patches.dpdk.org/api/series/8023/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8023", "date": "2020-01-09T03:15:48", "name": "misc updates and fixes for hns3 PMD driver", "version": 1, "mbox": "http://patches.dpdk.org/series/8023/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64323/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/64323/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5056BA04F3;\n\tThu, 9 Jan 2020 04:38:07 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 922861DB61;\n\tThu, 9 Jan 2020 04:38:06 +0100 (CET)", "from incedge.chinasoftinc.com (unknown [114.113.233.8])\n by dpdk.org (Postfix) with ESMTP id 565341DA19\n for <dev@dpdk.org>; Thu, 9 Jan 2020 04:38:04 +0100 (CET)", "from mail.chinasoftinc.com (inccas002.ito.icss [10.168.0.52]) by\n incedge.chinasoftinc.com with ESMTP id F11lQ9A1UwQXCayF (version=TLSv1\n cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO) for <dev@dpdk.org>;\n Thu, 09 Jan 2020 11:22:49 +0800 (CST)", "from localhost.localdomain (203.160.91.226) by INCCAS002.ito.icss\n (10.168.0.60) with Microsoft SMTP Server id 14.3.439.0; Thu, 9 Jan 2020\n 11:16:12 +0800" ], "X-ASG-Debug-ID": "1578539509-0a3dd116d0042b0013-TfluYd", "X-Barracuda-Envelope-From": "huwei013@chinasoftinc.com", "X-Barracuda-RBL-Trusted-Forwarder": [ "10.168.0.52", "10.168.0.60" ], "X-ASG-Whitelist": "Client", "From": "\"Wei Hu (Xavier)\" <huwei013@chinasoftinc.com>", "To": "<dev@dpdk.org>", "Date": "Thu, 9 Jan 2020 11:15:53 +0800", "X-ASG-Orig-Subj": "[PATCH 05/11] net/hns3: add free thresh in Rx operation", "Message-ID": "<20200109031559.63194-6-huwei013@chinasoftinc.com>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20200109031559.63194-1-huwei013@chinasoftinc.com>", "References": "<20200109031559.63194-1-huwei013@chinasoftinc.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[203.160.91.226]", "X-Barracuda-Connect": "inccas002.ito.icss[10.168.0.52]", "X-Barracuda-Start-Time": "1578540168", "X-Barracuda-Encrypted": "ECDHE-RSA-AES256-SHA", "X-Barracuda-URL": "https://spam.chinasoftinc.com:443/cgi-mod/mark.cgi", "X-Virus-Scanned": "by bsmtpd at chinasoftinc.com", "X-Barracuda-Scan-Msg-Size": "2566", "Subject": "[dpdk-dev] [PATCH 05/11] net/hns3: add free thresh in Rx operation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: \"Wei Hu (Xavier)\" <xavier.huwei@huawei.com>\n\nThis patch optimizes the Rx performance by adding the rx_free_thresh\nrelated process in the '.rx_pkt_burst' ops implementation function named\nhns3_recv_pkts. The related change as follows:\n1. Adding the rx_free_thresh related process to reduce the number of\n writing the HNS3_RING_RX_HEAD_REG register.\n2. Adjusting the internal macro named DEFAULT_RX_FREE_THRESH to 32 and\n adjusting HNS3_MIN_RING_DESC to 64 to make the effect of the thresh\n more obvious.\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\nSigned-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>\n---\n drivers/net/hns3/hns3_rxtx.c | 12 ++++++++++--\n drivers/net/hns3/hns3_rxtx.h | 2 +-\n 2 files changed, 11 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c\nindex a1655e246..6f74a7917 100644\n--- a/drivers/net/hns3/hns3_rxtx.c\n+++ b/drivers/net/hns3/hns3_rxtx.c\n@@ -30,7 +30,7 @@\n #include \"hns3_logs.h\"\n \n #define HNS3_CFG_DESC_NUM(num)\t((num) / 8 - 1)\n-#define DEFAULT_RX_FREE_THRESH\t16\n+#define DEFAULT_RX_FREE_THRESH\t32\n \n static void\n hns3_rx_queue_release_mbufs(struct hns3_rx_queue *rxq)\n@@ -558,6 +558,7 @@ hns3_dev_rx_queue_start(struct hns3_adapter *hns, uint16_t idx)\n \n \trxq->next_to_use = 0;\n \trxq->next_to_clean = 0;\n+\trxq->nb_rx_hold = 0;\n \thns3_init_rx_queue_hw(rxq);\n \n \treturn 0;\n@@ -572,6 +573,7 @@ hns3_fake_rx_queue_start(struct hns3_adapter *hns, uint16_t idx)\n \trxq = (struct hns3_rx_queue *)hw->fkq_data.rx_queues[idx];\n \trxq->next_to_use = 0;\n \trxq->next_to_clean = 0;\n+\trxq->nb_rx_hold = 0;\n \thns3_init_rx_queue_hw(rxq);\n }\n \n@@ -1525,7 +1527,13 @@ hns3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \trxq->next_to_clean = rx_id;\n \trxq->pkt_first_seg = first_seg;\n \trxq->pkt_last_seg = last_seg;\n-\thns3_clean_rx_buffers(rxq, nb_rx_bd);\n+\n+\tnb_rx_bd = nb_rx_bd + rxq->nb_rx_hold;\n+\tif (nb_rx_bd > rxq->rx_free_thresh) {\n+\t\thns3_clean_rx_buffers(rxq, nb_rx_bd);\n+\t\tnb_rx_bd = 0;\n+\t}\n+\trxq->nb_rx_hold = nb_rx_bd;\n \n \treturn nb_rx;\n }\ndiff --git a/drivers/net/hns3/hns3_rxtx.h b/drivers/net/hns3/hns3_rxtx.h\nindex 943c6d8bb..1c2723ffb 100644\n--- a/drivers/net/hns3/hns3_rxtx.h\n+++ b/drivers/net/hns3/hns3_rxtx.h\n@@ -5,7 +5,7 @@\n #ifndef _HNS3_RXTX_H_\n #define _HNS3_RXTX_H_\n \n-#define\tHNS3_MIN_RING_DESC\t32\n+#define\tHNS3_MIN_RING_DESC\t64\n #define\tHNS3_MAX_RING_DESC\t32768\n #define HNS3_DEFAULT_RING_DESC 1024\n #define\tHNS3_ALIGN_RING_DESC\t32\n", "prefixes": [ "05/11" ] }