Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 64288,
    "url": "http://patches.dpdk.org/api/patches/64288/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1578480070-160606-1-git-send-email-suanmingm@mellanox.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1578480070-160606-1-git-send-email-suanmingm@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1578480070-160606-1-git-send-email-suanmingm@mellanox.com",
    "date": "2020-01-08T10:41:09",
    "name": "[v2] net/mlx5: fix incorrect pointer operation in meter",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "ac9b8def5df0dd2d55c120ac8d2f2b7cc5fd8b8f",
    "submitter": {
        "id": 1358,
        "url": "http://patches.dpdk.org/api/people/1358/?format=api",
        "name": "Suanming Mou",
        "email": "suanmingm@mellanox.com"
    },
    "delegate": {
        "id": 3268,
        "url": "http://patches.dpdk.org/api/users/3268/?format=api",
        "username": "rasland",
        "first_name": "Raslan",
        "last_name": "Darawsheh",
        "email": "rasland@nvidia.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1578480070-160606-1-git-send-email-suanmingm@mellanox.com/mbox/",
    "series": [
        {
            "id": 8015,
            "url": "http://patches.dpdk.org/api/series/8015/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8015",
            "date": "2020-01-08T10:41:09",
            "name": "[v2] net/mlx5: fix incorrect pointer operation in meter",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/8015/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/64288/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/64288/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 65C41A04FA;\n\tWed,  8 Jan 2020 11:41:16 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 96B501D524;\n\tWed,  8 Jan 2020 11:41:15 +0100 (CET)",
            "from git-send-mailer.rdmz.labs.mlnx (unknown [37.142.13.130])\n by dpdk.org (Postfix) with ESMTP id 219EC1D40E;\n Wed,  8 Jan 2020 11:41:14 +0100 (CET)"
        ],
        "From": "Suanming Mou <suanmingm@mellanox.com>",
        "To": "Matan Azrad <matan@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>,\n Viacheslav Ovsiienko <viacheslavo@mellanox.com>",
        "Cc": "dev@dpdk.org, xiangxia.m.yue@gmail.com, rasland@mellanox.com,\n stable@dpdk.org",
        "Date": "Wed,  8 Jan 2020 12:41:09 +0200",
        "Message-Id": "<1578480070-160606-1-git-send-email-suanmingm@mellanox.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1578387392-114282-1-git-send-email-suanmingm@mellanox.com>",
        "References": "<1578387392-114282-1-git-send-email-suanmingm@mellanox.com>",
        "Subject": "[dpdk-dev] [PATCH v2] net/mlx5: fix incorrect pointer operation in\n\tmeter",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The meter suffix flow item pointer restore is not correct to decrease\na fixed value. The incorrect operation will cause incorrect match to\nthe meter suffix flow, the flow create will fail once the magic number\nin the wrong offset memory start with RTE_FLOW_ITEM_TYPE_END.\nThe pointer should decrease the real offset it increases.\n\nSet the decrease value to the real offset the pointer increases to fix\nthe issue.\n\nFixes: 9ea9b049a960 (\"net/mlx5: split meter flow\")\nCc: stable@dpdk.org\n\nSigned-off-by: Suanming Mou <suanmingm@mellanox.com>\nReported-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>\n---\n\nv2: commit message adjust.\n\n---\n drivers/net/mlx5/mlx5_flow.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex cb9d265..52ffcb2 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -4037,7 +4037,7 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n \t\t\tsfx_items++;\n \t\t}\n \t\tsfx_items->type = RTE_FLOW_ITEM_TYPE_END;\n-\t\tsfx_items -= METER_SUFFIX_ITEM;\n+\t\tsfx_items -= sfx_port_id_item ? 2 : 1;\n \t\t/* Setting the sfx group atrr. */\n \t\tsfx_attr.group = sfx_attr.transfer ?\n \t\t\t\t(MLX5_FLOW_TABLE_LEVEL_SUFFIX - 1) :\n",
    "prefixes": [
        "v2"
    ]
}