Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 64277,
    "url": "http://patches.dpdk.org/api/patches/64277/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200107155136.70237-1-rroldan@bequant.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200107155136.70237-1-rroldan@bequant.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200107155136.70237-1-rroldan@bequant.com",
    "date": "2020-01-07T15:51:36",
    "name": "ethdev: rte_eth_dev_callback_unregister() fails with cb_arg == -1",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "f8e94bc6283a228387215feea09785d3f78f5147",
    "submitter": {
        "id": 1557,
        "url": "http://patches.dpdk.org/api/people/1557/?format=api",
        "name": "Ricardo Roldan",
        "email": "rroldan@bequant.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200107155136.70237-1-rroldan@bequant.com/mbox/",
    "series": [
        {
            "id": 8008,
            "url": "http://patches.dpdk.org/api/series/8008/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=8008",
            "date": "2020-01-07T15:51:36",
            "name": "ethdev: rte_eth_dev_callback_unregister() fails with cb_arg == -1",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/8008/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/64277/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/64277/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EE144A04F3;\n\tTue,  7 Jan 2020 16:51:45 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9E0C51D9E9;\n\tTue,  7 Jan 2020 16:51:45 +0100 (CET)",
            "from mail-wm1-f67.google.com (mail-wm1-f67.google.com\n [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 7C4C31D9E0\n for <dev@dpdk.org>; Tue,  7 Jan 2020 16:51:44 +0100 (CET)",
            "by mail-wm1-f67.google.com with SMTP id b19so19449572wmj.4\n for <dev@dpdk.org>; Tue, 07 Jan 2020 07:51:44 -0800 (PST)",
            "from hprr.bequant.com (static-166-190-26-46.ipcom.comunitel.net.\n [46.26.190.166])\n by smtp.gmail.com with ESMTPSA id x6sm9356wmi.44.2020.01.07.07.51.43\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 07 Jan 2020 07:51:43 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=bequant-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=xcL4wD5lIL9QlOTSr/yoQHsD3EqZfE6gKi2QpdY4tm8=;\n b=M7NugrbKEkpFi3cgZW75wccGsMrh2eHH37VGuGmvDcJVCk4FGhqUaE0aPYMa1mHJa8\n zIuvKmN5j8K29JXLe7UXhjd5KvlDn2ta/7RkuCpdDNAXjWRaEztpPxUxCQuBBx/HfmOl\n qvoV8FunC+aibXuAoLS29DZ5Si7oh2+BrE3PGur6uiHBc2JYKi5AOIGJtPcVvs5bgC1p\n rjyoBaOdFnVvAnQKe0vKqbHIR/Ki8o39ONhlRoIeBAbPauJZ/EgBSTCdwvjLnyU3SQSo\n AYh0f9geqwLW/rgVsBQ/MaWadiky3He6eOm/VxEmIYk6+Gxy04Kf/QvcoV6i632IBTgX\n NXzw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=xcL4wD5lIL9QlOTSr/yoQHsD3EqZfE6gKi2QpdY4tm8=;\n b=aY6YQp8pkeIWci9VkNQTtO8eY8aQ3dsmDviomkY4OTAtaJVDYGIVw5XXPf7d5+pNXG\n 5SYBbRO7pD6moIEDIO3QQyivD1QdmA1ba1MNg+FC76rxiYOHRESqoLune+w8Hv1sIh21\n CJb9bVfXGpgGn/KTwZwYsderFkkExztXdMiEhj1j6oq2xX5f76EwLxoEZR42Wf7CIKba\n f28Dt3hZszgSIp6tYYspaE2SmBPaV8uIGm6/cLf1JpYSuJe9xvG0UEFLQc75k4DNz+6/\n h8mEe27KtjNKmPuEC0eNvrKwTqLybkRUOdBxHWT5TfmuXD2C929NKBl5UsnY74YswuS9\n Qq3A==",
        "X-Gm-Message-State": "APjAAAXwfLStsSdzacuYiraZwtNYP00rArEOz1lS4P+hhMH7+HReYnz2\n KX8YnCziEqKgIycQklsopsz1dmUoloc=",
        "X-Google-Smtp-Source": "\n APXvYqyMcFFtYNzXugIytritobPWFN79fX6GzeUUAHkVA10/VuT1wryTL6HfKesWpLUTKl/5FKEIqQ==",
        "X-Received": "by 2002:a7b:cc98:: with SMTP id\n p24mr39569101wma.139.1578412303917;\n Tue, 07 Jan 2020 07:51:43 -0800 (PST)",
        "From": "Ricardo Roldan <rroldan@bequant.com>",
        "To": "dev@dpdk.org",
        "Cc": "Ricardo Roldan <rroldan@bequant.com>",
        "Date": "Tue,  7 Jan 2020 16:51:36 +0100",
        "Message-Id": "<20200107155136.70237-1-rroldan@bequant.com>",
        "X-Mailer": "git-send-email 2.23.0",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH] ethdev: rte_eth_dev_callback_unregister() fails\n\twith cb_arg == -1",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The function was checking -1 against the callback data instead of\nthe given cb_arg parameter.\n\nSigned-off-by: Ricardo Roldan <rroldan@bequant.com>\n---\n lib/librte_ethdev/rte_ethdev.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 6e9cb243e..aec2d0f70 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -4039,7 +4039,7 @@ rte_eth_dev_callback_unregister(uint16_t port_id,\n \t\t\tnext = TAILQ_NEXT(cb, next);\n \n \t\t\tif (cb->cb_fn != cb_fn || cb->event != event ||\n-\t\t\t    (cb->cb_arg != (void *)-1 && cb->cb_arg != cb_arg))\n+\t\t\t    (cb_arg != (void *)-1 && cb->cb_arg != cb_arg))\n \t\t\t\tcontinue;\n \n \t\t\t/*\n",
    "prefixes": []
}