Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 64248,
    "url": "http://patches.dpdk.org/api/patches/64248/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200106205553.3696-1-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200106205553.3696-1-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200106205553.3696-1-stephen@networkplumber.org",
    "date": "2020-01-06T20:55:53",
    "name": "mem: fix incorrect munmap in error unwind",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "1b869fcf2d072bc9a457562dec053c4728cae16a",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200106205553.3696-1-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 7996,
            "url": "http://patches.dpdk.org/api/series/7996/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7996",
            "date": "2020-01-06T20:55:53",
            "name": "mem: fix incorrect munmap in error unwind",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/7996/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/64248/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/64248/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E5620A04F6;\n\tMon,  6 Jan 2020 21:56:07 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CFE9B1D6F9;\n\tMon,  6 Jan 2020 21:56:06 +0100 (CET)",
            "from mail-pg1-f193.google.com (mail-pg1-f193.google.com\n [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id EFEFF1D6EE\n for <dev@dpdk.org>; Mon,  6 Jan 2020 21:56:05 +0100 (CET)",
            "by mail-pg1-f193.google.com with SMTP id l24so27414417pgk.2\n for <dev@dpdk.org>; Mon, 06 Jan 2020 12:56:05 -0800 (PST)",
            "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id x132sm77652555pfc.148.2020.01.06.12.56.03\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 06 Jan 2020 12:56:03 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=JGYIgq+uwfpes47A1SXtgbwDNsKAt5Xi3KqQJ3KrWpM=;\n b=JCzs4Uz/gfQ0VvF/7sS8akRA9vXywgmVBeX1YPfDXnjtBN93zlA2zGYC9IKUZcSWXj\n sD7fGB0W0N1+ZOAbW+Pr7+y23a+1CVCo6NJLOUaCmAWSQUhviiZW+MvvZ6n88mUHKzCi\n 49uLgO10Kk70S07x+tAaKA6gRQuQES1oBPFLWjwS4KclH4I8bA48kOUSoIaIax9YKEaR\n 4daortkTroN7EtfkW4xZLbT/y1u1kydtgkmuq3a85uJgrULTnh3OsIb8s5ZJc2aX5Xs4\n 9t4VStCT/0vn6Zf+pm4ANfCqdm5022cO3LFXPSPpn6r+YSSrurJKYJWh4VLhcTXUvXXX\n Korg==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=JGYIgq+uwfpes47A1SXtgbwDNsKAt5Xi3KqQJ3KrWpM=;\n b=khsCjzZJ1R+nhO1HTT1p/xyQUuw9natULI8Us91CVP/oss2npFU7Yr1I7qAbazjo4e\n DJ5i92x62T7W91yorU0P+RFepOnliHjIEoTyG80uOsxH709vNopI0oQFLrUUG2+gEEfS\n jGT9CBi5PGa9Mt4Xmv16r/4jYsAW5N6TAI9PJSpCkmbTEdQUBqWQLTueoRzDmHcoX45m\n hvJ8mgUYax35JC/cMLUpUbI/DsqkYXNwtLf19HYv2XEZdUehsi4HtZmw5pxeGLRESebA\n HiHBfm4wePi7h8wYkU4e1ksolqBEAaBdgLq3t7H7z/osJFGpEMegbUHDgsNoqNKsb6Ze\n f1KA==",
        "X-Gm-Message-State": "APjAAAWc96/j4mHWN8MfcxT1QyA+/GJ/r383tg4p3oySiP41EElsfp0D\n UGV9bhtBVZMX0X5EDPK6piT/5bnjFZQ=",
        "X-Google-Smtp-Source": "\n APXvYqzNy5V7dJA4psrSgnUpt+sAVD9CTy43ogvGMw52BI9Go5sX7KdLWyiLvy+XCTakmDE56ZrN7w==",
        "X-Received": "by 2002:aa7:9484:: with SMTP id z4mr108776893pfk.88.1578344164513;\n Mon, 06 Jan 2020 12:56:04 -0800 (PST)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>, anatoly.burakov@intel.com,\n stable@dpdk.org",
        "Date": "Mon,  6 Jan 2020 12:55:53 -0800",
        "Message-Id": "<20200106205553.3696-1-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.20.1",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH] mem: fix incorrect munmap in error unwind",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The loop to unwind existing mmaps was only unmapping the\nfirst segment.\n\nAlso, remove obvious redundant assignment.\n\nFixes: 66cc45e293ed (\"mem: replace memseg with memseg lists\")\nCc: anatoly.burakov@intel.com\nCc: stable@dpdk.org\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_eal/linux/eal/eal_memory.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/linux/eal/eal_memory.c b/lib/librte_eal/linux/eal/eal_memory.c\nindex 43e4ffc757bd..cf5b2433614b 100644\n--- a/lib/librte_eal/linux/eal/eal_memory.c\n+++ b/lib/librte_eal/linux/eal/eal_memory.c\n@@ -1967,9 +1967,8 @@ eal_legacy_hugepage_attach(void)\n \tclose(fd);\n error:\n \t/* map all segments into memory to make sure we get the addrs */\n-\tcur_seg = 0;\n \tfor (cur_seg = 0; cur_seg < i; cur_seg++) {\n-\t\tstruct hugepage_file *hf = &hp[i];\n+\t\tstruct hugepage_file *hf = &hp[cur_seg];\n \t\tsize_t map_sz = hf->size;\n \t\tvoid *map_addr = hf->final_va;\n \n",
    "prefixes": []
}