Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64236/?format=api
{ "id": 64236, "url": "http://patches.dpdk.org/api/patches/64236/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200106083423.26600-1-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200106083423.26600-1-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200106083423.26600-1-somnath.kotur@broadcom.com", "date": "2020-01-06T08:34:23", "name": "mbuf: fix to update documentation of QinQ stripped bit interpretation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e82c23c78da7684828668c02309d9538be601ab5", "submitter": { "id": 908, "url": "http://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200106083423.26600-1-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 7991, "url": "http://patches.dpdk.org/api/series/7991/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7991", "date": "2020-01-06T08:34:23", "name": "mbuf: fix to update documentation of QinQ stripped bit interpretation", "version": 1, "mbox": "http://patches.dpdk.org/series/7991/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64236/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/64236/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CC892A04F1;\n\tMon, 6 Jan 2020 09:35:21 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2DB5D1D5EF;\n\tMon, 6 Jan 2020 09:35:21 +0100 (CET)", "from relay.smtp.broadcom.com (relay.smtp.broadcom.com\n [192.19.232.149]) by dpdk.org (Postfix) with ESMTP id 639531D5EC\n for <dev@dpdk.org>; Mon, 6 Jan 2020 09:35:19 +0100 (CET)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n (bgccx-dev-host-lnx35.bec.broadcom.net [10.123.153.55])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id A10E61B9583;\n Mon, 6 Jan 2020 00:35:18 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com A10E61B9583", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1578299719;\n bh=wPMZ/YbX6xZ1SG+IDZH+OQKNgaEgXP9L9r4I+sDpCBM=;\n h=From:To:Cc:Subject:Date:From;\n b=ICff+qO7nQ7b7C5SOWd634mpuiKMRtLgNX6Ci7H7uO6VjxvkxyJXGmc7ehr1zcLiQ\n 86y9SNktftJwvD00XNfWKIl5846LbKPXHZDzQsQlOTAeBlLvSDPGcyWQb4w34KybgN\n cnSkbEkkRmWGEcuLF89dL2y/hMtyE0ng6Pth2pZE=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Mon, 6 Jan 2020 14:04:23 +0530", "Message-Id": "<20200106083423.26600-1-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70", "Subject": "[dpdk-dev] [PATCH] mbuf: fix to update documentation of QinQ\n\tstripped bit interpretation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Certain hardware may be able to strip and/or save only the outermost\nVLAN instead of both the VLANs in the mbuf in a QinQ scenario.\nTo handle such cases, we could re-interpret setting of just\nPKT_RX_QINQ_STRIPPED to indicate that only the outermost VLAN has\nbeen stripped and saved in mbuf->vlan_tci_outer.\nOnly When both PKT_RX_QINQ_STRIPPED and PKT_RX_VLAN_STRIPPED are set, the 2\nVLANs have been stripped by the hardware and their TCI are saved in\nmbuf->vlan_tci (inner) and mbuf->vlan_tci_outer (outer).\n\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n lib/librte_mbuf/rte_mbuf_core.h | 15 +++++++++++----\n 1 file changed, 11 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_mbuf/rte_mbuf_core.h b/lib/librte_mbuf/rte_mbuf_core.h\nindex 9a8557d..db1070b 100644\n--- a/lib/librte_mbuf/rte_mbuf_core.h\n+++ b/lib/librte_mbuf/rte_mbuf_core.h\n@@ -124,12 +124,19 @@\n #define PKT_RX_FDIR_FLX (1ULL << 14)\n \n /**\n- * The 2 vlans have been stripped by the hardware and their tci are\n- * saved in mbuf->vlan_tci (inner) and mbuf->vlan_tci_outer (outer).\n+ * The outer vlan has been stripped by the hardware and their tci are\n+ * saved in mbuf->vlan_tci_outer (outer).\n * This can only happen if vlan stripping is enabled in the RX\n * configuration of the PMD.\n- * When PKT_RX_QINQ_STRIPPED is set, the flags (PKT_RX_VLAN |\n- * PKT_RX_VLAN_STRIPPED | PKT_RX_QINQ) must also be set.\n+ * When PKT_RX_QINQ_STRIPPED is set, the flags (PKT_RX_VLAN | PKT_RX_QINQ)\n+ * must also be set.\n+ * When both PKT_RX_QINQ_STRIPPED and PKT_RX_VLAN_STRIPPED are set, the 2 vlans\n+ * have been stripped by the hardware and their tci are saved in\n+ * mbuf->vlan_tci (inner) and mbuf->vlan_tci_outer (outer).\n+ * This can only happen if vlan stripping is enabled in the RX configuration\n+ * of the PMD.\n+ * When PKT_RX_QINQ_STRIPPED and PKT_RX_VLAN_STRIPPED are set,\n+ * (PKT_RX_VLAN | PKT_RX_QINQ) must also be set.\n */\n #define PKT_RX_QINQ_STRIPPED (1ULL << 15)\n \n", "prefixes": [] }