Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64207/?format=api
{ "id": 64207, "url": "http://patches.dpdk.org/api/patches/64207/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200104013341.19809-11-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200104013341.19809-11-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20200104013341.19809-11-stephen@networkplumber.org", "date": "2020-01-04T01:33:37", "name": "[10/14] tap: close netlink socket on device close", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a6593eabfc2fcc026866c47d952a7e6719c749be", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200104013341.19809-11-stephen@networkplumber.org/mbox/", "series": [ { "id": 7981, "url": "http://patches.dpdk.org/api/series/7981/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7981", "date": "2020-01-04T01:33:27", "name": "cleanup resources on shutdown", "version": 1, "mbox": "http://patches.dpdk.org/series/7981/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64207/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/64207/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3EA8DA04DD;\n\tSat, 4 Jan 2020 02:35:20 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 195CA1C0B6;\n\tSat, 4 Jan 2020 02:34:11 +0100 (CET)", "from mail-pl1-f196.google.com (mail-pl1-f196.google.com\n [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 6CBB31D540\n for <dev@dpdk.org>; Sat, 4 Jan 2020 02:34:03 +0100 (CET)", "by mail-pl1-f196.google.com with SMTP id b22so19616059pls.12\n for <dev@dpdk.org>; Fri, 03 Jan 2020 17:34:03 -0800 (PST)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id j6sm16212934pjv.10.2020.01.03.17.34.01\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 03 Jan 2020 17:34:01 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=5SbRrlbd1L2WS6lePAGc0pDNaSt2ZIUzCyVTIi9ZU5g=;\n b=G6ekjBjVTafPLUJoKmLqLZsYDg5SaOXh7YJmFdEDHZ5VyPxh/QVL05B0aV+7BSrni4\n oo057wHFNNZdThItpofcQautD5wIKEtLxEas5s/1oghEYn6KVNp1rFmJ9WB2WvJRQk/P\n 9khXGjnAx5MzdUuDSkS87m/R7jlnop/8MuDKdWQLaD4bOyVwr3jr1DJdN5/CjtAA9873\n gLpfrogiz0HYQdnSZeLOxLUE0pX+ksWbZ7ciTtV19hgomLZqKZI92ey/I9T7VCmye+jJ\n XSCyBBv2eAMrYlecFk1cA7LhZVBBrmQnfGX2IujchtxElcLhHvQ0X/37v6ZX88qdfHRb\n G7JA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=5SbRrlbd1L2WS6lePAGc0pDNaSt2ZIUzCyVTIi9ZU5g=;\n b=pKng8Yhru3X5i7UlKYrbjMXIlQa4zhx++Jn9QRrp5HsSbF+2iqv3+lvfP7oximBC5B\n E8UaWNTkT+kUwhCb0wyz3+HP+83UNp4dNT4gUmJEpnDPf9BMQAflspz/8OXW28sMW1nZ\n 6EQQYjeMdzsbqdzjo+bGePrrIMjJ0OnmRfVOXeWgOY+2dN4MWBoechdrwheNK6Tn4FQX\n wloD0Ot2BB+DQmRDjntEXm8sRgaLW+KtxmRUkCLcchbUzJbCsECezQ9+/G8cJz0NCcSF\n SQybNa7CwtmvEKloE+Cm8dZhKZ67fqXhWWLTJUbl5jiQc9nOSyacpemVUlFkWfx0LKWN\n 8ESw==", "X-Gm-Message-State": "APjAAAVuFsh9hnq/s+xCMH0/hHoxKQrI+TLnZ7WgBTBdvdREjYLNUmJD\n r6bFRRUAlFL1dRNkX82kxX5Lo9tYlZc=", "X-Google-Smtp-Source": "\n APXvYqx6QdNwxe+ARMi/tZZ9PfLqwlTPb4Dac8dwDxang7VupulXE184S5oFHzvz+MxoJxiEFv5cXQ==", "X-Received": "by 2002:a17:902:a505:: with SMTP id\n s5mr69453949plq.244.1578101642278;\n Fri, 03 Jan 2020 17:34:02 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>, pascal.mazon@6wind.com,\n stable@dpdk.org", "Date": "Fri, 3 Jan 2020 17:33:37 -0800", "Message-Id": "<20200104013341.19809-11-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200104013341.19809-1-stephen@networkplumber.org>", "References": "<20200104013341.19809-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 10/14] tap: close netlink socket on device close", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The netlink socket for flow creation was left open and never\nclosed.\n\nFixes: bf7b7f437b49 (\"net/tap: create netdevice during probing\")\nCc: pascal.mazon@6wind.com\nCc: stable@dpdk.org\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/tap/rte_eth_tap.c | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex a13d8d50d7d7..d293dd8eeed5 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -1035,6 +1035,11 @@ tap_dev_close(struct rte_eth_dev *dev)\n \t\t\t\t&internals->remote_initial_flags);\n \t}\n \n+\tif (internals->nlsk_fd != -1) {\n+\t\tclose(internals->nlsk_fd);\n+\t\tinternals->nlsk_fd = -1;\n+\t}\n+\n \tif (internals->ka_fd != -1) {\n \t\tclose(internals->ka_fd);\n \t\tinternals->ka_fd = -1;\n@@ -2406,7 +2411,7 @@ rte_pmd_tap_remove(struct rte_vdev_device *dev)\n \tTAP_LOG(DEBUG, \"Closing %s Ethernet device on numa %u\",\n \t\ttuntap_types[internals->type], rte_socket_id());\n \n-\tif (internals->nlsk_fd) {\n+\tif (internals->nlsk_fd != -1) {\n \t\ttap_flow_flush(eth_dev, NULL);\n \t\ttap_flow_implicit_flush(internals, NULL);\n \t\ttap_nl_final(internals->nlsk_fd);\n", "prefixes": [ "10/14" ] }