Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64204/?format=api
{ "id": 64204, "url": "http://patches.dpdk.org/api/patches/64204/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200104013341.19809-8-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200104013341.19809-8-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20200104013341.19809-8-stephen@networkplumber.org", "date": "2020-01-04T01:33:34", "name": "[07/14] eal: interrupts close epoll fd on shutdown", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "77a66f817ff8aab10368d397ca290d0f827f60e6", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200104013341.19809-8-stephen@networkplumber.org/mbox/", "series": [ { "id": 7981, "url": "http://patches.dpdk.org/api/series/7981/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7981", "date": "2020-01-04T01:33:27", "name": "cleanup resources on shutdown", "version": 1, "mbox": "http://patches.dpdk.org/series/7981/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64204/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/64204/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ED0B5A04DD;\n\tSat, 4 Jan 2020 02:34:55 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A30DC1D54A;\n\tSat, 4 Jan 2020 02:34:05 +0100 (CET)", "from mail-pg1-f196.google.com (mail-pg1-f196.google.com\n [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 809AD1D535\n for <dev@dpdk.org>; Sat, 4 Jan 2020 02:33:59 +0100 (CET)", "by mail-pg1-f196.google.com with SMTP id k3so24154316pgc.3\n for <dev@dpdk.org>; Fri, 03 Jan 2020 17:33:59 -0800 (PST)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id j6sm16212934pjv.10.2020.01.03.17.33.57\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 03 Jan 2020 17:33:57 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=T5LXB1s2UIxR34Xe2jU+wA9i8ygptxAvHQpIZVUagwo=;\n b=cK66938/ByAJwYxyIApqtg+/aP18KNQaZzKj9rzuNnjoSsTuSQkf7Q+7n6utactIVA\n /7k9EIlGo1zeVhwmhwMsmn75fdQnANnpmakEyL3fUVRcL8LUUk4psgqsGa3LRJqb1qFF\n XuF/fzAmruyaNwGD+QQXozrA4qAkDzxqlagVgKdMA63YFKj36tbzpoD4rkjIon6bf92b\n emc5yX+HT/SH76I0T16nI7TTi57Xsn57vCARyEs7OW4zCoKrPIrn1g2VCDyNOHziiFUA\n hizal5xPyL9M8BHNAHyXE8lXcfRqAFmXKAnGO0oLgjV8oLYp92d6dOpVCp9AYwhuLn6K\n cI5g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=T5LXB1s2UIxR34Xe2jU+wA9i8ygptxAvHQpIZVUagwo=;\n b=PD99Jc+ApUlmY7h2wk7lzuU9AaG0pTOdnxNkob1EMR8duH7dI40CObkirQDI3q/JUg\n kkZZlSONOi5CL1UUa7C/s/fJI0Mkrb0VxHGtQWiL+oawqaQC0Gj5tCP6SkHnTf30UtWG\n Y2J3y/T5PZ3WdkfogxwLzmRsA9FimfXudeOOv3Y9fJbzp6EKn4YbU6M7IXD85Z9v0QRD\n YxSNgRlOCDOU0uhtQIV+sQFUai/bzKrdK5rng3KbSHeaM5dJKFIl6ollOP/1YRIkxphe\n zbjPbdCuIF2N4IVJQfcOKq7eg1ja2AsVnf03PNZKWcVOslnc0WcVNtzAOIotwl0QSb9B\n g66A==", "X-Gm-Message-State": "APjAAAXTeEdvTpQbxUTib0IbGSxhrgbfuOq5K6vS7oOStKwwxWiP1bUD\n aLDugFqwin9Vwk0Au/rjqT2icXGVHzA=", "X-Google-Smtp-Source": "\n APXvYqzxjzcmTnP0eJaixr/giorA1QWAWnHZXRphLNa/Fb+u3wvi61ute3fhsKvV3uH75QQLLza0mw==", "X-Received": "by 2002:a63:534d:: with SMTP id t13mr94905828pgl.89.1578101638256;\n Fri, 03 Jan 2020 17:33:58 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Fri, 3 Jan 2020 17:33:34 -0800", "Message-Id": "<20200104013341.19809-8-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200104013341.19809-1-stephen@networkplumber.org>", "References": "<20200104013341.19809-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 07/14] eal: interrupts close epoll fd on shutdown", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Use pthread callbacks to ensure that the epoll fd is closed\nwhen rte_eal_cleanup is called.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_eal/linux/eal/eal_interrupts.c | 26 ++++++++++++++++++-----\n 1 file changed, 21 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_eal/linux/eal/eal_interrupts.c b/lib/librte_eal/linux/eal/eal_interrupts.c\nindex fa08ac4171bd..ae4d3ae3ed60 100644\n--- a/lib/librte_eal/linux/eal/eal_interrupts.c\n+++ b/lib/librte_eal/linux/eal/eal_interrupts.c\n@@ -1032,6 +1032,19 @@ eal_intr_handle_interrupts(int pfd, unsigned totalfds)\n \t}\n }\n \n+\n+/**\n+ * Callback at end of intr_thread loop or if thread is cancelled\n+ * that closes the epoll file descriptor\n+ */\n+static void\n+eal_intr_thread_close(void *arg)\n+{\n+\tint pfd = (int)(unsigned long)arg;\n+\n+\tclose(pfd);\n+}\n+\n /**\n * It builds/rebuilds up the epoll file descriptor with all the\n * file descriptors being waited on. Then handles the interrupts.\n@@ -1061,6 +1074,12 @@ eal_intr_thread_main(__rte_unused void *arg)\n \t\tif (pfd < 0)\n \t\t\trte_panic(\"Cannot create epoll instance\\n\");\n \n+\t\t/* close pfd on thread exit or cancel_pop\n+\t\t * see man page for restrictions on this macro.\n+\t\t */\n+\t\tpthread_cleanup_push(eal_intr_thread_close,\n+\t\t\t\t (void *)(unsigned long)pfd);\n+\n \t\tpipe_event.data.fd = intr_pipe.readfd;\n \t\t/**\n \t\t * add pipe fd into wait list, this pipe is used to\n@@ -1100,11 +1119,8 @@ eal_intr_thread_main(__rte_unused void *arg)\n \t\t/* serve the interrupt */\n \t\teal_intr_handle_interrupts(pfd, numfds);\n \n-\t\t/**\n-\t\t * when we return, we need to rebuild the\n-\t\t * list of fds to monitor.\n-\t\t */\n-\t\tclose(pfd);\n+\t\t/* close pfd and rebuild the list */\n+\t\tpthread_cleanup_pop(1);\n \t}\n }\n \n", "prefixes": [ "07/14" ] }