Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64203/?format=api
{ "id": 64203, "url": "http://patches.dpdk.org/api/patches/64203/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200104013341.19809-7-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200104013341.19809-7-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20200104013341.19809-7-stephen@networkplumber.org", "date": "2020-01-04T01:33:33", "name": "[06/14] eal: mp: end the multiprocess thread during cleanup", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f6969376481e886c1c012653f69c3e214b1aab08", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200104013341.19809-7-stephen@networkplumber.org/mbox/", "series": [ { "id": 7981, "url": "http://patches.dpdk.org/api/series/7981/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7981", "date": "2020-01-04T01:33:27", "name": "cleanup resources on shutdown", "version": 1, "mbox": "http://patches.dpdk.org/series/7981/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64203/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/64203/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1C232A04DD;\n\tSat, 4 Jan 2020 02:34:48 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 98CE21D544;\n\tSat, 4 Jan 2020 02:34:03 +0100 (CET)", "from mail-pf1-f194.google.com (mail-pf1-f194.google.com\n [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 40F461D527\n for <dev@dpdk.org>; Sat, 4 Jan 2020 02:33:58 +0100 (CET)", "by mail-pf1-f194.google.com with SMTP id p14so24242956pfn.4\n for <dev@dpdk.org>; Fri, 03 Jan 2020 17:33:58 -0800 (PST)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id j6sm16212934pjv.10.2020.01.03.17.33.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 03 Jan 2020 17:33:56 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=PsbFGiuqVzUnCaOerMQu4RnG5MXl0k+UnOHZoH5rQdc=;\n b=pbTl2Jr2GGVwBUC37wEggvcyMm7BS6bS4nVku+RJvj/i+v4TPMi2zl00tPT+O/4CE0\n Oix8oQsWl+jGFq4IkxdcBGYXyUPe6mu4KZoE4H2lpgb7GMfOh7+WVT6RPGWI8gl+2Jfl\n KTPuvBm8ryW/m0uRBHBtYYwfaAN9BIH66pyLoxEygmFTY82bxujH5jDrSvys3R1ets4S\n vn764lAmZ/N0yBOp6gbYwyje5ZQeUf2Lg5HY0oIcQSYvqAnePFbTRw+OwfHx8G/Wqux7\n zzlMMEZG0Vf61VAXgdeyb5Epjhm0R0V8CjUlvFef9fzXRXt/LzDI2KzqFQxO4dlzK6UU\n jBaw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=PsbFGiuqVzUnCaOerMQu4RnG5MXl0k+UnOHZoH5rQdc=;\n b=kPlAmNQSOZpe49WtYJKVjisDVZXpv+5LbUL9qlltstHhNUJpKAw9HzXzgMglI0zmPt\n YO6KGWkQ++aQaIQR/CaWpg+6+TjXlLwWp5HJASkYi7CoweBz8WdALg/Shk0u9ZpqfAv/\n ITcszVl4ovLLB8kFOudnANxB1iddZPt+5hH/RBcxgxl6s0xg1/h8E35+3ua0R4wGdl9z\n zoqeDKe5eBOiIZ8qHxHKjE4pU7qTV3379Qctrs/CnipkizKlhKtlsT4V5+yndC3ppNDi\n odxolBwkSebXy6MI4pwFQbPTKTbbS13hiK/t8u6MS5cPpFNoVxsC/8ii3QwsK+l1oIgc\n xOnA==", "X-Gm-Message-State": "APjAAAWHobFMWTQspWXHxhvjswisOmKpvPg6uUYSPP0oOw3fZxTpVFE0\n bezmDqvtBFoLrzbk8RyHjxv4mfBIu6I=", "X-Google-Smtp-Source": "\n APXvYqzdWTH3WXCDnSteZkKMfL046ixZryY8gj0Z/wmSC2d8Ym9bEh27Sylb5S6nLMzOGs+Zwpj43Q==", "X-Received": "by 2002:a63:1908:: with SMTP id z8mr99875054pgl.350.1578101636864;\n Fri, 03 Jan 2020 17:33:56 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>, qi.z.zhang@intel.com,\n stable@dpdk.org", "Date": "Fri, 3 Jan 2020 17:33:33 -0800", "Message-Id": "<20200104013341.19809-7-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200104013341.19809-1-stephen@networkplumber.org>", "References": "<20200104013341.19809-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 06/14] eal: mp: end the multiprocess thread\n\tduring cleanup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When rte_eal_cleanup is called, all control threads should exit.\nFor the mp thread, this best handled by closing the mp_socket\nand letting the thread see that.\n\nThis also fixes potential problems where the mp_socket gets\nanother hard error, and the thread runs away repeating itself\nby reading the same error.\n\nFixes: 85d6815fa6d0 (\"eal: close multi-process socket during cleanup\")\nCc: qi.z.zhang@intel.com\nCc: stable@dpdk.org\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_eal/common/eal_common_proc.c | 17 ++++++++++++-----\n 1 file changed, 12 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c\nindex 935e8fefeba8..f369d8bf6dd8 100644\n--- a/lib/librte_eal/common/eal_common_proc.c\n+++ b/lib/librte_eal/common/eal_common_proc.c\n@@ -276,8 +276,17 @@ read_msg(struct mp_msg_internal *m, struct sockaddr_un *s)\n \tmsgh.msg_control = control;\n \tmsgh.msg_controllen = sizeof(control);\n \n+retry:\n \tmsglen = recvmsg(mp_fd, &msgh, 0);\n+\n+\t/* zero length message means socket was closed */\n+\tif (msglen == 0)\n+\t\treturn 0;\n+\n \tif (msglen < 0) {\n+\t\tif (errno == EINTR)\n+\t\t\tgoto retry;\n+\n \t\tRTE_LOG(ERR, EAL, \"recvmsg failed, %s\\n\", strerror(errno));\n \t\treturn -1;\n \t}\n@@ -305,7 +314,7 @@ read_msg(struct mp_msg_internal *m, struct sockaddr_un *s)\n \t\tRTE_LOG(ERR, EAL, \"invalid received data length\\n\");\n \t\treturn -1;\n \t}\n-\treturn 0;\n+\treturn msglen;\n }\n \n static void\n@@ -376,10 +385,8 @@ mp_handle(void *arg __rte_unused)\n \tstruct mp_msg_internal msg;\n \tstruct sockaddr_un sa;\n \n-\twhile (1) {\n-\t\tif (read_msg(&msg, &sa) == 0)\n-\t\t\tprocess_msg(&msg, &sa);\n-\t}\n+\twhile (read_msg(&msg, &sa) > 0)\n+\t\tprocess_msg(&msg, &sa);\n \n \treturn NULL;\n }\n", "prefixes": [ "06/14" ] }