Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64202/?format=api
http://patches.dpdk.org/api/patches/64202/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200104013341.19809-6-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200104013341.19809-6-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20200104013341.19809-6-stephen@networkplumber.org", "date": "2020-01-04T01:33:32", "name": "[05/14] eal: intr: cleanup resources", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5c2a0481ea4b36bb78cf7e2b34929da84bd6a47d", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200104013341.19809-6-stephen@networkplumber.org/mbox/", "series": [ { "id": 7981, "url": "http://patches.dpdk.org/api/series/7981/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7981", "date": "2020-01-04T01:33:27", "name": "cleanup resources on shutdown", "version": 1, "mbox": "http://patches.dpdk.org/series/7981/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64202/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/64202/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3B3C2A04DD;\n\tSat, 4 Jan 2020 02:34:39 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 881091D522;\n\tSat, 4 Jan 2020 02:34:01 +0100 (CET)", "from mail-pj1-f68.google.com (mail-pj1-f68.google.com\n [209.85.216.68]) by dpdk.org (Postfix) with ESMTP id EB2CB1D527\n for <dev@dpdk.org>; Sat, 4 Jan 2020 02:33:56 +0100 (CET)", "by mail-pj1-f68.google.com with SMTP id bg7so5353288pjb.5\n for <dev@dpdk.org>; Fri, 03 Jan 2020 17:33:56 -0800 (PST)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id j6sm16212934pjv.10.2020.01.03.17.33.54\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 03 Jan 2020 17:33:54 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=xxeb7t92o0tojQKq8wkvvjXExuQ6Ub6YujsdRzIxFg4=;\n b=v1qMLsBhDhC37cSK+qTrMVjrJglb9YyQUKwBoE+2VM3XdLPDipB8JwftwK1B9CxVaG\n 8eDLCTh9lpVDvK/2itTwPBvBcvNgXhXqtKtwzGwxdmSk0PjngbpRzl7rTkwsKgVHxWki\n Cds8g87Yn5IlE0VJX66YXNjVlTmt5Byz1ulp+bbQ65HO0SZfEBNNbxB/AA9DCWuEwnMm\n xiT03xzX6Nrbq3bRD4j0cJBPDa1EIYCifZvRgfgBFuNx1ABqjdpjMHYe9wv3nabhhvw+\n 4I0u5PXal3GYuxIcvFmClDma8rMOp/eeWdWVASyQHNNX5FTKVdAfsvqRtyJN07dJHaG9\n kvQQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=xxeb7t92o0tojQKq8wkvvjXExuQ6Ub6YujsdRzIxFg4=;\n b=p1SShmXfmnO8urV4v0S14ohpEDOZnZTMvI3uLKL10ZwyexhLQgsQ/i4Y+iM745RrOY\n 6NBr7MSNozvIRX8dBAeyg6NmhcYQWlS/pn6MOqXDli3fTSM++10pNROIQzaTrrN/AovT\n kjAuwm+IP4FLdhztKisbHKJhKCJ44Z6k8e4QYiBKsTdsY/hwP16iHtmAPXk5UbpyORsn\n hj08Nruo+eSQe3HQHergPI7X/J0zSyqpEu8j1CE9ACH3ZEi46JeY5kmui2tjIIQ7Q9FX\n nds/96mm6ye0RFxrvTXAz/GkumRNFO1be+Y2rVq9gDWsHW1RSsLzlwYsWlvpHpcqxN1X\n Avkw==", "X-Gm-Message-State": "APjAAAXxKfutFuW4DF8WhTFz+6UiGo/wMZPPiBZj1Wj6kOdZDPs9kS5v\n uZAyWU7Rqez8qTKMM2ivK4AArvduSio=", "X-Google-Smtp-Source": "\n APXvYqxYB1V54HgGPSIOfnW0TdWNBowG3U6D093xpScwwXubv50DrfpdMLDlyBuJa/ET/Kqnt1Ht1g==", "X-Received": "by 2002:a17:902:b611:: with SMTP id\n b17mr95245830pls.210.1578101635544;\n Fri, 03 Jan 2020 17:33:55 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Fri, 3 Jan 2020 17:33:32 -0800", "Message-Id": "<20200104013341.19809-6-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200104013341.19809-1-stephen@networkplumber.org>", "References": "<20200104013341.19809-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 05/14] eal: intr: cleanup resources", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When rte_eal_cleanup is called the interrupt thread and\nassociated resources should be cleaned up.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_eal/common/eal_private.h | 10 ++++++++++\n lib/librte_eal/linux/eal/eal.c | 1 +\n lib/librte_eal/linux/eal/eal_interrupts.c | 9 +++++++++\n 3 files changed, 20 insertions(+)", "diff": "diff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h\nindex 38682e79827c..c62f35d3ac0f 100644\n--- a/lib/librte_eal/common/eal_private.h\n+++ b/lib/librte_eal/common/eal_private.h\n@@ -191,6 +191,16 @@ int rte_eal_tailqs_init(void);\n */\n int rte_eal_intr_init(void);\n \n+/**\n+ * Cleanup interrupt handling.\n+ *\n+ * This function is private to EAL.\n+ *\n+ * @return\n+ * 0 on success, negative on error\n+ */\n+void rte_eal_intr_cleanup(void);\n+\n /**\n * Init alarm mechanism. This is to allow a callback be called after\n * specific time.\ndiff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c\nindex d98a2afe85da..eb95f4f0c317 100644\n--- a/lib/librte_eal/linux/eal/eal.c\n+++ b/lib/librte_eal/linux/eal/eal.c\n@@ -1338,6 +1338,7 @@ rte_eal_cleanup(void)\n \t}\n \n \trte_service_finalize();\n+\trte_eal_intr_cleanup();\n \trte_eal_alarm_cleanup();\n \trte_mp_channel_cleanup();\n \teal_cleanup_config(&internal_config);\ndiff --git a/lib/librte_eal/linux/eal/eal_interrupts.c b/lib/librte_eal/linux/eal/eal_interrupts.c\nindex 14ebb108cee9..fa08ac4171bd 100644\n--- a/lib/librte_eal/linux/eal/eal_interrupts.c\n+++ b/lib/librte_eal/linux/eal/eal_interrupts.c\n@@ -1137,6 +1137,15 @@ rte_eal_intr_init(void)\n \treturn ret;\n }\n \n+void\n+rte_eal_intr_cleanup(void)\n+{\n+\tpthread_cancel(intr_thread);\n+\tpthread_join(intr_thread, NULL);\n+\tclose(intr_pipe.readfd);\n+\tclose(intr_pipe.writefd);\n+}\n+\n static void\n eal_intr_proc_rxtx_intr(int fd, const struct rte_intr_handle *intr_handle)\n {\n", "prefixes": [ "05/14" ] }{ "id": 64202, "url": "