Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64201/?format=api
{ "id": 64201, "url": "http://patches.dpdk.org/api/patches/64201/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200104013341.19809-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200104013341.19809-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20200104013341.19809-5-stephen@networkplumber.org", "date": "2020-01-04T01:33:31", "name": "[04/14] eal: cleanup threads", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "63beedfac00735e1a99a6be7fd905171335eb96d", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200104013341.19809-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 7981, "url": "http://patches.dpdk.org/api/series/7981/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7981", "date": "2020-01-04T01:33:27", "name": "cleanup resources on shutdown", "version": 1, "mbox": "http://patches.dpdk.org/series/7981/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64201/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/64201/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A4643A04DD;\n\tSat, 4 Jan 2020 02:34:31 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A96E91D538;\n\tSat, 4 Jan 2020 02:33:59 +0100 (CET)", "from mail-pg1-f196.google.com (mail-pg1-f196.google.com\n [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 4DE251D51D\n for <dev@dpdk.org>; Sat, 4 Jan 2020 02:33:55 +0100 (CET)", "by mail-pg1-f196.google.com with SMTP id b137so24142447pga.6\n for <dev@dpdk.org>; Fri, 03 Jan 2020 17:33:55 -0800 (PST)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id j6sm16212934pjv.10.2020.01.03.17.33.52\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 03 Jan 2020 17:33:53 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=Oyl74YOTBn8D11KizXfAhLy6Ct8Bthw2Jprwg24xr5I=;\n b=TOQ99Qq7IEae0o6a4LQtZe5/wekTNGm+PUFupWvSm8ii9LxBswPjgkYTZosEQRy7Yt\n fqw6KQwM29sp1LRZytcWooy8fx9Xyf3zPfg2GD4pEzzabCqb7YOivd1OKePVrBb26Nyb\n U9LbTsEjbZuG8Z7G54TL+6hxByFr85hfqAU5hOYueQMZxlNwKymgQqith9Z1NuPdndRw\n JCLX+0yr7Z6cjw6awSCxtn7+jv++F14ikR69XEi065+02h3d+ufDeQZ3+0B6pMbGx9He\n bnmbIbR9H0ilazcMlEwWkBDofhgzUHb5ed7sJg1VGkEP3ab6JQ1cpMM+HmKI/BHDe8rL\n J9ag==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=Oyl74YOTBn8D11KizXfAhLy6Ct8Bthw2Jprwg24xr5I=;\n b=DHuLQdEfDjPIYO7iAcpe6O+D+luqYvO7AqHIjOtpdxNVE3fXs6KlSccpXC/DtH7aC7\n KDVTjaIBcqpmz1Zs7xMmseWAvXF6Tfb+CNYw3S2rmgcL+MlM3x3i7DAsKPuFBsUrWdOj\n WCqFfcGp+ddCoX9VycwxidzrVRODBsYMGSTyk2386c5KWNnFD0abMgm0ZOkKZVroIR9x\n Nl6tTuFVNtOXOHu61mEATRzIAxByje8G0uO0EO5QcKGP2Kv8TEood7OJ/v+oSXZIDPVU\n jZ2AePeM8XFbIfkbOLCW+45yDzPvCt6krt6vnjOWI0ucqCOz1JEgF2Aw//o73FVJtQxW\n thAg==", "X-Gm-Message-State": "APjAAAU0PekuYQNGGB4fg5rInhcKjB3zZ0EYyV2z36fhA3DxRSM/WsnT\n PVm4oND77d/DokITSK3pgK3VU0bvn1Q=", "X-Google-Smtp-Source": "\n APXvYqwqgJ28J3YpoYbgMbOk7LU7pVBW8CCRVjMTKDB1w0oWw03ieDiLEX03X+ZLSHskpDfDOom1zA==", "X-Received": "by 2002:a63:444c:: with SMTP id\n t12mr96474455pgk.433.1578101634089;\n Fri, 03 Jan 2020 17:33:54 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Fri, 3 Jan 2020 17:33:31 -0800", "Message-Id": "<20200104013341.19809-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200104013341.19809-1-stephen@networkplumber.org>", "References": "<20200104013341.19809-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 04/14] eal: cleanup threads", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When rte_eal_cleanup is called it should stop all the child threads\nand close the pipes between threads.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_eal/linux/eal/eal.c | 13 +++++++++++++\n 1 file changed, 13 insertions(+)", "diff": "diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c\nindex a1b928820b11..d98a2afe85da 100644\n--- a/lib/librte_eal/linux/eal/eal.c\n+++ b/lib/librte_eal/linux/eal/eal.c\n@@ -1319,11 +1319,24 @@ mark_freeable(const struct rte_memseg_list *msl, const struct rte_memseg *ms,\n int\n rte_eal_cleanup(void)\n {\n+\tint i;\n+\n \t/* if we're in a primary process, we need to mark hugepages as freeable\n \t * so that finalization can release them back to the system.\n \t */\n \tif (rte_eal_process_type() == RTE_PROC_PRIMARY)\n \t\trte_memseg_walk(mark_freeable, NULL);\n+\n+\tRTE_LCORE_FOREACH_SLAVE(i) {\n+\t\tpthread_cancel(lcore_config[i].thread_id);\n+\t\tpthread_join(lcore_config[i].thread_id, NULL);\n+\n+\t\tclose(lcore_config[i].pipe_master2slave[0]);\n+\t\tclose(lcore_config[i].pipe_master2slave[1]);\n+\t\tclose(lcore_config[i].pipe_slave2master[0]);\n+\t\tclose(lcore_config[i].pipe_slave2master[1]);\n+\t}\n+\n \trte_service_finalize();\n \trte_eal_alarm_cleanup();\n \trte_mp_channel_cleanup();\n", "prefixes": [ "04/14" ] }