Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64174/?format=api
{ "id": 64174, "url": "http://patches.dpdk.org/api/patches/64174/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200102174838.12908-8-dharmik.thakkar@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200102174838.12908-8-dharmik.thakkar@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200102174838.12908-8-dharmik.thakkar@arm.com", "date": "2020-01-02T17:48:38", "name": "[v2,7/7] net/qede: remove 'typedef int bool'", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4ee286bc5d013b974c5172cbf69d4f218f4d7d17", "submitter": { "id": 1108, "url": "http://patches.dpdk.org/api/people/1108/?format=api", "name": "Dharmik Thakkar", "email": "dharmik.thakkar@arm.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200102174838.12908-8-dharmik.thakkar@arm.com/mbox/", "series": [ { "id": 7966, "url": "http://patches.dpdk.org/api/series/7966/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7966", "date": "2020-01-02T17:48:31", "name": "remove 'typedef int bool'", "version": 2, "mbox": "http://patches.dpdk.org/series/7966/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64174/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/64174/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2852BA04F3;\n\tThu, 2 Jan 2020 18:50:13 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AC1D81C1C5;\n\tThu, 2 Jan 2020 18:49:29 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 470091C195\n for <dev@dpdk.org>; Thu, 2 Jan 2020 18:49:17 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8A2FF1396;\n Thu, 2 Jan 2020 09:49:16 -0800 (PST)", "from dp6132.usa.Arm.com (dp6132.usa.arm.com [10.118.91.150])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 856C13F703;\n Thu, 2 Jan 2020 09:49:16 -0800 (PST)" ], "From": "Dharmik Thakkar <dharmik.thakkar@arm.com>", "To": "Rasesh Mody <rmody@marvell.com>,\n\tShahed Shaikh <shshaikh@marvell.com>", "Cc": "dev@dpdk.org,\n\tDharmik Thakkar <dharmik.thakkar@arm.com>", "Date": "Thu, 2 Jan 2020 17:48:38 +0000", "Message-Id": "<20200102174838.12908-8-dharmik.thakkar@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200102174838.12908-1-dharmik.thakkar@arm.com>", "References": "<20191003224419.23968-1-dharmik.thakkar@arm.com>\n <20200102174838.12908-1-dharmik.thakkar@arm.com>", "Subject": "[dpdk-dev] [PATCH v2 7/7] net/qede: remove 'typedef int bool'", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Replace 'typedef int bool' with 'stdbool.h' to avoid possible\nmultiple definitions of 'bool'.\n\n(Not sure if the previous code is checking for true/false condition.\nRecommend careful review on this patch.)\n\nSigned-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>\nReviewed-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n drivers/net/qede/base/bcm_osal.h | 5 +----\n drivers/net/qede/base/ecore_vf.c | 2 +-\n drivers/net/qede/qede_ethdev.c | 2 +-\n 3 files changed, 3 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/qede/base/bcm_osal.h b/drivers/net/qede/base/bcm_osal.h\nindex 0f09557cf06c..513f6a8b429f 100644\n--- a/drivers/net/qede/base/bcm_osal.h\n+++ b/drivers/net/qede/base/bcm_osal.h\n@@ -7,6 +7,7 @@\n #ifndef __BCM_OSAL_H\n #define __BCM_OSAL_H\n \n+#include <stdbool.h>\n #include <rte_byteorder.h>\n #include <rte_spinlock.h>\n #include <rte_malloc.h>\n@@ -71,10 +72,6 @@ typedef size_t osal_size_t;\n \n typedef intptr_t osal_int_ptr_t;\n \n-typedef int bool;\n-#define true 1\n-#define false 0\n-\n #define nothing do {} while (0)\n \n /* Delays */\ndiff --git a/drivers/net/qede/base/ecore_vf.c b/drivers/net/qede/base/ecore_vf.c\nindex 24846cfb51da..c5c081426281 100644\n--- a/drivers/net/qede/base/ecore_vf.c\n+++ b/drivers/net/qede/base/ecore_vf.c\n@@ -446,7 +446,7 @@ static enum _ecore_status_t ecore_vf_pf_acquire(struct ecore_hwfn *p_hwfn)\n \t}\n \n \t/* @DPDK */\n-\tif ((~p_iov->b_pre_fp_hsi &\n+\tif (((p_iov->b_pre_fp_hsi == true) &\n \t ETH_HSI_VER_MINOR) &&\n \t (resp->pfdev_info.minor_fp_hsi < ETH_HSI_VER_MINOR))\n \t\tDP_INFO(p_hwfn,\ndiff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c\nindex 19d2e961913d..af99ce9c65e6 100644\n--- a/drivers/net/qede/qede_ethdev.c\n+++ b/drivers/net/qede/qede_ethdev.c\n@@ -450,7 +450,7 @@ int qede_activate_vport(struct rte_eth_dev *eth_dev, bool flg)\n \tparams.update_vport_active_tx_flg = 1;\n \tparams.vport_active_rx_flg = flg;\n \tparams.vport_active_tx_flg = flg;\n-\tif (~qdev->enable_tx_switching & flg) {\n+\tif ((qdev->enable_tx_switching == false) && (flg == true)) {\n \t\tparams.update_tx_switching_flg = 1;\n \t\tparams.tx_switching_flg = !flg;\n \t}\n", "prefixes": [ "v2", "7/7" ] }