Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64171/?format=api
{ "id": 64171, "url": "http://patches.dpdk.org/api/patches/64171/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200102174838.12908-7-dharmik.thakkar@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200102174838.12908-7-dharmik.thakkar@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200102174838.12908-7-dharmik.thakkar@arm.com", "date": "2020-01-02T17:48:37", "name": "[v2,6/7] net/fm10k: remove 'typedef int bool'", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4bbf75242f548ff4b1a9fbd8035714ce5d6858f6", "submitter": { "id": 1108, "url": "http://patches.dpdk.org/api/people/1108/?format=api", "name": "Dharmik Thakkar", "email": "dharmik.thakkar@arm.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200102174838.12908-7-dharmik.thakkar@arm.com/mbox/", "series": [ { "id": 7966, "url": "http://patches.dpdk.org/api/series/7966/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7966", "date": "2020-01-02T17:48:31", "name": "remove 'typedef int bool'", "version": 2, "mbox": "http://patches.dpdk.org/series/7966/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64171/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/64171/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F33F5A04F3;\n\tThu, 2 Jan 2020 18:49:47 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F07DC1C1B1;\n\tThu, 2 Jan 2020 18:49:24 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 25A4B1C194\n for <dev@dpdk.org>; Thu, 2 Jan 2020 18:49:17 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 74F2911FB;\n Thu, 2 Jan 2020 09:49:16 -0800 (PST)", "from dp6132.usa.Arm.com (dp6132.usa.arm.com [10.118.91.150])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6FF7C3F703;\n Thu, 2 Jan 2020 09:49:16 -0800 (PST)" ], "From": "Dharmik Thakkar <dharmik.thakkar@arm.com>", "To": "Qi Zhang <qi.z.zhang@intel.com>,\n\tXiao Wang <xiao.w.wang@intel.com>", "Cc": "dev@dpdk.org,\n\tDharmik Thakkar <dharmik.thakkar@arm.com>", "Date": "Thu, 2 Jan 2020 17:48:37 +0000", "Message-Id": "<20200102174838.12908-7-dharmik.thakkar@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200102174838.12908-1-dharmik.thakkar@arm.com>", "References": "<20191003224419.23968-1-dharmik.thakkar@arm.com>\n <20200102174838.12908-1-dharmik.thakkar@arm.com>", "Subject": "[dpdk-dev] [PATCH v2 6/7] net/fm10k: remove 'typedef int bool'", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Replace 'typedef int bool' with 'stdbool.h' to avoid possible\nmultiple definitions of 'bool'.\n\nSigned-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>\nReviewed-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n drivers/net/fm10k/base/fm10k_osdep.h | 8 +-------\n drivers/net/fm10k/fm10k_ethdev.c | 6 +++---\n 2 files changed, 4 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/fm10k/base/fm10k_osdep.h b/drivers/net/fm10k/base/fm10k_osdep.h\nindex 3b6298010da5..019fba5e2534 100644\n--- a/drivers/net/fm10k/base/fm10k_osdep.h\n+++ b/drivers/net/fm10k/base/fm10k_osdep.h\n@@ -6,6 +6,7 @@\n #define _FM10K_OSDEP_H_\n \n #include <stdint.h>\n+#include <stdbool.h>\n #include <string.h>\n #include <rte_atomic.h>\n #include <rte_byteorder.h>\n@@ -32,12 +33,6 @@\n \n #define FALSE 0\n #define TRUE 1\n-#ifndef false\n-#define false FALSE\n-#endif\n-#ifndef true\n-#define true TRUE\n-#endif\n \n typedef uint8_t u8;\n typedef int8_t s8;\n@@ -47,7 +42,6 @@ typedef uint32_t u32;\n typedef int32_t s32;\n typedef int64_t s64;\n typedef uint64_t u64;\n-typedef int bool;\n \n #ifndef __le16\n #define __le16 u16\ndiff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex 407baa16c364..581c690b1842 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -3210,19 +3210,19 @@ eth_fm10k_dev_init(struct rte_eth_dev *dev)\n \n \t/* Make sure Switch Manager is ready before going forward. */\n \tif (hw->mac.type == fm10k_mac_pf) {\n-\t\tint switch_ready = 0;\n+\t\tbool switch_ready = false;\n \n \t\tfor (i = 0; i < MAX_QUERY_SWITCH_STATE_TIMES; i++) {\n \t\t\tfm10k_mbx_lock(hw);\n \t\t\thw->mac.ops.get_host_state(hw, &switch_ready);\n \t\t\tfm10k_mbx_unlock(hw);\n-\t\t\tif (switch_ready)\n+\t\t\tif (switch_ready == true)\n \t\t\t\tbreak;\n \t\t\t/* Delay some time to acquire async LPORT_MAP info. */\n \t\t\trte_delay_us(WAIT_SWITCH_MSG_US);\n \t\t}\n \n-\t\tif (switch_ready == 0) {\n+\t\tif (switch_ready == false) {\n \t\t\tPMD_INIT_LOG(ERR, \"switch is not ready\");\n \t\t\treturn -1;\n \t\t}\n", "prefixes": [ "v2", "6/7" ] }