Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64170/?format=api
{ "id": 64170, "url": "http://patches.dpdk.org/api/patches/64170/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20200102174838.12908-3-dharmik.thakkar@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200102174838.12908-3-dharmik.thakkar@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200102174838.12908-3-dharmik.thakkar@arm.com", "date": "2020-01-02T17:48:33", "name": "[v2,2/7] net/cxgbe: remove 'typedef int bool'", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "299650bb466b84e6298f0673e671c9be13865100", "submitter": { "id": 1108, "url": "http://patches.dpdk.org/api/people/1108/?format=api", "name": "Dharmik Thakkar", "email": "dharmik.thakkar@arm.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20200102174838.12908-3-dharmik.thakkar@arm.com/mbox/", "series": [ { "id": 7966, "url": "http://patches.dpdk.org/api/series/7966/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7966", "date": "2020-01-02T17:48:31", "name": "remove 'typedef int bool'", "version": 2, "mbox": "http://patches.dpdk.org/series/7966/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64170/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/64170/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6FDC6A04F3;\n\tThu, 2 Jan 2020 18:49:41 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 282311C1AA;\n\tThu, 2 Jan 2020 18:49:23 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id C55E21C195\n for <dev@dpdk.org>; Thu, 2 Jan 2020 18:49:16 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 253D91007;\n Thu, 2 Jan 2020 09:49:16 -0800 (PST)", "from dp6132.usa.Arm.com (dp6132.usa.arm.com [10.118.91.150])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 176863F703;\n Thu, 2 Jan 2020 09:49:16 -0800 (PST)" ], "From": "Dharmik Thakkar <dharmik.thakkar@arm.com>", "To": "Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>", "Cc": "dev@dpdk.org,\n\tDharmik Thakkar <dharmik.thakkar@arm.com>", "Date": "Thu, 2 Jan 2020 17:48:33 +0000", "Message-Id": "<20200102174838.12908-3-dharmik.thakkar@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200102174838.12908-1-dharmik.thakkar@arm.com>", "References": "<20191003224419.23968-1-dharmik.thakkar@arm.com>\n <20200102174838.12908-1-dharmik.thakkar@arm.com>", "Subject": "[dpdk-dev] [PATCH v2 2/7] net/cxgbe: remove 'typedef int bool'", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Replace 'typedef int bool' with 'stdbool.h' to avoid possible\nmultiple definitions of 'bool'.\n\nSigned-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>\nReviewed-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n drivers/net/cxgbe/cxgbe_compat.h | 4 +---\n drivers/net/cxgbe/cxgbe_main.c | 13 +++++++------\n 2 files changed, 8 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/cxgbe/cxgbe_compat.h b/drivers/net/cxgbe/cxgbe_compat.h\nindex 20e4f8af20ee..83ae1c2e5a83 100644\n--- a/drivers/net/cxgbe/cxgbe_compat.h\n+++ b/drivers/net/cxgbe/cxgbe_compat.h\n@@ -10,6 +10,7 @@\n #include <stdint.h>\n #include <stdio.h>\n #include <stdarg.h>\n+#include <stdbool.h>\n \n #include <rte_common.h>\n #include <rte_memcpy.h>\n@@ -86,7 +87,6 @@ typedef uint16_t u16;\n typedef uint32_t u32;\n typedef int32_t s32;\n typedef uint64_t u64;\n-typedef int bool;\n typedef uint64_t dma_addr_t;\n \n #ifndef __le16\n@@ -122,8 +122,6 @@ typedef uint64_t dma_addr_t;\n \n #define FALSE\t0\n #define TRUE\t1\n-#define false\t0\n-#define true\t1\n \n #ifndef min\n #define min(a, b) RTE_MIN(a, b)\ndiff --git a/drivers/net/cxgbe/cxgbe_main.c b/drivers/net/cxgbe/cxgbe_main.c\nindex cc5f4df3acbf..0d0827c0e159 100644\n--- a/drivers/net/cxgbe/cxgbe_main.c\n+++ b/drivers/net/cxgbe/cxgbe_main.c\n@@ -709,11 +709,12 @@ static int cxgbe_get_devargs(struct rte_devargs *devargs, const char *key,\n \treturn ret;\n }\n \n-static void cxgbe_get_devargs_int(struct adapter *adap, int *dst,\n-\t\t\t\t const char *key, int default_value)\n+static void cxgbe_get_devargs_int(struct adapter *adap, bool *dst,\n+\t\t\t\t const char *key, bool default_value)\n {\n \tstruct rte_pci_device *pdev = adap->pdev;\n-\tint ret, devarg_value = default_value;\n+\tint ret;\n+\tbool devarg_value = default_value;\n \n \t*dst = default_value;\n \tif (!pdev)\n@@ -729,11 +730,11 @@ static void cxgbe_get_devargs_int(struct adapter *adap, int *dst,\n void cxgbe_process_devargs(struct adapter *adap)\n {\n \tcxgbe_get_devargs_int(adap, &adap->devargs.keep_ovlan,\n-\t\t\t CXGBE_DEVARG_CMN_KEEP_OVLAN, 0);\n+\t\t\t CXGBE_DEVARG_CMN_KEEP_OVLAN, false);\n \tcxgbe_get_devargs_int(adap, &adap->devargs.tx_mode_latency,\n-\t\t\t CXGBE_DEVARG_CMN_TX_MODE_LATENCY, 0);\n+\t\t\t CXGBE_DEVARG_CMN_TX_MODE_LATENCY, false);\n \tcxgbe_get_devargs_int(adap, &adap->devargs.force_link_up,\n-\t\t\t CXGBE_DEVARG_VF_FORCE_LINK_UP, 0);\n+\t\t\t CXGBE_DEVARG_VF_FORCE_LINK_UP, false);\n }\n \n static void configure_vlan_types(struct adapter *adapter)\n", "prefixes": [ "v2", "2/7" ] }