Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64126/?format=api
http://patches.dpdk.org/api/patches/64126/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191225141835.65587-1-jin.yu@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191225141835.65587-1-jin.yu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191225141835.65587-1-jin.yu@intel.com", "date": "2019-12-25T14:18:35", "name": "vhost: fix the inflight resubmit check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "490d0ae23639325345b41ebc92e57af25f05ff36", "submitter": { "id": 1265, "url": "http://patches.dpdk.org/api/people/1265/?format=api", "name": "Jin Yu", "email": "jin.yu@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191225141835.65587-1-jin.yu@intel.com/mbox/", "series": [ { "id": 7944, "url": "http://patches.dpdk.org/api/series/7944/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7944", "date": "2019-12-25T14:18:35", "name": "vhost: fix the inflight resubmit check", "version": 1, "mbox": "http://patches.dpdk.org/series/7944/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64126/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/64126/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0EB19A04F8;\n\tWed, 25 Dec 2019 07:40:02 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 073DB1BE90;\n\tWed, 25 Dec 2019 07:40:00 +0100 (CET)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by dpdk.org (Postfix) with ESMTP id E73BA3977;\n Wed, 25 Dec 2019 07:39:57 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 24 Dec 2019 22:39:57 -0800", "from storage36.sh.intel.com ([10.67.110.177])\n by orsmga008.jf.intel.com with ESMTP; 24 Dec 2019 22:39:55 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,353,1571727600\"; d=\"scan'208\";a=\"212052253\"", "From": "Jin Yu <jin.yu@intel.com>", "To": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n Tiwei Bie <tiwei.bie@intel.com>, Zhihong Wang <zhihong.wang@intel.com>", "Cc": "dev@dpdk.org, changpeng.liu@intel.com, Jin Yu <jin.yu@intel.com>,\n stable@dpdk.org", "Date": "Wed, 25 Dec 2019 22:18:35 +0800", "Message-Id": "<20191225141835.65587-1-jin.yu@intel.com>", "X-Mailer": "git-send-email 2.17.2", "Subject": "[dpdk-dev] [PATCH] vhost: fix the inflight resubmit check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The frontend may not send the get_inflight_fd and\nset_inflight_fd although we negotiate the protocol\nfeature. When we meet this situation just return OK.\n\nFixes: ad0a4ae491fe (\"vhost: checkout resubmit inflight information\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jin Yu <jin.yu@intel.com>\n---\n lib/librte_vhost/vhost_user.c | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 0cfb8b792..eb0f27c29 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -1629,8 +1629,11 @@ vhost_check_queue_inflights_split(struct virtio_net *dev,\n \t (1ULL << VHOST_USER_PROTOCOL_F_INFLIGHT_SHMFD)))\n \t\treturn RTE_VHOST_MSG_RESULT_OK;\n \n+\t/* The frontend may still not support the inflight feature\n+\t * although we negotiate the protocol feature.\n+\t */\n \tif ((!vq->inflight_split))\n-\t\treturn RTE_VHOST_MSG_RESULT_ERR;\n+\t\treturn RTE_VHOST_MSG_RESULT_OK;\n \n \tif (!vq->inflight_split->version) {\n \t\tvq->inflight_split->version = INFLIGHT_VERSION;\n@@ -1710,8 +1713,11 @@ vhost_check_queue_inflights_packed(struct virtio_net *dev,\n \t (1ULL << VHOST_USER_PROTOCOL_F_INFLIGHT_SHMFD)))\n \t\treturn RTE_VHOST_MSG_RESULT_OK;\n \n+\t/* The frontend may still not support the inflight feature\n+\t * although we negotiate the protocol feature.\n+\t */\n \tif ((!vq->inflight_packed))\n-\t\treturn RTE_VHOST_MSG_RESULT_ERR;\n+\t\treturn RTE_VHOST_MSG_RESULT_OK;\n \n \tif (!vq->inflight_packed->version) {\n \t\tvq->inflight_packed->version = INFLIGHT_VERSION;\n", "prefixes": [] }{ "id": 64126, "url": "