Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 64052,
    "url": "http://patches.dpdk.org/api/patches/64052/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191220044524.32910-5-honnappa.nagarahalli@arm.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20191220044524.32910-5-honnappa.nagarahalli@arm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20191220044524.32910-5-honnappa.nagarahalli@arm.com",
    "date": "2019-12-20T04:45:11",
    "name": "[v7,04/17] test/ring: test burst APIs with random empty-full test case",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "a128dccf293d5bb0c2c484d21e25410c7f9da852",
    "submitter": {
        "id": 1045,
        "url": "http://patches.dpdk.org/api/people/1045/?format=api",
        "name": "Honnappa Nagarahalli",
        "email": "honnappa.nagarahalli@arm.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191220044524.32910-5-honnappa.nagarahalli@arm.com/mbox/",
    "series": [
        {
            "id": 7903,
            "url": "http://patches.dpdk.org/api/series/7903/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7903",
            "date": "2019-12-20T04:45:07",
            "name": "lib/ring: APIs to support custom element size",
            "version": 7,
            "mbox": "http://patches.dpdk.org/series/7903/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/64052/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/64052/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 71DC1A04F3;\n\tFri, 20 Dec 2019 05:46:35 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B2A6D1BF8E;\n\tFri, 20 Dec 2019 05:46:09 +0100 (CET)",
            "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id 4024C1BF75\n for <dev@dpdk.org>; Fri, 20 Dec 2019 05:45:58 +0100 (CET)",
            "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 18CC711B3;\n Thu, 19 Dec 2019 20:45:57 -0800 (PST)",
            "from qc2400f-1.austin.arm.com (qc2400f-1.austin.arm.com\n [10.118.14.48])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0E4CF3F718;\n Thu, 19 Dec 2019 20:45:57 -0800 (PST)"
        ],
        "From": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>",
        "To": "olivier.matz@6wind.com, sthemmin@microsoft.com, jerinj@marvell.com,\n bruce.richardson@intel.com, david.marchand@redhat.com,\n pbhagavatula@marvell.com, konstantin.ananyev@intel.com,\n honnappa.nagarahalli@arm.com",
        "Cc": "dev@dpdk.org, dharmik.thakkar@arm.com, ruifeng.wang@arm.com,\n gavin.hu@arm.com, nd@arm.com",
        "Date": "Thu, 19 Dec 2019 22:45:11 -0600",
        "Message-Id": "<20191220044524.32910-5-honnappa.nagarahalli@arm.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20191220044524.32910-1-honnappa.nagarahalli@arm.com>",
        "References": "<20190906190510.11146-1-honnappa.nagarahalli@arm.com>\n <20191220044524.32910-1-honnappa.nagarahalli@arm.com>",
        "Subject": "[dpdk-dev] [PATCH v7 04/17] test/ring: test burst APIs with random\n\tempty-full test case",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The random empty-full test case should be tested with burst APIs\nas well. Hence the test case is consolidated in\ntest_ring_burst_bulk_tests function.\n\nSigned-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nReviewed-by: Gavin Hu <gavin.hu@arm.com>\n---\n app/test/test_ring.c | 91 +++++++++++++++++++++-----------------------\n 1 file changed, 43 insertions(+), 48 deletions(-)",
    "diff": "diff --git a/app/test/test_ring.c b/app/test/test_ring.c\nindex e7a8b468b..d4f40ad20 100644\n--- a/app/test/test_ring.c\n+++ b/app/test/test_ring.c\n@@ -113,50 +113,6 @@ test_ring_print_test_string(const char *istr, unsigned int api_type, int esize)\n \t\tprintf(\"burst\\n\");\n }\n \n-/*\n- * helper routine for test_ring_basic\n- */\n-static int\n-test_ring_basic_full_empty(struct rte_ring *r, void * const src[], void *dst[])\n-{\n-\tunsigned i, rand;\n-\tconst unsigned rsz = RING_SIZE - 1;\n-\n-\tprintf(\"Basic full/empty test\\n\");\n-\n-\tfor (i = 0; TEST_RING_FULL_EMTPY_ITER != i; i++) {\n-\n-\t\t/* random shift in the ring */\n-\t\trand = RTE_MAX(rte_rand() % RING_SIZE, 1UL);\n-\t\tprintf(\"%s: iteration %u, random shift: %u;\\n\",\n-\t\t    __func__, i, rand);\n-\t\tTEST_RING_VERIFY(rte_ring_enqueue_bulk(r, src, rand,\n-\t\t\t\tNULL) != 0);\n-\t\tTEST_RING_VERIFY(rte_ring_dequeue_bulk(r, dst, rand,\n-\t\t\t\tNULL) == rand);\n-\n-\t\t/* fill the ring */\n-\t\tTEST_RING_VERIFY(rte_ring_enqueue_bulk(r, src, rsz, NULL) != 0);\n-\t\tTEST_RING_VERIFY(0 == rte_ring_free_count(r));\n-\t\tTEST_RING_VERIFY(rsz == rte_ring_count(r));\n-\t\tTEST_RING_VERIFY(rte_ring_full(r));\n-\t\tTEST_RING_VERIFY(0 == rte_ring_empty(r));\n-\n-\t\t/* empty the ring */\n-\t\tTEST_RING_VERIFY(rte_ring_dequeue_bulk(r, dst, rsz,\n-\t\t\t\tNULL) == rsz);\n-\t\tTEST_RING_VERIFY(rsz == rte_ring_free_count(r));\n-\t\tTEST_RING_VERIFY(0 == rte_ring_count(r));\n-\t\tTEST_RING_VERIFY(0 == rte_ring_full(r));\n-\t\tTEST_RING_VERIFY(rte_ring_empty(r));\n-\n-\t\t/* check data */\n-\t\tTEST_RING_VERIFY(0 == memcmp(src, dst, rsz));\n-\t\trte_ring_dump(stdout, r);\n-\t}\n-\treturn 0;\n-}\n-\n static int\n test_ring_basic(struct rte_ring *r)\n {\n@@ -294,9 +250,6 @@ test_ring_basic(struct rte_ring *r)\n \t\tgoto fail;\n \t}\n \n-\tif (test_ring_basic_full_empty(r, src, dst) != 0)\n-\t\tgoto fail;\n-\n \tcur_src = src;\n \tcur_dst = dst;\n \n@@ -371,6 +324,8 @@ test_ring_burst_bulk_tests(unsigned int api_type)\n \tint ret;\n \tunsigned int i, j;\n \tunsigned int num_elems;\n+\tint rand;\n+\tconst unsigned int rsz = RING_SIZE - 1;\n \n \tfor (i = 0; i < RTE_DIM(esize); i++) {\n \t\ttest_ring_print_test_string(\"Test standard ring\", api_type,\n@@ -483,7 +438,6 @@ test_ring_burst_bulk_tests(unsigned int api_type)\n \t\t\tgoto fail;\n \t\tTEST_RING_INCP(cur_src, esize[i], 2);\n \n-\n \t\tprintf(\"Enqueue the remaining entries = MAX_BULK - 3\\n\");\n \t\t/* Bulk APIs enqueue exact number of elements */\n \t\tif ((api_type & TEST_RING_BL) == TEST_RING_BL)\n@@ -546,6 +500,47 @@ test_ring_burst_bulk_tests(unsigned int api_type)\n \t\t\tgoto fail;\n \t\t}\n \n+\t\tprintf(\"Random full/empty test\\n\");\n+\t\tcur_src = src;\n+\t\tcur_dst = dst;\n+\n+\t\tfor (j = 0; j != TEST_RING_FULL_EMTPY_ITER; j++) {\n+\t\t\t/* random shift in the ring */\n+\t\t\trand = RTE_MAX(rte_rand() % RING_SIZE, 1UL);\n+\t\t\tprintf(\"%s: iteration %u, random shift: %u;\\n\",\n+\t\t\t    __func__, i, rand);\n+\t\t\tTEST_RING_ENQUEUE(r, cur_src, esize[i], rand,\n+\t\t\t\t\t\t\tret, api_type);\n+\t\t\tTEST_RING_VERIFY(ret != 0);\n+\n+\t\t\tTEST_RING_DEQUEUE(r, cur_dst, esize[i], rand,\n+\t\t\t\t\t\t\tret, api_type);\n+\t\t\tTEST_RING_VERIFY(ret == rand);\n+\n+\t\t\t/* fill the ring */\n+\t\t\tTEST_RING_ENQUEUE(r, cur_src, esize[i], rsz,\n+\t\t\t\t\t\t\tret, api_type);\n+\t\t\tTEST_RING_VERIFY(ret != 0);\n+\n+\t\t\tTEST_RING_VERIFY(rte_ring_free_count(r) == 0);\n+\t\t\tTEST_RING_VERIFY(rsz == rte_ring_count(r));\n+\t\t\tTEST_RING_VERIFY(rte_ring_full(r));\n+\t\t\tTEST_RING_VERIFY(rte_ring_empty(r) == 0);\n+\n+\t\t\t/* empty the ring */\n+\t\t\tTEST_RING_DEQUEUE(r, cur_dst, esize[i], rsz,\n+\t\t\t\t\t\t\tret, api_type);\n+\t\t\tTEST_RING_VERIFY(ret == (int)rsz);\n+\t\t\tTEST_RING_VERIFY(rsz == rte_ring_free_count(r));\n+\t\t\tTEST_RING_VERIFY(rte_ring_count(r) == 0);\n+\t\t\tTEST_RING_VERIFY(rte_ring_full(r) == 0);\n+\t\t\tTEST_RING_VERIFY(rte_ring_empty(r));\n+\n+\t\t\t/* check data */\n+\t\t\tTEST_RING_VERIFY(memcmp(src, dst, rsz) == 0);\n+\t\t\trte_ring_dump(stdout, r);\n+\t\t}\n+\n \t\t/* Free memory before test completed */\n \t\trte_ring_free(r);\n \t\trte_free(src);\n",
    "prefixes": [
        "v7",
        "04/17"
    ]
}