Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/64042/?format=api
{ "id": 64042, "url": "http://patches.dpdk.org/api/patches/64042/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191220031535.19274-2-chenxux.di@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191220031535.19274-2-chenxux.di@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191220031535.19274-2-chenxux.di@intel.com", "date": "2019-12-20T03:15:31", "name": "[v3,1/5] net/fm10k: cleanup Tx buffers", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "84b7c0f545da6c2a20528fbf1177ded6352a1ebb", "submitter": { "id": 1409, "url": "http://patches.dpdk.org/api/people/1409/?format=api", "name": "Chenxu Di", "email": "chenxux.di@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191220031535.19274-2-chenxux.di@intel.com/mbox/", "series": [ { "id": 7902, "url": "http://patches.dpdk.org/api/series/7902/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7902", "date": "2019-12-20T03:15:30", "name": "drivers/net: cleanup Tx buffers", "version": 3, "mbox": "http://patches.dpdk.org/series/7902/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/64042/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/64042/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F2F5CA04F3;\n\tFri, 20 Dec 2019 04:20:14 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9DE411BF82;\n\tFri, 20 Dec 2019 04:20:12 +0100 (CET)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by dpdk.org (Postfix) with ESMTP id D79331BF78\n for <dev@dpdk.org>; Fri, 20 Dec 2019 04:20:10 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 19 Dec 2019 19:20:10 -0800", "from intel.sh.intel.com ([10.239.255.149])\n by orsmga001.jf.intel.com with ESMTP; 19 Dec 2019 19:20:08 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,334,1571727600\"; d=\"scan'208\";a=\"298908278\"", "From": "Chenxu Di <chenxux.di@intel.com>", "To": "dev@dpdk.org", "Cc": "Yang Qiming <qiming.yang@intel.com>,\n\tChenxu Di <chenxux.di@intel.com>", "Date": "Fri, 20 Dec 2019 03:15:31 +0000", "Message-Id": "<20191220031535.19274-2-chenxux.di@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191220031535.19274-1-chenxux.di@intel.com>", "References": "<20191203055134.72874-1-chenxux.di@intel.com>\n <20191220031535.19274-1-chenxux.di@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 1/5] net/fm10k: cleanup Tx buffers", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add support to the fm10k driver for the API rte_eth_tx_done_cleanup\n to force free consumed buffers on Tx ring.\n\nSigned-off-by: Chenxu Di <chenxux.di@intel.com>\n---\n drivers/net/fm10k/fm10k.h | 2 ++\n drivers/net/fm10k/fm10k_ethdev.c | 1 +\n drivers/net/fm10k/fm10k_rxtx.c | 45 ++++++++++++++++++++++++++++++++\n 3 files changed, 48 insertions(+)", "diff": "diff --git a/drivers/net/fm10k/fm10k.h b/drivers/net/fm10k/fm10k.h\nindex 916b856ac..ddb1d64ec 100644\n--- a/drivers/net/fm10k/fm10k.h\n+++ b/drivers/net/fm10k/fm10k.h\n@@ -342,6 +342,8 @@ uint16_t fm10k_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n uint16_t fm10k_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \tuint16_t nb_pkts);\n \n+int fm10k_tx_done_cleanup(void *txq, uint32_t free_cnt);\n+\n int fm10k_rxq_vec_setup(struct fm10k_rx_queue *rxq);\n int fm10k_rx_vec_condition_check(struct rte_eth_dev *);\n void fm10k_rx_queue_release_mbufs_vec(struct fm10k_rx_queue *rxq);\ndiff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex 407baa16c..c389c79de 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -2897,6 +2897,7 @@ static const struct eth_dev_ops fm10k_eth_dev_ops = {\n \t.reta_query\t\t= fm10k_reta_query,\n \t.rss_hash_update\t= fm10k_rss_hash_update,\n \t.rss_hash_conf_get\t= fm10k_rss_hash_conf_get,\n+\t.tx_done_cleanup = fm10k_tx_done_cleanup,\n };\n \n static int ftag_check_handler(__rte_unused const char *key,\ndiff --git a/drivers/net/fm10k/fm10k_rxtx.c b/drivers/net/fm10k/fm10k_rxtx.c\nindex 5c3112183..f67c5bf00 100644\n--- a/drivers/net/fm10k/fm10k_rxtx.c\n+++ b/drivers/net/fm10k/fm10k_rxtx.c\n@@ -541,6 +541,51 @@ static inline void tx_free_bulk_mbuf(struct rte_mbuf **txep, int num)\n \t}\n }\n \n+int fm10k_tx_done_cleanup(void *txq, uint32_t free_cnt)\n+{\n+\tstruct fm10k_tx_queue *q = (struct fm10k_tx_queue *)txq;\n+\tuint16_t next_rs, count = 0;\n+\n+\tif (q == NULL)\n+\t\treturn -ENODEV;\n+\n+\tnext_rs = fifo_peek(&q->rs_tracker);\n+\tif (!(q->hw_ring[next_rs].flags & FM10K_TXD_FLAG_DONE))\n+\t\treturn count;\n+\n+\t/* the DONE flag is set on this descriptor so remove the ID\n+\t * from the RS bit tracker and free the buffers\n+\t */\n+\tfifo_remove(&q->rs_tracker);\n+\n+\t/* wrap around? if so, free buffers from last_free up to but NOT\n+\t * including nb_desc\n+\t */\n+\tif (q->last_free > next_rs) {\n+\t\tcount = q->nb_desc - q->last_free;\n+\t\ttx_free_bulk_mbuf(&q->sw_ring[q->last_free], count);\n+\t\tq->last_free = 0;\n+\n+\t\tif (unlikely(count == (int)free_cnt))\n+\t\t\treturn count;\n+\t}\n+\n+\t/* adjust free descriptor count before the next loop */\n+\tq->nb_free += count + (next_rs + 1 - q->last_free);\n+\n+\t/* free buffers from last_free, up to and including next_rs */\n+\tif (q->last_free <= next_rs) {\n+\t\tcount = next_rs - q->last_free + 1;\n+\t\ttx_free_bulk_mbuf(&q->sw_ring[q->last_free], count);\n+\t\tq->last_free += count;\n+\t}\n+\n+\tif (q->last_free == q->nb_desc)\n+\t\tq->last_free = 0;\n+\n+\treturn count;\n+}\n+\n static inline void tx_free_descriptors(struct fm10k_tx_queue *q)\n {\n \tuint16_t next_rs, count = 0;\n", "prefixes": [ "v3", "1/5" ] }