Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63873/?format=api
{ "id": 63873, "url": "http://patches.dpdk.org/api/patches/63873/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191214102934.50491-8-huwei013@chinasoftinc.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191214102934.50491-8-huwei013@chinasoftinc.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191214102934.50491-8-huwei013@chinasoftinc.com", "date": "2019-12-14T10:29:32", "name": "[v2,7/9] net/hns3: remove the redundant variable initialization", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d4629f0bf29555520b37be24c95af89596ac2311", "submitter": { "id": 1537, "url": "http://patches.dpdk.org/api/people/1537/?format=api", "name": "Wei Hu (Xavier)", "email": "huwei013@chinasoftinc.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191214102934.50491-8-huwei013@chinasoftinc.com/mbox/", "series": [ { "id": 7833, "url": "http://patches.dpdk.org/api/series/7833/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7833", "date": "2019-12-14T10:29:29", "name": "updates for hns3 PMD driver", "version": 2, "mbox": "http://patches.dpdk.org/series/7833/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63873/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63873/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A1131A04F1;\n\tSat, 14 Dec 2019 11:31:16 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 515C11BFDB;\n\tSat, 14 Dec 2019 11:30:34 +0100 (CET)", "from incedge.chinasoftinc.com (unknown [114.113.233.8])\n by dpdk.org (Postfix) with ESMTP id 878361BF96\n for <dev@dpdk.org>; Sat, 14 Dec 2019 11:30:21 +0100 (CET)", "from mail.chinasoftinc.com (inccas002.ito.icss [10.168.0.52]) by\n incedge.chinasoftinc.com with ESMTP id vhKcTxW1ABTGd7Ll (version=TLSv1\n cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO) for <dev@dpdk.org>;\n Sat, 14 Dec 2019 18:30:09 +0800 (CST)", "from localhost.localdomain (203.160.91.226) by INCCAS002.ito.icss\n (10.168.0.60) with Microsoft SMTP Server id 14.3.439.0; Sat, 14 Dec 2019\n 18:30:08 +0800" ], "X-ASG-Debug-ID": "1576319405-0a3dd1322c5fe70008-TfluYd", "X-Barracuda-Envelope-From": "huwei013@chinasoftinc.com", "X-Barracuda-RBL-Trusted-Forwarder": [ "10.168.0.52", "10.168.0.60" ], "X-ASG-Whitelist": "Client", "From": "\"Wei Hu (Xavier)\" <huwei013@chinasoftinc.com>", "To": "<dev@dpdk.org>", "Date": "Sat, 14 Dec 2019 18:29:32 +0800", "X-ASG-Orig-Subj": "[PATCH v2 7/9] net/hns3: remove the redundant variable\n initialization", "Message-ID": "<20191214102934.50491-8-huwei013@chinasoftinc.com>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191214102934.50491-1-huwei013@chinasoftinc.com>", "References": "<20191214102934.50491-1-huwei013@chinasoftinc.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[203.160.91.226]", "X-Barracuda-Connect": "inccas002.ito.icss[10.168.0.52]", "X-Barracuda-Start-Time": "1576319409", "X-Barracuda-Encrypted": "ECDHE-RSA-AES256-SHA", "X-Barracuda-URL": "https://spam.chinasoftinc.com:443/cgi-mod/mark.cgi", "X-Virus-Scanned": "by bsmtpd at chinasoftinc.com", "X-Barracuda-Scan-Msg-Size": "2814", "Subject": "[dpdk-dev] [PATCH v2 7/9] net/hns3: remove the redundant variable\n\tinitialization", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: \"Wei Hu (Xavier)\" <xavier.huwei@huawei.com>\n\nThis patch removes the redundant initialization of the variable\nnamed ret.\n\nSigned-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>\nSigned-off-by: Hao Chen <chenhao164@huawei.com>\nSigned-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 10 +++++-----\n drivers/net/hns3/hns3_ethdev_vf.c | 2 +-\n 2 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex 981e05b61..a675c2064 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -3597,7 +3597,7 @@ hns3_dev_promiscuous_enable(struct rte_eth_dev *dev)\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n \tstruct hns3_hw *hw = &hns->hw;\n \tbool en_mc_pmc = (dev->data->all_multicast == 1) ? true : false;\n-\tint ret = 0;\n+\tint ret;\n \n \trte_spinlock_lock(&hw->lock);\n \tret = hns3_set_promisc_mode(hw, true, en_mc_pmc);\n@@ -3614,7 +3614,7 @@ hns3_dev_promiscuous_disable(struct rte_eth_dev *dev)\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n \tstruct hns3_hw *hw = &hns->hw;\n \tbool en_mc_pmc = (dev->data->all_multicast == 1) ? true : false;\n-\tint ret = 0;\n+\tint ret;\n \n \t/* If now in all_multicast mode, must remain in all_multicast mode. */\n \trte_spinlock_lock(&hw->lock);\n@@ -3632,7 +3632,7 @@ hns3_dev_allmulticast_enable(struct rte_eth_dev *dev)\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n \tstruct hns3_hw *hw = &hns->hw;\n \tbool en_uc_pmc = (dev->data->promiscuous == 1) ? true : false;\n-\tint ret = 0;\n+\tint ret;\n \n \trte_spinlock_lock(&hw->lock);\n \tret = hns3_set_promisc_mode(hw, en_uc_pmc, true);\n@@ -3649,7 +3649,7 @@ hns3_dev_allmulticast_disable(struct rte_eth_dev *dev)\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n \tstruct hns3_hw *hw = &hns->hw;\n \tbool en_uc_pmc = (dev->data->promiscuous == 1) ? true : false;\n-\tint ret = 0;\n+\tint ret;\n \n \t/* If now in promiscuous mode, must remain in all_multicast mode. */\n \tif (dev->data->promiscuous == 1)\n@@ -4135,7 +4135,7 @@ hns3_dev_start(struct rte_eth_dev *dev)\n {\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n \tstruct hns3_hw *hw = &hns->hw;\n-\tint ret = 0;\n+\tint ret;\n \n \tPMD_INIT_FUNC_TRACE();\n \tif (rte_atomic16_read(&hw->reset.resetting))\ndiff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c\nindex 46d3efad0..45e061d96 100644\n--- a/drivers/net/hns3/hns3_ethdev_vf.c\n+++ b/drivers/net/hns3/hns3_ethdev_vf.c\n@@ -1465,7 +1465,7 @@ hns3vf_dev_start(struct rte_eth_dev *dev)\n {\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n \tstruct hns3_hw *hw = &hns->hw;\n-\tint ret = 0;\n+\tint ret;\n \n \tPMD_INIT_FUNC_TRACE();\n \tif (rte_atomic16_read(&hw->reset.resetting))\n", "prefixes": [ "v2", "7/9" ] }