Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63869/?format=api
{ "id": 63869, "url": "http://patches.dpdk.org/api/patches/63869/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191214102934.50491-3-huwei013@chinasoftinc.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191214102934.50491-3-huwei013@chinasoftinc.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191214102934.50491-3-huwei013@chinasoftinc.com", "date": "2019-12-14T10:29:27", "name": "[v2,2/9] net/hns3: get link state change through mailbox", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7b8460b4d6c1baf00a8ad619a4aaa6c5b8c85152", "submitter": { "id": 1537, "url": "http://patches.dpdk.org/api/people/1537/?format=api", "name": "Wei Hu (Xavier)", "email": "huwei013@chinasoftinc.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191214102934.50491-3-huwei013@chinasoftinc.com/mbox/", "series": [ { "id": 7833, "url": "http://patches.dpdk.org/api/series/7833/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7833", "date": "2019-12-14T10:29:29", "name": "updates for hns3 PMD driver", "version": 2, "mbox": "http://patches.dpdk.org/series/7833/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63869/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63869/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BB4D5A04F1;\n\tSat, 14 Dec 2019 11:30:38 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 87C731BFB5;\n\tSat, 14 Dec 2019 11:30:26 +0100 (CET)", "from incedge.chinasoftinc.com (unknown [114.113.233.8])\n by dpdk.org (Postfix) with ESMTP id 369061BF96\n for <dev@dpdk.org>; Sat, 14 Dec 2019 11:30:20 +0100 (CET)", "from mail.chinasoftinc.com (inccas002.ito.icss [10.168.0.52]) by\n incedge.chinasoftinc.com with ESMTP id tndg1VoJQXAeGf4u (version=TLSv1\n cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO) for <dev@dpdk.org>;\n Sat, 14 Dec 2019 18:30:06 +0800 (CST)", "from localhost.localdomain (203.160.91.226) by INCCAS002.ito.icss\n (10.168.0.60) with Microsoft SMTP Server id 14.3.439.0; Sat, 14 Dec 2019\n 18:30:06 +0800" ], "X-ASG-Debug-ID": "1576319405-0a3dd1322c5fe70003-TfluYd", "X-Barracuda-Envelope-From": "huwei013@chinasoftinc.com", "X-Barracuda-RBL-Trusted-Forwarder": [ "10.168.0.52", "10.168.0.60" ], "X-ASG-Whitelist": "Client", "From": "\"Wei Hu (Xavier)\" <huwei013@chinasoftinc.com>", "To": "<dev@dpdk.org>", "Date": "Sat, 14 Dec 2019 18:29:27 +0800", "X-ASG-Orig-Subj": "[PATCH v2 2/9] net/hns3: get link state change through\n mailbox", "Message-ID": "<20191214102934.50491-3-huwei013@chinasoftinc.com>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191214102934.50491-1-huwei013@chinasoftinc.com>", "References": "<20191214102934.50491-1-huwei013@chinasoftinc.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[203.160.91.226]", "X-Barracuda-Connect": "inccas002.ito.icss[10.168.0.52]", "X-Barracuda-Start-Time": "1576319406", "X-Barracuda-Encrypted": "ECDHE-RSA-AES256-SHA", "X-Barracuda-URL": "https://spam.chinasoftinc.com:443/cgi-mod/mark.cgi", "X-Virus-Scanned": "by bsmtpd at chinasoftinc.com", "X-Barracuda-Scan-Msg-Size": "5960", "Subject": "[dpdk-dev] [PATCH v2 2/9] net/hns3: get link state change through\n\tmailbox", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Hongbo Zheng <zhenghongbo3@huawei.com>\n\nCurrently, firmware adds the function of sending message to PF driver\nthrough mailbox when the link status is changed, hns3 PMD driver can\nusually recognize link state change faster through the message.\n\nAnd in some extreme cases, this way is not faster than existing method\nregularly updating link status by issing the command every second in PF\ndriver, because of the parallel processing of mailbox and command messages\nin firmware. So we reserve updating link status using timers in PF driver,\nand add querying link status by issuing command to the firmware in\n'.link_update' ops implementation function named hns3_dev_link_update to\nsolve the out of date link status.\n\nSigned-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>\nSigned-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\n---\nv1 -> v2:\n\t1.Add querying link status by issuing command to the firmware\n\t in '.link_update' ops implementation function named\n\t hns3_dev_link_update to solve the out of date link status.\n---\n drivers/net/hns3/hns3_ethdev.c | 14 +++++++++++--\n drivers/net/hns3/hns3_ethdev.h | 1 +\n drivers/net/hns3/hns3_mbx.c | 37 ++++++++++++++++++++++++++++++++++\n drivers/net/hns3/hns3_mbx.h | 8 ++++++++\n 4 files changed, 58 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex bf0ab458f..5795b3b34 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -77,6 +77,7 @@ static enum hns3_reset_level hns3_get_reset_level(struct hns3_adapter *hns,\n static int hns3_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);\n static int hns3_vlan_pvid_configure(struct hns3_adapter *hns, uint16_t pvid,\n \t\t\t\t int on);\n+static int hns3_update_speed_duplex(struct rte_eth_dev *eth_dev);\n \n static void\n hns3_pf_disable_irq0(struct hns3_hw *hw)\n@@ -218,6 +219,8 @@ hns3_interrupt_handler(void *param)\n \t\thns3_schedule_reset(hns);\n \t} else if (event_cause == HNS3_VECTOR0_EVENT_RST)\n \t\thns3_schedule_reset(hns);\n+\telse if (event_cause == HNS3_VECTOR0_EVENT_MBX)\n+\t\thns3_dev_handle_mbx_msg(hw);\n \telse\n \t\thns3_err(hw, \"Received unknown event\");\n \n@@ -2302,6 +2305,11 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev,\n \tstruct hns3_mac *mac = &hw->mac;\n \tstruct rte_eth_link new_link;\n \n+\tif (!hns3_is_reset_pending(hns)) {\n+\t\thns3_update_speed_duplex(eth_dev);\n+\t\thns3_update_link_status(hw);\n+\t}\n+\n \tmemset(&new_link, 0, sizeof(new_link));\n \tswitch (mac->link_speed) {\n \tcase ETH_SPEED_NUM_10M:\n@@ -3806,14 +3814,16 @@ hns3_get_mac_link_status(struct hns3_hw *hw)\n \treturn !!link_status;\n }\n \n-static void\n+void\n hns3_update_link_status(struct hns3_hw *hw)\n {\n \tint state;\n \n \tstate = hns3_get_mac_link_status(hw);\n-\tif (state != hw->mac.link_status)\n+\tif (state != hw->mac.link_status) {\n \t\thw->mac.link_status = state;\n+\t\thns3_warn(hw, \"Link status change to %s!\", state ? \"up\" : \"down\");\n+\t}\n }\n \n static void\ndiff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h\nindex e9a3fe410..004cd75a9 100644\n--- a/drivers/net/hns3/hns3_ethdev.h\n+++ b/drivers/net/hns3/hns3_ethdev.h\n@@ -631,6 +631,7 @@ int hns3_dev_filter_ctrl(struct rte_eth_dev *dev,\n \t\t\t enum rte_filter_op filter_op, void *arg);\n bool hns3_is_reset_pending(struct hns3_adapter *hns);\n bool hns3vf_is_reset_pending(struct hns3_adapter *hns);\n+void hns3_update_link_status(struct hns3_hw *hw);\n \n static inline bool\n is_reset_pending(struct hns3_adapter *hns)\ndiff --git a/drivers/net/hns3/hns3_mbx.c b/drivers/net/hns3/hns3_mbx.c\nindex c1647af4b..26807bc4b 100644\n--- a/drivers/net/hns3/hns3_mbx.c\n+++ b/drivers/net/hns3/hns3_mbx.c\n@@ -282,6 +282,40 @@ hns3_update_resp_position(struct hns3_hw *hw, uint32_t resp_msg)\n \tresp->tail = tail;\n }\n \n+static void\n+hns3_link_fail_parse(struct hns3_hw *hw, uint8_t link_fail_code)\n+{\n+\tswitch (link_fail_code) {\n+\tcase HNS3_MBX_LF_NORMAL:\n+\t\tbreak;\n+\tcase HNS3_MBX_LF_REF_CLOCK_LOST:\n+\t\thns3_warn(hw, \"Reference clock lost!\");\n+\t\tbreak;\n+\tcase HNS3_MBX_LF_XSFP_TX_DISABLE:\n+\t\thns3_warn(hw, \"SFP tx is disabled!\");\n+\t\tbreak;\n+\tcase HNS3_MBX_LF_XSFP_ABSENT:\n+\t\thns3_warn(hw, \"SFP is absent!\");\n+\t\tbreak;\n+\tdefault:\n+\t\thns3_warn(hw, \"Unknown fail code:%u!\", link_fail_code);\n+\t\tbreak;\n+\t}\n+}\n+\n+static void\n+hns3_handle_link_change_event(struct hns3_hw *hw,\n+\t\t\t struct hns3_mbx_pf_to_vf_cmd *req)\n+{\n+#define LINK_STATUS_OFFSET 1\n+#define LINK_FAIL_CODE_OFFSET 2\n+\n+\tif (!req->msg[LINK_STATUS_OFFSET])\n+\t\thns3_link_fail_parse(hw, req->msg[LINK_FAIL_CODE_OFFSET]);\n+\n+\thns3_update_link_status(hw);\n+}\n+\n void\n hns3_dev_handle_mbx_msg(struct hns3_hw *hw)\n {\n@@ -335,6 +369,9 @@ hns3_dev_handle_mbx_msg(struct hns3_hw *hw)\n \n \t\t\thns3_mbx_handler(hw);\n \t\t\tbreak;\n+\t\tcase HNS3_MBX_PUSH_LINK_STATUS:\n+\t\t\thns3_handle_link_change_event(hw, req);\n+\t\t\tbreak;\n \t\tdefault:\n \t\t\thns3_err(hw,\n \t\t\t\t \"VF received unsupported(%d) mbx msg from PF\",\ndiff --git a/drivers/net/hns3/hns3_mbx.h b/drivers/net/hns3/hns3_mbx.h\nindex d1a6bfead..3722c8760 100644\n--- a/drivers/net/hns3/hns3_mbx.h\n+++ b/drivers/net/hns3/hns3_mbx.h\n@@ -41,6 +41,7 @@ enum HNS3_MBX_OPCODE {\n \tHNS3_MBX_GET_QID_IN_PF, /* (VF -> PF) get queue id in pf */\n \n \tHNS3_MBX_HANDLE_VF_TBL = 38, /* (VF -> PF) store/clear hw cfg tbl */\n+\tHNS3_MBX_PUSH_LINK_STATUS = 201, /* (IMP -> PF) get port link status */\n };\n \n /* below are per-VF mac-vlan subcodes */\n@@ -64,6 +65,13 @@ enum hns3_mbx_tbl_cfg_subcode {\n \tHNS3_MBX_VPORT_LIST_CLEAR = 0,\n };\n \n+enum hns3_mbx_link_fail_subcode {\n+\tHNS3_MBX_LF_NORMAL = 0,\n+\tHNS3_MBX_LF_REF_CLOCK_LOST,\n+\tHNS3_MBX_LF_XSFP_TX_DISABLE,\n+\tHNS3_MBX_LF_XSFP_ABSENT,\n+};\n+\n #define HNS3_MBX_MAX_MSG_SIZE\t16\n #define HNS3_MBX_MAX_RESP_DATA_SIZE\t8\n #define HNS3_MBX_RING_MAP_BASIC_MSG_NUM\t3\n", "prefixes": [ "v2", "2/9" ] }