Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63868/?format=api
{ "id": 63868, "url": "http://patches.dpdk.org/api/patches/63868/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191214102934.50491-6-huwei013@chinasoftinc.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191214102934.50491-6-huwei013@chinasoftinc.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191214102934.50491-6-huwei013@chinasoftinc.com", "date": "2019-12-14T10:29:30", "name": "[v2,5/9] net/hns3: optimize RSS's default algorithm", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d478bfdf6106fb1fedf0d9baecc42523d56c67f1", "submitter": { "id": 1537, "url": "http://patches.dpdk.org/api/people/1537/?format=api", "name": "Wei Hu (Xavier)", "email": "huwei013@chinasoftinc.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191214102934.50491-6-huwei013@chinasoftinc.com/mbox/", "series": [ { "id": 7833, "url": "http://patches.dpdk.org/api/series/7833/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7833", "date": "2019-12-14T10:29:29", "name": "updates for hns3 PMD driver", "version": 2, "mbox": "http://patches.dpdk.org/series/7833/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63868/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63868/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6B04AA04F1;\n\tSat, 14 Dec 2019 11:30:31 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B50971BFAD;\n\tSat, 14 Dec 2019 11:30:24 +0100 (CET)", "from incedge.chinasoftinc.com (unknown [114.113.233.8])\n by dpdk.org (Postfix) with ESMTP id 39D761BF9D\n for <dev@dpdk.org>; Sat, 14 Dec 2019 11:30:20 +0100 (CET)", "from mail.chinasoftinc.com (inccas002.ito.icss [10.168.0.52]) by\n incedge.chinasoftinc.com with ESMTP id 9fkgKU5k7WKX1TJx (version=TLSv1\n cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO) for <dev@dpdk.org>;\n Sat, 14 Dec 2019 18:30:08 +0800 (CST)", "from localhost.localdomain (203.160.91.226) by INCCAS002.ito.icss\n (10.168.0.60) with Microsoft SMTP Server id 14.3.439.0; Sat, 14 Dec 2019\n 18:30:07 +0800" ], "X-ASG-Debug-ID": "1576319405-0a3dd1322c5fe70006-TfluYd", "X-Barracuda-Envelope-From": "huwei013@chinasoftinc.com", "X-Barracuda-RBL-Trusted-Forwarder": [ "10.168.0.52", "10.168.0.60" ], "X-ASG-Whitelist": "Client", "From": "\"Wei Hu (Xavier)\" <huwei013@chinasoftinc.com>", "To": "<dev@dpdk.org>", "Date": "Sat, 14 Dec 2019 18:29:30 +0800", "X-ASG-Orig-Subj": "[PATCH v2 5/9] net/hns3: optimize RSS's default algorithm", "Message-ID": "<20191214102934.50491-6-huwei013@chinasoftinc.com>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191214102934.50491-1-huwei013@chinasoftinc.com>", "References": "<20191214102934.50491-1-huwei013@chinasoftinc.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[203.160.91.226]", "X-Barracuda-Connect": "inccas002.ito.icss[10.168.0.52]", "X-Barracuda-Start-Time": "1576319408", "X-Barracuda-Encrypted": "ECDHE-RSA-AES256-SHA", "X-Barracuda-URL": "https://spam.chinasoftinc.com:443/cgi-mod/mark.cgi", "X-Virus-Scanned": "by bsmtpd at chinasoftinc.com", "X-Barracuda-Scan-Msg-Size": "2117", "Subject": "[dpdk-dev] [PATCH v2 5/9] net/hns3: optimize RSS's default algorithm", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Hao Chen <chenhao164@huawei.com>\n\nThis patch changed the default algorithm of RSS from simle_xor to\ntoeplitz because toeplitz is used more frequently by upper applications\nsuch as ceph.\n\nSigned-off-by: Hao Chen <chenhao164@huawei.com>\nSigned-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>\n---\n drivers/net/hns3/hns3_rss.c | 14 +++++++++++---\n 1 file changed, 11 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c\nindex b8c20e6d9..dfc42f840 100644\n--- a/drivers/net/hns3/hns3_rss.c\n+++ b/drivers/net/hns3/hns3_rss.c\n@@ -211,7 +211,11 @@ hns3_set_rss_tuple_by_rss_hf(struct hns3_hw *hw,\n \t\t\treq->ipv6_fragment_en |= HNS3_IP_OTHER_BIT_MASK;\n \t\t\tbreak;\n \t\tdefault:\n-\t\t\t/* Other unsupported flow types won't change tuples */\n+\t\t\t/*\n+\t\t\t * rss_hf doesn't include unsupported flow types\n+\t\t\t * because the API framework has checked it, and\n+\t\t\t * this branch will never go unless rss_hf is zero.\n+\t\t\t */\n \t\t\tbreak;\n \t\t}\n \t}\n@@ -251,8 +255,8 @@ hns3_dev_rss_hash_update(struct rte_eth_dev *dev,\n \tstruct hns3_hw *hw = &hns->hw;\n \tstruct hns3_rss_tuple_cfg *tuple = &hw->rss_info.rss_tuple_sets;\n \tstruct hns3_rss_conf *rss_cfg = &hw->rss_info;\n-\tuint8_t algo = rss_cfg->conf.func;\n \tuint8_t key_len = rss_conf->rss_key_len;\n+\tuint8_t algo;\n \tuint64_t rss_hf = rss_conf->rss_hf;\n \tuint8_t *key = rss_conf->rss_key;\n \tint ret;\n@@ -285,6 +289,8 @@ hns3_dev_rss_hash_update(struct rte_eth_dev *dev,\n \t\t\tret = -EINVAL;\n \t\t\tgoto conf_err;\n \t\t}\n+\t\talgo = rss_cfg->conf.func == RTE_ETH_HASH_FUNCTION_SIMPLE_XOR ?\n+\t\t\tHNS3_RSS_HASH_ALGO_SIMPLE : HNS3_RSS_HASH_ALGO_TOEPLITZ;\n \t\tret = hns3_set_rss_algo_key(hw, algo, key);\n \t\tif (ret)\n \t\t\tgoto conf_err;\n@@ -500,7 +506,9 @@ hns3_set_default_rss_args(struct hns3_hw *hw)\n \tint i;\n \n \t/* Default hash algorithm */\n-\trss_cfg->conf.func = RTE_ETH_HASH_FUNCTION_SIMPLE_XOR;\n+\trss_cfg->conf.func = RTE_ETH_HASH_FUNCTION_TOEPLITZ;\n+\n+\t/* Default RSS key */\n \tmemcpy(rss_cfg->key, hns3_hash_key, HNS3_RSS_KEY_SIZE);\n \n \t/* Initialize RSS indirection table */\n", "prefixes": [ "v2", "5/9" ] }