Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63851/?format=api
{ "id": 63851, "url": "http://patches.dpdk.org/api/patches/63851/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191213233554.90866-1-chenmin.sun@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191213233554.90866-1-chenmin.sun@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191213233554.90866-1-chenmin.sun@intel.com", "date": "2019-12-13T23:35:54", "name": "[FDIO] dpdk: add devargs support", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "78981549fb1b032d823a9a3f27cb75873606d8a7", "submitter": { "id": 1212, "url": "http://patches.dpdk.org/api/people/1212/?format=api", "name": "Chenmin Sun", "email": "chenmin.sun@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191213233554.90866-1-chenmin.sun@intel.com/mbox/", "series": [ { "id": 7827, "url": "http://patches.dpdk.org/api/series/7827/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7827", "date": "2019-12-13T23:35:54", "name": "[FDIO] dpdk: add devargs support", "version": 1, "mbox": "http://patches.dpdk.org/series/7827/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63851/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63851/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B9BA8A04F1;\n\tFri, 13 Dec 2019 15:36:46 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F2EBD1BFAD;\n\tFri, 13 Dec 2019 15:36:45 +0100 (CET)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by dpdk.org (Postfix) with ESMTP id AC9851BF75\n for <dev@dpdk.org>; Fri, 13 Dec 2019 15:36:43 +0100 (CET)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 13 Dec 2019 06:36:42 -0800", "from npg-dpdk-vpp-scm-1.sh.intel.com ([10.67.118.248])\n by FMSMGA003.fm.intel.com with ESMTP; 13 Dec 2019 06:36:41 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,309,1571727600\"; d=\"scan'208\";a=\"265545300\"", "From": "chenmin.sun@intel.com", "To": "dev@dpdk.org", "Date": "Sat, 14 Dec 2019 07:35:54 +0800", "Message-Id": "<20191213233554.90866-1-chenmin.sun@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [FDIO] dpdk: add devargs support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Chenmin Sun <chenmin.sun@intel.com>\n\nType: feature\n\nThis patch adds the devargs support for dpdk device\nThe devargs are used as hardware-specific init args for dpdk devices\nplease refer to the nic guides under\n$(DPDK_DIR)/doc/guides/nics/$(NIC_DRIVER).rst\n\nSigned-off-by: Chenmin Sun <chenmin.sun@intel.com>\nChange-Id: Id380d04720090bb66afe5ce09d664e5e248b8eb9\n---\n src/plugins/dpdk/device/dpdk.h | 2 ++\n src/plugins/dpdk/device/format.c | 3 +++\n src/plugins/dpdk/device/init.c | 36 +++++++++++++++++++++-----------\n src/vpp/conf/startup.conf | 5 +++++\n 4 files changed, 34 insertions(+), 12 deletions(-)", "diff": "diff --git a/src/plugins/dpdk/device/dpdk.h b/src/plugins/dpdk/device/dpdk.h\nindex d58d2daa7..ab28ac06a 100644\n--- a/src/plugins/dpdk/device/dpdk.h\n+++ b/src/plugins/dpdk/device/dpdk.h\n@@ -336,6 +336,8 @@ typedef struct\n u32 hqos_enabled;\n dpdk_device_config_hqos_t hqos;\n u8 tso;\n+ u8 *devargs;\n+\n #define DPDK_DEVICE_TSO_DEFAULT 0\n #define DPDK_DEVICE_TSO_OFF 1\n #define DPDK_DEVICE_TSO_ON 2\ndiff --git a/src/plugins/dpdk/device/format.c b/src/plugins/dpdk/device/format.c\nindex 292c083fc..20493eb77 100644\n--- a/src/plugins/dpdk/device/format.c\n+++ b/src/plugins/dpdk/device/format.c\n@@ -564,6 +564,9 @@ format_dpdk_device (u8 * s, va_list * args)\n \t format_white_space, indent + 2, format_dpdk_link_status, xd);\n s = format (s, \"%Uflags: %U\\n\",\n \t format_white_space, indent + 2, format_dpdk_device_flags, xd);\n+ if (di.device->devargs && di.device->devargs->args)\n+ s = format (s, \"%UDevargs: %s\\n\",\n+\t\tformat_white_space, indent + 2, di.device->devargs->args);\n s = format (s, \"%Urx: queues %d (max %d), desc %d \"\n \t \"(min %d max %d align %d)\\n\",\n \t format_white_space, indent + 2, xd->rx_q_used, di.max_rx_queues,\ndiff --git a/src/plugins/dpdk/device/init.c b/src/plugins/dpdk/device/init.c\nindex 5a6262c30..d0125e939 100644\n--- a/src/plugins/dpdk/device/init.c\n+++ b/src/plugins/dpdk/device/init.c\n@@ -1118,6 +1118,8 @@ dpdk_device_config (dpdk_config_main_t * conf, vlib_pci_addr_t pci_addr,\n \t{\n \t devconf->tso = DPDK_DEVICE_TSO_OFF;\n \t}\n+ else if (unformat (input, \"devargs %s\", &devconf->devargs))\n+\t;\n else\n \t{\n \t error = clib_error_return (0, \"unknown input `%U'\",\n@@ -1428,21 +1430,31 @@ dpdk_config (vlib_main_t * vm, unformat_input_t * input)\n \t/* copy tso config from default device */\n \t_(tso)\n \n+\t/* copy tso config from default device */\n+\t_(devargs)\n+\n /* add DPDK EAL whitelist/blacklist entry */\n if (num_whitelisted > 0 && devconf->is_blacklisted == 0)\n- {\n-\ttmp = format (0, \"-w%c\", 0);\n-\tvec_add1 (conf->eal_init_args, tmp);\n-\ttmp = format (0, \"%U%c\", format_vlib_pci_addr, &devconf->pci_addr, 0);\n-\tvec_add1 (conf->eal_init_args, tmp);\n- }\n+ {\n+\t tmp = format (0, \"-w%c\", 0);\n+\t vec_add1 (conf->eal_init_args, tmp);\n+\t if (devconf->devargs)\n+\t {\n+\t tmp = format (0, \"%U,%s\", format_vlib_pci_addr, &devconf->pci_addr, devconf->devargs, 0);\n+\t }\n+\t else\n+\t {\n+\t tmp = format (0, \"%U%c\", format_vlib_pci_addr, &devconf->pci_addr, 0);\n+\t }\n+\t vec_add1 (conf->eal_init_args, tmp);\n+ }\n else if (num_whitelisted == 0 && devconf->is_blacklisted != 0)\n- {\n-\ttmp = format (0, \"-b%c\", 0);\n-\tvec_add1 (conf->eal_init_args, tmp);\n-\ttmp = format (0, \"%U%c\", format_vlib_pci_addr, &devconf->pci_addr, 0);\n-\tvec_add1 (conf->eal_init_args, tmp);\n- }\n+ {\n+\t tmp = format (0, \"-b%c\", 0);\n+\t vec_add1 (conf->eal_init_args, tmp);\n+\t tmp = format (0, \"%U%c\", format_vlib_pci_addr, &devconf->pci_addr, 0);\n+\t vec_add1 (conf->eal_init_args, tmp);\n+ }\n }));\n /* *INDENT-ON* */\n \ndiff --git a/src/vpp/conf/startup.conf b/src/vpp/conf/startup.conf\nindex 3d83a1336..b0d0c8664 100644\n--- a/src/vpp/conf/startup.conf\n+++ b/src/vpp/conf/startup.conf\n@@ -105,6 +105,11 @@ cpu {\n \t\t## Default is off\n \t\t## To enable TSO, 'enable-tcp-udp-checksum' must be set\n \t\t# tso on\n+\n+\t\t## Devargs\n+ ## device specific init args\n+ ## Default is NULL\n+\t\t# devargs safe-mode-support=1,pipeline-mode-support=1\n \t# }\n \n \t## Whitelist specific interface by specifying PCI address\n", "prefixes": [ "FDIO" ] }