Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63824/?format=api
{ "id": 63824, "url": "http://patches.dpdk.org/api/patches/63824/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191212152124.260629-33-xiaolong.ye@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191212152124.260629-33-xiaolong.ye@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191212152124.260629-33-xiaolong.ye@intel.com", "date": "2019-12-12T15:21:20", "name": "[v2,32/36] net/i40e/base: exposing missing LED functionality", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "d9b8f3737a60567914104c25feed4d1dbcfa982c", "submitter": { "id": 1120, "url": "http://patches.dpdk.org/api/people/1120/?format=api", "name": "Xiaolong Ye", "email": "xiaolong.ye@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191212152124.260629-33-xiaolong.ye@intel.com/mbox/", "series": [ { "id": 7813, "url": "http://patches.dpdk.org/api/series/7813/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7813", "date": "2019-12-12T15:20:48", "name": "update for i40e base code", "version": 2, "mbox": "http://patches.dpdk.org/series/7813/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63824/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63824/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8DD8CA04F5;\n\tThu, 12 Dec 2019 16:33:44 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0AF8D1BE9D;\n\tThu, 12 Dec 2019 16:29:13 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 2CF9C1BFB4\n for <dev@dpdk.org>; Thu, 12 Dec 2019 16:28:35 +0100 (CET)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 12 Dec 2019 07:28:34 -0800", "from dpdk_yexl_af_xdp.sh.intel.com ([10.67.119.186])\n by orsmga006.jf.intel.com with ESMTP; 12 Dec 2019 07:28:34 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,306,1571727600\"; d=\"scan'208\";a=\"216148435\"", "From": "Xiaolong Ye <xiaolong.ye@intel.com>", "To": "Beilei Xing <beilei.xing@intel.com>,\n\tQi Zhang <qi.z.zhang@intel.com>", "Cc": "dev@dpdk.org,\n\tXiaolong Ye <xiaolong.ye@intel.com>", "Date": "Thu, 12 Dec 2019 23:21:20 +0800", "Message-Id": "<20191212152124.260629-33-xiaolong.ye@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191212152124.260629-1-xiaolong.ye@intel.com>", "References": "<20191202074935.97629-1-xiaolong.ye@intel.com>\n <20191212152124.260629-1-xiaolong.ye@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 32/36] net/i40e/base: exposing missing LED\n\tfunctionality", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The previous code had the LED code wrapped such that, it was\nstatic to the file and not usable outside of it. It is now available.\n\nSigned-off-by: Xiaolong Ye <xiaolong.ye@intel.com>\n---\n drivers/net/i40e/base/i40e_common.c | 8 ++++----\n drivers/net/i40e/base/i40e_prototype.h | 5 ++++-\n 2 files changed, 8 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c\nindex d90012fd7..d0cb53a9d 100644\n--- a/drivers/net/i40e/base/i40e_common.c\n+++ b/drivers/net/i40e/base/i40e_common.c\n@@ -6851,8 +6851,8 @@ enum i40e_status_code i40e_blink_phy_link_led(struct i40e_hw *hw,\n * @led_addr: LED register address\n * @reg_val: read register value\n **/\n-static enum i40e_status_code i40e_led_get_reg(struct i40e_hw *hw, u16 led_addr,\n-\t\t\t\t\t u32 *reg_val)\n+enum i40e_status_code i40e_led_get_reg(struct i40e_hw *hw, u16 led_addr,\n+\t\t\t\t u32 *reg_val)\n {\n \tenum i40e_status_code status;\n \tu8 phy_addr = 0;\n@@ -6880,8 +6880,8 @@ static enum i40e_status_code i40e_led_get_reg(struct i40e_hw *hw, u16 led_addr,\n * @led_addr: LED register address\n * @reg_val: register value to write\n **/\n-static enum i40e_status_code i40e_led_set_reg(struct i40e_hw *hw, u16 led_addr,\n-\t\t\t\t\t u32 reg_val)\n+enum i40e_status_code i40e_led_set_reg(struct i40e_hw *hw, u16 led_addr,\n+\t\t\t\t u32 reg_val)\n {\n \tenum i40e_status_code status;\n \tu8 phy_addr = 0;\ndiff --git a/drivers/net/i40e/base/i40e_prototype.h b/drivers/net/i40e/base/i40e_prototype.h\nindex 0d1adb689..0f06e3262 100644\n--- a/drivers/net/i40e/base/i40e_prototype.h\n+++ b/drivers/net/i40e/base/i40e_prototype.h\n@@ -73,7 +73,10 @@ enum i40e_status_code i40e_led_get_phy(struct i40e_hw *hw, u16 *led_addr,\n \t\t\t\t u16 *val);\n enum i40e_status_code i40e_blink_phy_link_led(struct i40e_hw *hw,\n \t\t\t\t\t u32 time, u32 interval);\n-\n+enum i40e_status_code i40e_led_get_reg(struct i40e_hw *hw, u16 led_addr,\n+\t\t\t\t u32 *reg_val);\n+enum i40e_status_code i40e_led_set_reg(struct i40e_hw *hw, u16 led_addr,\n+\t\t\t\t u32 reg_val);\n enum i40e_status_code i40e_get_phy_lpi_status(struct i40e_hw *hw,\n \t\t\t\t\t struct i40e_hw_port_stats *stats);\n enum i40e_status_code i40e_get_lpi_counters(struct i40e_hw *hw, u32 *tx_counter,\n", "prefixes": [ "v2", "32/36" ] }