Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63823/?format=api
http://patches.dpdk.org/api/patches/63823/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191212152124.260629-32-xiaolong.ye@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191212152124.260629-32-xiaolong.ye@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191212152124.260629-32-xiaolong.ye@intel.com", "date": "2019-12-12T15:21:19", "name": "[v2,31/36] net/i40e/base: implement reading lpi statistics", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "af11d2e31796fd017f54813fbc9b89c7173f961c", "submitter": { "id": 1120, "url": "http://patches.dpdk.org/api/people/1120/?format=api", "name": "Xiaolong Ye", "email": "xiaolong.ye@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191212152124.260629-32-xiaolong.ye@intel.com/mbox/", "series": [ { "id": 7813, "url": "http://patches.dpdk.org/api/series/7813/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7813", "date": "2019-12-12T15:20:48", "name": "update for i40e base code", "version": 2, "mbox": "http://patches.dpdk.org/series/7813/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63823/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63823/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BB31BA04F5;\n\tThu, 12 Dec 2019 16:33:34 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4876C1C026;\n\tThu, 12 Dec 2019 16:29:11 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 1CB641BFB3\n for <dev@dpdk.org>; Thu, 12 Dec 2019 16:28:33 +0100 (CET)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 12 Dec 2019 07:28:33 -0800", "from dpdk_yexl_af_xdp.sh.intel.com ([10.67.119.186])\n by orsmga006.jf.intel.com with ESMTP; 12 Dec 2019 07:28:32 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,306,1571727600\"; d=\"scan'208\";a=\"216148424\"", "From": "Xiaolong Ye <xiaolong.ye@intel.com>", "To": "Beilei Xing <beilei.xing@intel.com>,\n\tQi Zhang <qi.z.zhang@intel.com>", "Cc": "dev@dpdk.org,\n\tXiaolong Ye <xiaolong.ye@intel.com>", "Date": "Thu, 12 Dec 2019 23:21:19 +0800", "Message-Id": "<20191212152124.260629-32-xiaolong.ye@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191212152124.260629-1-xiaolong.ye@intel.com>", "References": "<20191202074935.97629-1-xiaolong.ye@intel.com>\n <20191212152124.260629-1-xiaolong.ye@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 31/36] net/i40e/base: implement reading lpi\n\tstatistics", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There was no time duration statistics for LPI (Low Power Idle)\nin EEE (Energy-Efficient Ethernet).\nAdded new procedure to get duration values from FW.\nOtherwise there is no available procedure to get tx_lpi_duration\nand rx_lpi_duration values.\n\nSigned-off-by: Xiaolong Ye <xiaolong.ye@intel.com>\n---\n drivers/net/i40e/base/i40e_common.c | 56 ++++++++++++++++++++++++++\n drivers/net/i40e/base/i40e_prototype.h | 3 ++\n drivers/net/i40e/base/i40e_type.h | 2 +\n 3 files changed, 61 insertions(+)", "diff": "diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c\nindex 8144d957e..d90012fd7 100644\n--- a/drivers/net/i40e/base/i40e_common.c\n+++ b/drivers/net/i40e/base/i40e_common.c\n@@ -7083,6 +7083,62 @@ enum i40e_status_code i40e_get_lpi_counters(struct i40e_hw *hw,\n \treturn I40E_SUCCESS;\n }\n \n+/**\n+ * i40e_get_lpi_duration - read LPI time duration from EEE statistics\n+ * @hw: pointer to the hw struct\n+ * @stat: pointer to structure with status of rx and tx lpi\n+ * @tx_duration: pointer to memory for TX LPI time duration\n+ * @rx_duration: pointer to memory for RX LPI time duration\n+ *\n+ * Read Low Power Idle (LPI) mode time duration from Energy Efficient\n+ * Ethernet (EEE) statistics.\n+ */\n+enum i40e_status_code i40e_get_lpi_duration(struct i40e_hw *hw,\n+\t\t\t\t\t struct i40e_hw_port_stats *stat,\n+\t\t\t\t\t u64 *tx_duration, u64 *rx_duration)\n+{\n+\tu32 tx_time_dur, rx_time_dur;\n+\tenum i40e_status_code retval;\n+\tu32 cmd_status;\n+\n+\tif (hw->device_id != I40E_DEV_ID_10G_BASE_T_BC)\n+\t\treturn I40E_ERR_NOT_IMPLEMENTED;\n+\n+\tretval = i40e_aq_run_phy_activity\n+\t\t(hw, I40E_AQ_RUN_PHY_ACT_ID_USR_DFND,\n+\t\tI40E_AQ_RUN_PHY_ACT_DNL_OPCODE_GET_EEE_DUR,\n+\t\t&cmd_status, &tx_time_dur, &rx_time_dur, NULL);\n+\n+\tif (retval)\n+\t\treturn retval;\n+\tif ((cmd_status & I40E_AQ_RUN_PHY_ACT_CMD_STAT_MASK) !=\n+\t I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)\n+\t\treturn I40E_ERR_ADMIN_QUEUE_ERROR;\n+\n+\tif (hw->phy.link_info.link_speed == I40E_LINK_SPEED_1GB &&\n+\t !tx_time_dur && !rx_time_dur &&\n+\t stat->tx_lpi_status && stat->rx_lpi_status) {\n+\t\tretval = i40e_aq_run_phy_activity\n+\t\t\t(hw, I40E_AQ_RUN_PHY_ACT_ID_USR_DFND,\n+\t\t\tI40E_AQ_RUN_PHY_ACT_DNL_OPCODE_GET_EEE_STAT_DUR,\n+\t\t\t&cmd_status,\n+\t\t\t&tx_time_dur, &rx_time_dur, NULL);\n+\n+\t\tif (retval)\n+\t\t\treturn retval;\n+\t\tif ((cmd_status & I40E_AQ_RUN_PHY_ACT_CMD_STAT_MASK) !=\n+\t\t I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)\n+\t\t\treturn I40E_ERR_ADMIN_QUEUE_ERROR;\n+\t\ttx_time_dur = 0;\n+\t\trx_time_dur = 0;\n+\t}\n+\n+\t*tx_duration = tx_time_dur;\n+\t*rx_duration = rx_time_dur;\n+\n+\treturn retval;\n+}\n+\n /**\n * i40e_lpi_stat_update - update LPI counters with values relative to offset\n * @hw: pointer to the hw struct\ndiff --git a/drivers/net/i40e/base/i40e_prototype.h b/drivers/net/i40e/base/i40e_prototype.h\nindex 2b6198985..0d1adb689 100644\n--- a/drivers/net/i40e/base/i40e_prototype.h\n+++ b/drivers/net/i40e/base/i40e_prototype.h\n@@ -82,6 +82,9 @@ enum i40e_status_code i40e_lpi_stat_update(struct i40e_hw *hw,\n \t\t\t\t\t bool offset_loaded, u64 *tx_offset,\n \t\t\t\t\t u64 *tx_stat, u64 *rx_offset,\n \t\t\t\t\t u64 *rx_stat);\n+enum i40e_status_code i40e_get_lpi_duration(struct i40e_hw *hw,\n+\t\t\t\t\t struct i40e_hw_port_stats *stat,\n+\t\t\t\t\t u64 *tx_duration, u64 *rx_duration);\n /* admin send queue commands */\n \n enum i40e_status_code i40e_aq_get_firmware_version(struct i40e_hw *hw,\ndiff --git a/drivers/net/i40e/base/i40e_type.h b/drivers/net/i40e/base/i40e_type.h\nindex d20b0fe20..af9089829 100644\n--- a/drivers/net/i40e/base/i40e_type.h\n+++ b/drivers/net/i40e/base/i40e_type.h\n@@ -1498,6 +1498,8 @@ struct i40e_hw_port_stats {\n \tu32 rx_lpi_status;\n \tu64 tx_lpi_count;\t\t/* etlpic */\n \tu64 rx_lpi_count;\t\t/* erlpic */\n+\tu64 tx_lpi_duration;\n+\tu64 rx_lpi_duration;\n };\n \n /* Checksum and Shadow RAM pointers */\n", "prefixes": [ "v2", "31/36" ] }{ "id": 63823, "url": "